Re: Building on the AMD64

[Marco Gerards <metgerards@student.han.nl>]

Guillem Jover <guillem@hadrons.org> writes:

Hi Guillem,

> The grub_str* functions are taking 'char *' arguments, but in some
> cases in the code they are given 'usigned char *' for example. 'char'
> is not guaranteed to be signed or usigned on a given architecture, so
> for strings it should not be specified.

Right, but I wondered why the warning does not occur on the PC, I am
just compiling a 32 bits GRUB 2.  Or does someone have this same
problem on the PC with gcc 4.0 and is this not related to my patch?

>> 2005-09-20  Marco Gerards  <mgerards@xs4all.nl>
>
> ...
>
>> 	* conf/i386-pc.rmk (COMMON_CFLAGS): Add `-m32'.
>> 	(COMMON_LDFLAGS): New variable.
>> 	(kernel_img_LDFLAGS): Include `COMMON_FLAGS'.
>> 	(_chain_mod_LDFLAGS, fshelp_mod_LDFLAGS, fat_mod_LDFLAGS,
>
> This should end with ')'.

Nice catch, thanks. :-)

--
Marco