From: Collin Funk <collin.funk1@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Cc: Leo Sandoval <lsandova@redhat.com>
Subject: Re: [PATCH] Fix bootstrap check for po directory
Date: Tue, 17 Mar 2026 14:09:51 -0700 [thread overview]
Message-ID: <87jyva9n8g.fsf@gmail.com> (raw)
In-Reply-To: <CACF7NTiW3yCp+1pDvU22OT1L98e_Nq32E4SqEX7=-mQqEQMb4w@mail.gmail.com>
Leo Sandoval via Grub-devel <grub-devel@gnu.org> writes:
> Azban,
>
> Can you create a PR on freedesktop? I am working on a CONTRIBUTING file but
> for the moment please refer to the email sent recently
>
> https://lists.gnu.org/archive/html/grub-devel/2026-03/msg00036.html
Just want to note that this bootstrap file is imported from Gnulib. I
think it would be better to change there and import it into Grub
(though, I have not looked at the change to know if it is correct).
>
> On Mon, Mar 16, 2026 at 6:35 AM azban <me@azban.net> wrote:
>
>> The syntax for the check here was incorrect. If the directory didn't
>> exist, it would create it, but if it did exist, it would not return and it
>> would redownload.
>>
>> diff --git a/bootstrap b/bootstrap
>> index dc9fb4383..1d9c6a70f 100755
>> --- a/bootstrap
>> +++ b/bootstrap
>> @@ -931,7 +931,7 @@ update_po_files() {
>> # Usually contains *.s1 checksum files.
>> ref_po_dir="$po_dir/.reference"
>>
>> - test -d $ref_po_dir || mkdir $ref_po_dir || return
>> + test -d $ref_po_dir && return || mkdir $ref_po_dir
>> download_po_files $ref_po_dir $domain \
>> && ls "$ref_po_dir"/*.po 2>/dev/null |
>> sed 's|.*/||; s|\.po$||' > "$po_dir/LINGUAS" || return
>>
>> _______________________________________________
>> Grub-devel mailing list
>> Grub-devel@gnu.org
>> https://lists.gnu.org/mailman/listinfo/grub-devel
>>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
prev parent reply other threads:[~2026-03-17 21:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 6:32 [PATCH] Fix bootstrap check for po directory azban
2026-03-17 20:59 ` Leo Sandoval via Grub-devel
2026-03-17 21:09 ` Collin Funk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jyva9n8g.fsf@gmail.com \
--to=collin.funk1@gmail.com \
--cc=grub-devel@gnu.org \
--cc=lsandova@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox