[PATCH] Fix bootstrap check for po directory

[PATCH] Fix bootstrap check for po directory

[azban]

The syntax for the check here was incorrect. If the directory didn't exist, it would create it, but if it did exist, it would not return and it would redownload.

diff --git a/bootstrap b/bootstrap
index dc9fb4383..1d9c6a70f 100755
--- a/bootstrap
+++ b/bootstrap
@@ -931,7 +931,7 @@ update_po_files() {
   # Usually contains *.s1 checksum files.
   ref_po_dir="$po_dir/.reference"

-  test -d $ref_po_dir || mkdir $ref_po_dir || return
+  test -d $ref_po_dir && return || mkdir $ref_po_dir
   download_po_files $ref_po_dir $domain \
     && ls "$ref_po_dir"/*.po 2>/dev/null |
       sed 's|.*/||; s|\.po$||' > "$po_dir/LINGUAS" || return

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Fix bootstrap check for po directory

[Leo Sandoval via Grub-devel]

[-- Attachment #1.1: Type: text/plain, Size: 1133 bytes --]

Azban,

Can you create a PR on freedesktop? I am working on a CONTRIBUTING file but
for the moment please refer to the email sent recently

https://lists.gnu.org/archive/html/grub-devel/2026-03/msg00036.html



On Mon, Mar 16, 2026 at 6:35 AM azban <me@azban.net> wrote:

> The syntax for the check here was incorrect. If the directory didn't
> exist, it would create it, but if it did exist, it would not return and it
> would redownload.
>
> diff --git a/bootstrap b/bootstrap
> index dc9fb4383..1d9c6a70f 100755
> --- a/bootstrap
> +++ b/bootstrap
> @@ -931,7 +931,7 @@ update_po_files() {
>    # Usually contains *.s1 checksum files.
>    ref_po_dir="$po_dir/.reference"
>
> -  test -d $ref_po_dir || mkdir $ref_po_dir || return
> +  test -d $ref_po_dir && return || mkdir $ref_po_dir
>    download_po_files $ref_po_dir $domain \
>      && ls "$ref_po_dir"/*.po 2>/dev/null |
>        sed 's|.*/||; s|\.po$||' > "$po_dir/LINGUAS" || return
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>

[-- Attachment #1.2: Type: text/html, Size: 1846 bytes --]

[-- Attachment #2: Type: text/plain, Size: 141 bytes --]

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] Fix bootstrap check for po directory

[Collin Funk]

Leo Sandoval via Grub-devel <grub-devel@gnu.org> writes:

> Azban,
>
> Can you create a PR on freedesktop? I am working on a CONTRIBUTING file but
> for the moment please refer to the email sent recently
>
> https://lists.gnu.org/archive/html/grub-devel/2026-03/msg00036.html

Just want to note that this bootstrap file is imported from Gnulib. I
think it would be better to change there and import it into Grub
(though, I have not looked at the change to know if it is correct).

>
> On Mon, Mar 16, 2026 at 6:35 AM azban <me@azban.net> wrote:
>
>> The syntax for the check here was incorrect. If the directory didn't
>> exist, it would create it, but if it did exist, it would not return and it
>> would redownload.
>>
>> diff --git a/bootstrap b/bootstrap
>> index dc9fb4383..1d9c6a70f 100755
>> --- a/bootstrap
>> +++ b/bootstrap
>> @@ -931,7 +931,7 @@ update_po_files() {
>>    # Usually contains *.s1 checksum files.
>>    ref_po_dir="$po_dir/.reference"
>>
>> -  test -d $ref_po_dir || mkdir $ref_po_dir || return
>> +  test -d $ref_po_dir && return || mkdir $ref_po_dir
>>    download_po_files $ref_po_dir $domain \
>>      && ls "$ref_po_dir"/*.po 2>/dev/null |
>>        sed 's|.*/||; s|\.po$||' > "$po_dir/LINGUAS" || return
>>
>> _______________________________________________
>> Grub-devel mailing list
>> Grub-devel@gnu.org
>> https://lists.gnu.org/mailman/listinfo/grub-devel
>>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel