From: Marco Gerards <metgerards@student.han.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: symbol.h fix for ARM
Date: Sun, 13 Nov 2005 22:32:37 +0100 [thread overview]
Message-ID: <87veywfd3e.fsf@student.han.nl> (raw)
In-Reply-To: <200511132124.07486.T.E.Baldwin99@members.leeds.ac.uk> (Timothy Baldwin's message of "Sun, 13 Nov 2005 21:24:07 +0000")
Timothy Baldwin <tim.lists@majoroak.f2s.com> writes:
> On Sunday 13 Nov 2005 21:04, Marco Gerards wrote:
>> Timothy Baldwin <tim.lists@majoroak.f2s.com> writes:
>> > In ARM GAS syntax "@" marks the start of comment, which breaks symbol.h.
>> > I choose double quotes as a replacement as they can't be used to start
>> > comments.
>> >
>> > 2005-11-13 Timothy Baldwin <T.E.Baldwin99@members.leeds.ac.uk>
>> >
>> > Fix symbol.h for ARM.
>> >
>> > * include/grub/symbol.h: (FUNCTION): Use double quotes
>> > instead of "@" which marks the start of a comment on ARM.
>> > (VARIABLE): Likewise.
>>
>> Have you tested if other archs keep working with this patch applied?
>
> Tested both i386 and PowerPC. I don't see why it should break elsewhere as
> giving double quotes a conflicting meaning would break .string etc. The GAS
> manual does not mention any system dependences.
Cool. I'll apply this patch right away.
--
Marco
prev parent reply other threads:[~2005-11-13 21:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-13 19:15 symbol.h fix for ARM Timothy Baldwin
2005-11-13 21:04 ` Marco Gerards
2005-11-13 21:24 ` Timothy Baldwin
2005-11-13 21:32 ` Marco Gerards [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87veywfd3e.fsf@student.han.nl \
--to=metgerards@student.han.nl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox