Re: [PATCH v2 1/2] Make grub_error() more verbose

From: Andrew Hamilton <adhamilt@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Cc: "Vladimir 'phcoder' Serbinenko" <phcoder@gmail.com>,
	Leo Sandoval <lsandova@redhat.com>
Subject: Re: [PATCH v2 1/2] Make grub_error() more verbose
Date: Fri, 26 Sep 2025 11:51:32 -0500	[thread overview]
Message-ID: <CA+04=Dau1r4oxZ1jeCopaqa-PhPRRy-w5W9b4EnLac4X0yH3dw@mail.gmail.com> (raw)
In-Reply-To: <CACF7NThyPpHBSx21MJLyqHNAdmmuGm5vocYcbDCxHUT0gNKQ6A@mail.gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 2475 bytes --]

How large is the i386 pc user base, do you think including a conditional
compile to only add for uefi 64-bit covers most cases?

Just a thought.

Thanks,
Andrew

On Fri, Sep 26, 2025 at 11:16 AM Leo Sandoval via Grub-devel <
grub-devel@gnu.org> wrote:

>
>
> On Fri, Sep 26, 2025 at 9:58 AM Vladimir 'phcoder' Serbinenko <
> phcoder@gmail.com> wrote:
>
>>
>>
>> Le jeu. 25 sept. 2025, 21:04, Leo Sandoval <lsandova@redhat.com> a
>> écrit :
>>
>>>
>>>
>>> On Wed, Sep 24, 2025 at 1:55 PM Vladimir 'phcoder' Serbinenko <
>>> phcoder@gmail.com> wrote:
>>>
>>>> What is the influence on core.img size on i386-pc? Are we still within
>>>> our promises for supporting 31K gaps with simple config?
>>>>
>>>
>>> running this in both grub versions
>>>
>>> $ grub2-mkimage -O i386-pc -p /tmp -o core.img biosdisk part_msdos ext2
>>>
>>> core.img file increases from  34538 to 35132 bytes, so the increase is
>>> about 0.6K.
>>>
>>
>> 0.6K out of 31K is a lot. Is there a way to decrease this overhead?
>>
>
> I forgot to indicate that this increase includes this patch and the other
> in the series, which includes the function name also. In general, this 0.6K
> increase includes the file:function:line_number on the logs.
>
> No idea how to decrease it. Any suggestion to try?
>
>
>>
>>
>>>>>  extern grub_err_t EXPORT_VAR(grub_errno);
>>>>>  extern char EXPORT_VAR(grub_errmsg)[GRUB_MAX_ERRMSG];
>>>>>
>>>>> -grub_err_t EXPORT_FUNC(grub_error) (grub_err_t n, const char *fmt,
>>>>> ...)
>>>>> -    __attribute__ ((format (GNU_PRINTF, 2, 3)));
>>>>> +grub_err_t EXPORT_FUNC(grub_error) (grub_err_t n, const char *file,
>>>>> const int line, const char *fmt, ...)
>>>>> +       __attribute__ ((format (GNU_PRINTF, 4, 5)));
>>>>> +
>>>>> +#define grub_error(n, fmt, ...) grub_error (n, __FILE__, __LINE__,
>>>>> fmt, ##__VA_ARGS__)
>>>>> +
>>>>> +
>>>>>  void EXPORT_FUNC(grub_fatal) (const char *fmt, ...) __attribute__
>>>>> ((noreturn));
>>>>>  void EXPORT_FUNC(grub_error_push) (void);
>>>>>  int EXPORT_FUNC(grub_error_pop) (void);
>>>>> --
>>>>> 2.50.1
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Grub-devel mailing list
>>>>> Grub-devel@gnu.org
>>>>> https://lists.gnu.org/mailman/listinfo/grub-devel
>>>>>
>>>> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>

[-- Attachment #1.2: Type: text/html, Size: 5365 bytes --]

[-- Attachment #2: Type: text/plain, Size: 141 bytes --]

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel