From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1aZUrG-0007FE-Bv for mharc-grub-devel@gnu.org; Fri, 26 Feb 2016 21:43:50 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51935) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZUrE-0007Ey-5G for grub-devel@gnu.org; Fri, 26 Feb 2016 21:43:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZUrC-0006qx-Ua for grub-devel@gnu.org; Fri, 26 Feb 2016 21:43:48 -0500 Received: from mail-oi0-x234.google.com ([2607:f8b0:4003:c06::234]:35774) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZUrC-0006qt-FG for grub-devel@gnu.org; Fri, 26 Feb 2016 21:43:46 -0500 Received: by mail-oi0-x234.google.com with SMTP id x143so5149634oix.2 for ; Fri, 26 Feb 2016 18:43:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-transfer-encoding; bh=CyqaONEWo+pEsBt4hUpFs+lyqlHJ1ITHOleKhFXAcp4=; b=c/5UNhUJD+sbYloQ6fZ3gI7fzPfEGlJ0aC5HoQa+KDmwfHf42ej5u8MjsDG+/DAqK9 l3UPu9gZzbAOrQCXQDIt+q/R+ofd/22hjom9RX1G+u4CPfaQifRky/x1dXJvSuRdN2D/ 9MsMOEpFEZD9NC37DlxiyLutGqLWjjfGxctKY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-transfer-encoding; bh=CyqaONEWo+pEsBt4hUpFs+lyqlHJ1ITHOleKhFXAcp4=; b=VuuhNYndsQNtNoG0XaU41Mjt/41VNznT5iyny4FUxPclRwGEGp1ui8nU7SS7gMIVWf OY7USynHAxtrUF1tBE+/Jt22Rj5gZ9v7OwjlhWTw0MeDAxqnIu9z7Gn8A5QRGoJzWd3h 8BvARPxACoXqKoTgnV9D56Xv/BiaIGVZqUGrfuoEiLMccf+rIl0Td6y1rtx1o1oasfKE py3Kfn3RhjhSYGtmETA1wRQkZa5bkTTdcvvzWGyJLDfwOke6PjV3d4GNb7Q7PzT42Mpu +4NBlR937IXzMRyvM6HIbq/09hKLKqUfHi8wegVdCT4BKwWpttDzszVlgdrO9ct7EZ+H /N5A== X-Gm-Message-State: AD7BkJJYGoUtbs/k1TiXUQpxaMGcMxLJeif9ltjtbpZ5D834uQDZ7tmaqutCb8pzoolqEBlgE/Fboh0+AKtRqPcO MIME-Version: 1.0 X-Received: by 10.202.202.139 with SMTP id a133mr3657919oig.28.1456541025833; Fri, 26 Feb 2016 18:43:45 -0800 (PST) Received: by 10.202.71.3 with HTTP; Fri, 26 Feb 2016 18:43:45 -0800 (PST) In-Reply-To: <56D05B45.2050001@gmail.com> References: <1456382355-24614-2-git-send-email-fu.wei@linaro.org> <1456382355-24614-5-git-send-email-fu.wei@linaro.org> <56CF3B24.6030605@gmail.com> <56D05B45.2050001@gmail.com> Date: Sat, 27 Feb 2016 10:43:45 +0800 Message-ID: Subject: Re: [PATCH v2 4/4] arm64: update the introduction of xen boot commands in docs/grub.texi From: Fu Wei To: =?UTF-8?Q?Vladimir_=27=CF=86=2Dcoder=2Fphcoder=27_Serbinenko?= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4003:c06::234 Cc: The development of GNU GRUB , "xen-devel@lists.xensource.com" , Ian Campbell , Andrei Borzenkov , Jon Masters , Julien Grall , Leif Lindholm , Linaro UEFI Mailman List X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Feb 2016 02:43:49 -0000 On 26 February 2016 at 22:03, Vladimir '=CF=86-coder/phcoder' Serbinenko wrote: > On 26.02.2016 12:15, Fu Wei wrote: >> Hi Andrei, >> >> On 26 February 2016 at 18:50, Andrei Borzenkov wro= te: >>> On Fri, Feb 26, 2016 at 8:59 AM, Fu Wei wrote: >>>>>>>> +@subsection xen_module >>>>>>>> >>>>>>>> -@deffn Command xen_linux file [arguments] >>>>>>>> -Load a dom0 kernel image for xen hypervisor at the booting proces= s of xen. >>>>>>>> +@deffn Command xen_module [--nounzip] file [arguments] >>>>>>>> +Load a module for xen hypervisor at the booting process of xen. >>>>>>>> The rest of the line is passed verbatim as the module command line= . >>>>>>>> +Each module will be identified by the order in which the modules = are added. >>>>>>>> +The 1st module: dom0 kernel image >>>>>>>> +The 2nd module: dom0 ramdisk >>>>>>>> +All subsequent modules: UNKNOW >>>>>>>> @end deffn >>>>>>> >>>>>>> Hmm ... from previous discussion I gathered that Xen can detect mod= ule >>>>>>> type. What if there is no initrd for dom0? How can subsequent modul= es be >>>>>> >>>>>> Now , Xen detect module type by the order. (at least on ARM64). >>>>>> I think i386 is using Multiboot(2) protocol, so maybe this order is >>>>>> nothing to do with i386. >>>>>> >>>>> >>>>> Then we have obvious problem with your XSM patch (http://savannah.gnu= .org/bugs/?43420) - XSM may land as the first module. That's actually somet= hing to solve on Xen side I think. It's just that so far we had just kernel= and initrd, so that was non issue. >>>> >>>> Oh, did you mean Wei Liu's patch? >>>> >>>> I guess XSM may land as the third module (or the module after linux >>>> kernel, if you don't have initrd) >>>> >>>> Yes, agree. (That's actually something to solve on Xen side) >>>> >>>> I guess xen can get xsm from a special initrd. so for now there is not >>>> big problem on xsm. >>>> >>>> Please correct me if I misunderstand something. :-) >>>> >>>> Thanks! >>>> >>>> Back to this patch, is that OK for you, or any suggestion? Thanks ! >>>> >>> >>> Yes, as this is dedicated Xen loader we should document this mandatory >>> order - first module must be kernel image, second module must be >>> initrd. I do not think we need to mention possibility to load more >>> than two modules until there is clear understanding how it can be done >>> without initrd. >> >> Great thanks for your review, I have updated and sent the v3 patchset, >> Hope I understood your suggestion correctly, Please check. :-) >> > Your patches look fine. Let's wait for Andrei's opinion but I'm leaning > to commit them Hi Vladimir, Great thanks for your review, :-) Hi Andrei, Do you have any suggestion for my v3 patchset? Please let me know if I can do anything to improve it. Thanks! :-) >> >> > > --=20 Best regards, Fu Wei Software Engineer Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch Ph: +86 21 61221326(direct) Ph: +86 186 2020 4684 (mobile) Room 1512, Regus One Corporate Avenue,Level 15, One Corporate Avenue,222 Hubin Road,Huangpu District, Shanghai,China 200021