From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Vju78-00010P-Sa for mharc-grub-devel@gnu.org; Fri, 22 Nov 2013 12:01:54 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vju70-0000nu-VG for grub-devel@gnu.org; Fri, 22 Nov 2013 12:01:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vju6u-0005nU-1K for grub-devel@gnu.org; Fri, 22 Nov 2013 12:01:46 -0500 Received: from mail-qc0-x229.google.com ([2607:f8b0:400d:c01::229]:59949) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vju6t-0005lm-TL for grub-devel@gnu.org; Fri, 22 Nov 2013 12:01:39 -0500 Received: by mail-qc0-f169.google.com with SMTP id r5so898257qcx.28 for ; Fri, 22 Nov 2013 09:01:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=berentweb.com; s=google; h=mime-version:reply-to:sender:in-reply-to:references:date:message-id :subject:from:to:content-type; bh=hBGCQq5PL0i/98LP5wvbuSzGKP8STLi7kk2vm4RQUFs=; b=juBiL2s6457WcihWtXV13CkV3rELV1/qLley7zaB/buov5vU62vblwoO1dTVelZ1iP t9rgQSylL88tzD0svcpbmxqHyCFXudiQff58kbrav0XEirdoMY3Vvxg8qIcEdZ9E7cTy kJ35Q+durS5g8hQyUhGLhAndCDkiAjSqHtsCg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:sender:in-reply-to :references:date:message-id:subject:from:to:content-type; bh=hBGCQq5PL0i/98LP5wvbuSzGKP8STLi7kk2vm4RQUFs=; b=chLzgoNN98IT/PUY//gPv0qe8WWd59xjd41D3/cITeJ+ctfIdtxHnNqo/KnEzRDPdJ pzv1u5Qw7CazNo9FGoffybw573h371eQj16wB+9AQS24L+ImWcxGPeRMs66Y3qhtU5SV /g4jZInasq6W/jf6y+w4n8Fgon+bu6eVUg2C8N9Kph9NvcnkKflH9kdLPjN8b0FPFAE9 ly2QAqbcPBfi9MWioaKECi5/p7pGDsmnpfMv4CYbdNhMrvRX/83Z7/YnrrGGxlK4qFDB rGsqXbQSJLEb9fjIOcwtPcFAEtFcd+wYvB237Ekyu0YGzFabw4h9nwm/dHbLxS7Jvokv mvpg== X-Gm-Message-State: ALoCoQmLAElm2Gr5JJhf2ok03LpNaA8q20kvRMKoFwACk10dqSbDRByVqxBZd6H+7k3GFhtQ8jZo MIME-Version: 1.0 X-Received: by 10.229.56.200 with SMTP id z8mr23491223qcg.1.1385139699224; Fri, 22 Nov 2013 09:01:39 -0800 (PST) Sender: rsb@berentweb.com Received: by 10.224.122.19 with HTTP; Fri, 22 Nov 2013 09:01:39 -0800 (PST) X-Originating-IP: [83.66.216.233] In-Reply-To: References: Date: Fri, 22 Nov 2013 19:01:39 +0200 X-Google-Sender-Auth: NgG0liMdKGevi_P2IPtszy9hSjw Message-ID: Subject: Re: grub2 boot root-on-zfs errors From: Beeblebrox To: The development of GNU GRUB Content-Type: text/plain; charset=ISO-8859-1 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c01::229 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Nov 2013 17:01:53 -0000 The patched file is giving me an error. I tried patching several times, but keep getting same error. Most likely some stupid error on my part: grub-core/osdep/unix/platform.c:43:4: error: expected expression FILE *fp = fdopen (fd, "r"); ^ grub-core/osdep/unix/platform.c:44:20: error: expected expression get_ofpathname (const char *dev) ^ grub-core/osdep/unix/platform.c:48:18: error: use of undeclared identifier 'fp' while (!feof (fp)) ^ /usr/include/stdio.h:489:43: note: expanded from macro 'feof' #define feof(p) (!__isthreaded ? __sfeof(p) : (feof)(p)) ^ /usr/include/stdio.h:483:23: note: expanded from macro '__sfeof' #define __sfeof(p) (((p)->_flags & __SEOF) != 0) ^ In file included from grub-core/osdep/platform_unix.c:2: grub-core/osdep/unix/platform.c:48:18: error: use of undeclared identifier 'fp' /usr/include/stdio.h:489:55: note: expanded from macro 'feof' #define feof(p) (!__isthreaded ? __sfeof(p) : (feof)(p)) ^ In file included from grub-core/osdep/platform_unix.c:2: grub-core/osdep/unix/platform.c:56:53: error: use of undeclared identifier 'fp' r = fread (ret + offset, 1, alloced - offset, fp); ^ grub-core/osdep/unix/platform.c:60:12: error: use of undeclared identifier 'fp' fclose (fp); Patched section currently looks like: 31 static char * 32 get_ofpathname (const char *dev) 33 { 34 size_t alloced = 4096; 35 char *ret = xmalloc (alloced); 36 size_t offset = 0; 37 int fd; 38 pid_t pid; 39 40 pid = grub_util_exec_pipe ((const char * []){ "ofpathname", dev, NULL }, &fd); 41 if (!pid) 42 43 FILE *fp = fdopen (fd, "r"); 44 get_ofpathname (const char *dev) 45 if (!fp) 46 goto fail; 47 48 while (!feof (fp)) 49 { 50 size_t r; 51 if (alloced == offset) 52 { 53 alloced *= 2; 54 ret = xrealloc (ret, alloced); 55 } 56 r = fread (ret + offset, 1, alloced - offset, fp); 57 offset += r; 58 } 59 60 fclose (fp);