Re: [PATCH] Add apple_set_os command

[andreas@heider.io]

Am 2014-01-07 14:38, schrieb Vladimir 'φ-coder/phcoder' Serbinenko:
> On 30.12.2013 17:04, Andreas Heider wrote:
>> +static const grub_efi_char8_t apple_os_version[] = "Mac OS X 10.9";
>> +static const grub_efi_char8_t apple_os_vendor[]  = "Apple Inc.";
>> +
> Can those be optionally supplied on command line?
> E.g.
> apple_set_os [[VENDOR] VERSION]
> On the other hand we should probably start collecting whitelist of macs
> who need this and do it on them automatically. Idk if there is EFI
> variable to identify mac model from EFI but it's possible from SMBIOS.

I'll try to find the time to implement the command line arguments 
tonight, and I am pretty sure that there is a way to get the model from 
EFI. I just hope that Apple implemented this correctly.

One thing I'm still wondering about is how this could integrate better 
with EFISTUB. Do you know how for example the broadcom fix is applied in 
that scenario? Is the same fix just duplicated in the Linux kernel? 
Because if we implement a whitelist in grub and then suddenly Linux boot 
properly with grub but not directly with EFISTUB things become quite 
ugly.

>> +static grub_err_t
>> +grub_cmd_apple_set_os (grub_command_t cmd __attribute__ ((unused)),
>> +                       int argc __attribute__ ((unused)),
>> +                       char **args __attribute__ ((unused)))
>> +{
>> +  grub_efi_guid_t apple_set_os_guid = 
>> GRUB_EFI_APPLE_SET_OS_PROTOCOL_GUID;
> 
> 
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel