From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W0Y7P-0006PB-8C for mharc-grub-devel@gnu.org; Tue, 07 Jan 2014 09:58:59 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0Y7J-0006OC-0u for grub-devel@gnu.org; Tue, 07 Jan 2014 09:58:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0Y7E-0004mf-8w for grub-devel@gnu.org; Tue, 07 Jan 2014 09:58:52 -0500 Received: from ks35366.kimsufi.com ([213.251.186.122]:33212 helo=meetr.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0Y7E-0004mX-3R for grub-devel@gnu.org; Tue, 07 Jan 2014 09:58:48 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by meetr.de (Postfix) with ESMTP id 679AE4E2D21 for ; Tue, 7 Jan 2014 15:58:46 +0100 (CET) Received: from meetr.de ([127.0.0.1]) by localhost (ks35366.kimsufi.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IyNNWL90+O9c for ; Tue, 7 Jan 2014 15:58:43 +0100 (CET) Received: by meetr.de (Postfix, from userid 33) id 605BA4E2D2F; Tue, 7 Jan 2014 15:58:43 +0100 (CET) To: grub-devel@gnu.org Subject: Re: [PATCH] Add =?UTF-8?Q?apple=5Fset=5Fos=20command?= X-PHP-Originating-Script: 33:rcmail.php MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Date: Tue, 07 Jan 2014 15:58:43 +0100 From: andreas@heider.io In-Reply-To: <52CC033A.2040505@gmail.com> References: <1388419466-2023-1-git-send-email-andreas@heider.io> <52CC033A.2040505@gmail.com> Message-ID: X-Sender: andreas@heider.io User-Agent: Roundcube Webmail/0.9.2 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 213.251.186.122 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jan 2014 14:58:57 -0000 Am 2014-01-07 14:38, schrieb Vladimir '=CF=86-coder/phcoder' Serbinenko: > On 30.12.2013 17:04, Andreas Heider wrote: >> +static const grub_efi_char8_t apple_os_version[] =3D "Mac OS X 10.9"; >> +static const grub_efi_char8_t apple_os_vendor[] =3D "Apple Inc."; >> + > Can those be optionally supplied on command line? > E.g. > apple_set_os [[VENDOR] VERSION] > On the other hand we should probably start collecting whitelist of macs > who need this and do it on them automatically. Idk if there is EFI > variable to identify mac model from EFI but it's possible from SMBIOS. I'll try to find the time to implement the command line arguments=20 tonight, and I am pretty sure that there is a way to get the model from=20 EFI. I just hope that Apple implemented this correctly. One thing I'm still wondering about is how this could integrate better=20 with EFISTUB. Do you know how for example the broadcom fix is applied in=20 that scenario? Is the same fix just duplicated in the Linux kernel?=20 Because if we implement a whitelist in grub and then suddenly Linux boot=20 properly with grub but not directly with EFISTUB things become quite=20 ugly. >> +static grub_err_t >> +grub_cmd_apple_set_os (grub_command_t cmd __attribute__ ((unused)), >> + int argc __attribute__ ((unused)), >> + char **args __attribute__ ((unused))) >> +{ >> + grub_efi_guid_t apple_set_os_guid =3D=20 >> GRUB_EFI_APPLE_SET_OS_PROTOCOL_GUID; >=20 >=20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel