From: Daniel Kiper via Grub-devel <grub-devel@gnu.org>
To: sudhakar <sudhakar@linux.ibm.com>
Cc: Daniel Kiper <daniel.kiper@oracle.com>,
The development of GNU GRUB <grub-devel@gnu.org>,
Lidong Chen <lidong.chen@oracle.com>
Subject: Re: [PATCH] loader/i386/pc/linux: Fix resource leak
Date: Thu, 26 Jun 2025 20:00:34 +0200 [thread overview]
Message-ID: <aF2KwgruudPSaGQt@tomti.i.net-space.pl> (raw)
In-Reply-To: <05fe6a2060f841fdc1ace2ca6f58ff1d@linux.ibm.com>
On Tue, Jun 24, 2025 at 12:27:17AM +0530, sudhakar wrote:
> On 2025-06-23 23:16, Lidong Chen via Grub-devel wrote:
> > In grub_cmd_initrd(), memory is allocated for variable initrd_ctx
> > before calling grub_relocator_alloc_chunk_align_safe(). When the
> > function call fails, initrd_ctx should be freed before exiting
> > grub_cmd_initrd().
> >
> > Fixes: CID 473852
> >
> > Signed-off-by: Lidong Chen <lidong.chen@oracle.com>
>
> it looks good..
>
> Reviewed-by: Sudhakar Kuppusamy <sudhakar@linux.ibm.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
prev parent reply other threads:[~2025-06-26 18:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 17:46 [PATCH] loader/i386/pc/linux: Fix resource leak Lidong Chen via Grub-devel
2025-06-23 18:57 ` sudhakar
2025-06-26 18:00 ` Daniel Kiper via Grub-devel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aF2KwgruudPSaGQt@tomti.i.net-space.pl \
--to=grub-devel@gnu.org \
--cc=daniel.kiper@oracle.com \
--cc=lidong.chen@oracle.com \
--cc=sudhakar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).