From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1cvT1y-0000uB-VY for mharc-grub-devel@gnu.org; Tue, 04 Apr 2017 14:18:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34603) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvT1w-0000u2-HE for grub-devel@gnu.org; Tue, 04 Apr 2017 14:18:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cvT1s-0007V4-Gw for grub-devel@gnu.org; Tue, 04 Apr 2017 14:18:12 -0400 Received: from mail-lf0-x231.google.com ([2a00:1450:4010:c07::231]:33011) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cvT1s-0007Uq-99 for grub-devel@gnu.org; Tue, 04 Apr 2017 14:18:08 -0400 Received: by mail-lf0-x231.google.com with SMTP id h125so97587250lfe.0 for ; Tue, 04 Apr 2017 11:18:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to; bh=z6v0LTcr+uU1xA2fbQrAosO4AtmsEEZSjnetUdgXF44=; b=hqMKas7o+q479Ci6bcqisDTDtskz+02EfATFyUCdbOR0U8cfgjUsBu68pPvVwc6LMG iW6UNYFwDBQqmD9OWA8smvIFU/VOTtcPnFalowCeGwAEtQodsQbCsLMimeZKSpZPjisw n7R456SL4BZSmZVVsoadi+Mdsibn+gVBWXRMVFJn0abccRfs30F3eWVRlRX0cUcnBHRR iSplOCXQ/kh4t/N26+Bvo735nSNX5PghK/yGw8ksc/F/Wrk2Put6hI1MYMv6FoKAN0Ag 27iQasvME28a+QKGR1x5e0Uk1mZzJUANeSvm59YV35KcdYKEohH1eXSzL3Ol6k9u83H1 2lCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to; bh=z6v0LTcr+uU1xA2fbQrAosO4AtmsEEZSjnetUdgXF44=; b=Ah+dwTuRQW4F9wQus6cQu58vrF61bbYxLP/EjU44GEj9uKyGpxei7EypVCD2oXX6al vbfORcexcwrwUdFEksclZpP0P6PKqWqfya746HVKQDNeXr+XtxcMd+0sjqWUSFgeNVtU 5yXYWUxRSxKy+rOeCxf7uaw5+rsBBHl1JFTbqrSAv/FH++2eLLvwQyWEY89emsnr9Z3+ fY31qtNCgJO2PqjNopXjMKALKQUYKawWQdgZOusj73pdrQDBRsV2BJeoPlqPNZd+9R0o /TOadNoBpm1vo850j6c2pyBep8cF9zLh+3SZ1ymEgyXvEncWy/Mdk/NThlKhsGbBihXQ llgg== X-Gm-Message-State: AFeK/H2UZtYZg6GBpAejElUQPntfz97jvjHSDvZgX8RcaS2o9BiaH0DQwQEBIwy9EjHJnA== X-Received: by 10.25.89.135 with SMTP id n129mr6779435lfb.180.1491329886632; Tue, 04 Apr 2017 11:18:06 -0700 (PDT) Received: from [192.168.1.6] (ppp109-252-90-38.pppoe.spdop.ru. [109.252.90.38]) by smtp.gmail.com with ESMTPSA id b75sm3250373lfh.36.2017.04.04.11.18.05 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Apr 2017 11:18:05 -0700 (PDT) Subject: [PATCH] acpi: do not attempt to create EBDA on EFI (was: Loading DSDT table using 'acpi' or some memory write command?) To: The development of GNU GRUB References: <1736729449.4676062.1487865639993.ref@mail.yahoo.com> <1736729449.4676062.1487865639993@mail.yahoo.com> <229125734.2281203.1488194973248@mail.yahoo.com> <144480689.2460565.1488208393781@mail.yahoo.com> <1893359760.2685777.1488219706759@mail.yahoo.com> <967677258.4693596.1490623960099@mail.yahoo.com> <1390664917.8322220.1490809510437@mail.yahoo.com> From: Andrei Borzenkov Message-ID: Date: Tue, 4 Apr 2017 21:18:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------54C178CB5FA36A4B0FA1A4B8" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::231 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2017 18:18:13 -0000 This is a multi-part message in MIME format. --------------54C178CB5FA36A4B0FA1A4B8 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit 01.04.2017 12:09, Andrei Borzenkov пишет: > > I also have rather weird issue that after "acpi dsdt.aml" I lose > partitions (only hard disk itself is visible). This is on real hardware > (Dell Latitude E5450). > > Anyone knows why we attempt to write to some arbitrary memory location on EFI in the first place? --------------54C178CB5FA36A4B0FA1A4B8 Content-Type: text/x-patch; name="acpi-no-ebda-on-efi.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="acpi-no-ebda-on-efi.patch" From: Andrei Borzenkov Subject: [PATCH] acpi: do not attempt to create EBDA on EFI There is no gurantee that BDA or EBDA on EFI exists; blindly writing into memory will likely corrupt it. This fixed problem on Dell Latitude E5450, where after loading ACPI table GRUB "lost" all disk partitions. --- grub-core/commands/acpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/grub-core/commands/acpi.c b/grub-core/commands/acpi.c index 9f02f22..a395d74 100644 --- a/grub-core/commands/acpi.c +++ b/grub-core/commands/acpi.c @@ -119,7 +119,7 @@ grub_acpi_get_rsdpv1 (void) return grub_machine_acpi_get_rsdpv1 (); } -#if defined (__i386__) || defined (__x86_64__) +#if defined (__i386__) && !defined (GRUB_MACHINE_EFI) static inline int iszero (grub_uint8_t *reg, int size) @@ -741,7 +741,7 @@ grub_cmd_acpi (struct grub_extcmd_context *ctxt, int argc, char **args) } acpi_tables = 0; -#if defined (__i386__) || defined (__x86_64__) +#if defined (__i386__) && !defined (GRUB_MACHINE_EFI) if (! state[9].set) { grub_err_t err; -- tg: (007f0b4..) u/acpi-skip-ebda-on-efi (depends on: master) --------------54C178CB5FA36A4B0FA1A4B8--