From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1cyLUq-0003f4-G6 for mharc-grub-devel@gnu.org; Wed, 12 Apr 2017 12:51:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cyLUo-0003ey-A4 for grub-devel@gnu.org; Wed, 12 Apr 2017 12:51:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cyLUj-0003Ch-C9 for grub-devel@gnu.org; Wed, 12 Apr 2017 12:51:54 -0400 Received: from mail-wr0-x230.google.com ([2a00:1450:400c:c0c::230]:32977) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cyLUj-0003Br-5x for grub-devel@gnu.org; Wed, 12 Apr 2017 12:51:49 -0400 Received: by mail-wr0-x230.google.com with SMTP id l28so21331951wre.0 for ; Wed, 12 Apr 2017 09:51:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=uqOKwC6PSbUflnZ/ptYA1HOLhDoRR1RtA8owHi0X5Ec=; b=SJLo7BLTlK+joKRDZq1wgyAu/CYATdgfNPw9xRWjtcJ+vkG7UKXUgdPXKaYdX2ht6s h1YYnWscEi/W1Y1TSz/qnKj+pfHy8wklEXuqeHPyVBvhWPag3DLlBTWu80mqzL2X5OdA kM6PTbXBUvwtjBPtUBOS6Qlt2J+B+uo7L9qT37vHa1xmFU2GtDcVqcFkCRI2+x9Cvzas FH/C5qfiCCP+6stG12giiIer/zZ8wlE+WxSa5KBhYz25fP+D1skQ3qCuC2gHG+DM4yMo Gmkc7WsQG2vwPGvi+Ei1AvmqdKXMuON8oMGrbQIrpM/6Ez4zxzy8YBNguXpLW5o6l26Q NVJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=uqOKwC6PSbUflnZ/ptYA1HOLhDoRR1RtA8owHi0X5Ec=; b=T1pTMuL+5K+Pc+13sS9S87aRHmBWyvENHFlT7f/GDv6A83XdOf4tkIUEisQ93mf7do jGregzrGRlEONJnHsmsyQDCo7N/rbl9K5aObNnWxmX6rr4f0mhl20STfXmvxmbpVVQUh i0J7fkwmjilSSmt12G5i4Gmap3SeyyDQ/gxBXmQDNXGkcaLZ111wks/33Qz1UpP6M2Oa ESHXHQzyPpVOrlPEPFs2U+PxgHKqdDzL0JJX3OrXeJ3LrlBapYJ4xvPIq1hXHsmAq4NH v09n9vAh0FMHWuF0uRre/rQtAuNThZjde6IOdkwpVteCQN3m/vLoOo74g955GdK35/GJ caVw== X-Gm-Message-State: AN3rC/4kBYMk0NrYqwQCTQ4o+WaCUWDCPf2LV9tV8VElzFuIA98dicCRRlzpeWdCfu6siA== X-Received: by 10.223.128.99 with SMTP id 90mr4049940wrk.101.1492015907736; Wed, 12 Apr 2017 09:51:47 -0700 (PDT) Received: from [192.168.254.200] (82-69-89-171.dsl.in-addr.zen.co.uk. [82.69.89.171]) by smtp.googlemail.com with ESMTPSA id l19sm5075888wre.2.2017.04.12.09.51.46 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Apr 2017 09:51:46 -0700 (PDT) Subject: Re: Contribution To: grub-devel@gnu.org References: From: Nicole Message-ID: Date: Wed, 12 Apr 2017 17:51:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::230 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Apr 2017 16:51:55 -0000 Thank you for your kind reply, Vladimir. I failed to find the probe command - I promise - I spent quite a few hours digging through the source. As for the $((...)) and $[...] - I'll look into it. It seems that my paltry contributions are not needed, after all. Nicole > Date: Wed, 12 Apr 2017 10:41:19 +0000 > From: "Vladimir 'phcoder' Serbinenko" > To: The development of GNU GRUB > Subject: Re: Contribution > Message-ID: > > Content-Type: text/plain; charset="utf-8" > > On Wed, Apr 12, 2017, 20:37 Nicole wrote: > >> I have written two small, simple modules to address limitations I found >> in in Grub. >> >> 1. does simple arithmetic - nothing fancy. It's invoked by using >> something like this: >> >> insmod arithmetic >> arithmetic --set fred --min 2 -- max 10 "1" "+" "2" >> >> the operators supported are unary -,!; binary +,-,/,*,%,<,<=,<.<=,!=,== >> --set works in the usual way. If the result is greater than --max, the >> --min value is returned and vice versa; this useful for cycling round a >> group of partitions in a round-robin fashion >> > Can you have a look if we can have bash syntax $((...)) and $[...] instead? > It's more compact and nicer. > >> >> 2. diskinfo.mod introduces two commands: disklabel, diskuuid which >> return the label and uuid of the specified disk partition. This is >> useful where, having decided which partition, amongst several, to boot, >> you can fill in the appropriate value in the "root=UUID=" or >> "root=label=" Linux kernel parameter. >> > Have a look at probe command. Does it cover your usecase? > >> >> I looked for details on how to submit new modules, but failed to find >> anything. How do I go about this? >> > Just send patches here. > >> >> Nicole >> >> >> _______________________________________________ >> Grub-devel mailing list >> Grub-devel@gnu.org >> https://lists.gnu.org/mailman/listinfo/grub-devel >>