From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kdbG4-0000uF-5F for mharc-grub-devel@gnu.org; Fri, 13 Nov 2020 10:45:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34148) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdbG2-0000tv-Hn for grub-devel@gnu.org; Fri, 13 Nov 2020 10:45:02 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:29362) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdbFz-0004l4-GY for grub-devel@gnu.org; Fri, 13 Nov 2020 10:45:02 -0500 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0ADFXWAE013004; Fri, 13 Nov 2020 10:44:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : reply-to : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=jh7u5UGnP+U8h+te0KQjSy7hRWR9qZ+SgZoWBZrp+rc=; b=d2CFeIwMlAIBc7TbtaAg58bHxBRcWuX295WJsRJODzOlVtchLjUP0VYPZZm5OYR64Go7 ZFCGZN45wGMSiBU4VfeK0aZ37EjcPjCUM85aZ4lZ3pDvKE6+Eu//YXqdXLmqoN/pIBV/ ghneu8dXnO/RlYe5P/NtTJILdBJBLUsdBFTsyGR81CVssZgOdbTKRG9za0AR5srk/ip2 DWYY7OSBIdPU3GKr8rUKf84ccp0PuDBz4YAwwvOKTTkTc/e0Vhfkp9gP8kUrTX1En0os oAIJnSKxem+4LRonTk1d38s/M0PKLVXh5JeDgwZ0lFSarKdue/q5Wm0MXab2+FAjZ749 4A== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 34sve5sfdp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Nov 2020 10:44:54 -0500 Received: from m0098393.ppops.net (m0098393.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 0ADFXsdo015306; Fri, 13 Nov 2020 10:44:54 -0500 Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com with ESMTP id 34sve5sfd1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Nov 2020 10:44:54 -0500 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0ADFbZlb005800; Fri, 13 Nov 2020 15:44:53 GMT Received: from b03cxnp08025.gho.boulder.ibm.com (b03cxnp08025.gho.boulder.ibm.com [9.17.130.17]) by ppma03dal.us.ibm.com with ESMTP id 34nk7aghck-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Nov 2020 15:44:52 +0000 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0ADFihYB64881026 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 13 Nov 2020 15:44:43 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3B8EA7805E; Fri, 13 Nov 2020 15:44:49 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0D8F278067; Fri, 13 Nov 2020 15:44:45 +0000 (GMT) Received: from jarvis.int.hansenpartnership.com (unknown [9.85.145.64]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP; Fri, 13 Nov 2020 15:44:45 +0000 (GMT) Message-ID: Subject: Re: [PATCH 1/3] cryptodisk: make the password getter and additional argument to recover_key From: James Bottomley Reply-To: jejb@linux.ibm.com To: development@efficientek.com Cc: The development of GNU GRUB , dovmurik@linux.vnet.ibm.com, Dov.Murik1@il.ibm.com, ashish.kalra@amd.com, brijesh.singh@amd.com, tobin@ibm.com, david.kaplan@amd.com, jon.grimm@amd.com, thomas.lendacky@amd.com, frankeh@us.ibm.com, "Dr . David Alan Gilbert" Date: Fri, 13 Nov 2020 07:44:44 -0800 In-Reply-To: <20201113000256.47578926@crass-HP-ZBook-15-G2> References: <20201113012206.24246-1-jejb@linux.ibm.com> <20201113012206.24246-2-jejb@linux.ibm.com> <20201113000256.47578926@crass-HP-ZBook-15-G2> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312, 18.0.737 definitions=2020-11-13_10:2020-11-13, 2020-11-13 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 impostorscore=0 clxscore=1011 spamscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 phishscore=0 mlxscore=0 mlxlogscore=999 suspectscore=3 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011130099 Received-SPF: pass client-ip=148.163.156.1; envelope-from=jejb@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/13 09:01:54 X-ACL-Warn: Detected OS = Linux 3.x [generic] [fuzzy] X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Nov 2020 15:45:02 -0000 On Fri, 2020-11-13 at 00:02 -0600, Glenn Washburn wrote: [...] > diff --git a/grub-core/disk/geli.c b/grub-core/disk/geli.c > > index e9d23299a..5514c16a3 100644 > > --- a/grub-core/disk/geli.c > > +++ b/grub-core/disk/geli.c > > @@ -398,7 +398,8 @@ configure_ciphers (grub_disk_t disk, const char > > *check_uuid, } > > > > static grub_err_t > > -recover_key (grub_disk_t source, grub_cryptodisk_t dev) > > +recover_key (grub_disk_t source, grub_cryptodisk_t dev, > > + grub_passwd_cb *password_get) > > { > > grub_size_t keysize; > > grub_uint8_t digest[GRUB_CRYPTO_MAX_MDLEN]; > > @@ -442,7 +443,7 @@ recover_key (grub_disk_t source, > > grub_cryptodisk_t dev) source->partition ? "," : "", tmp ? : "", > > dev->uuid); > > grub_free (tmp); > > In luks.c and luks2.c below, grub_printf_ is made conditional, but > not here. It probably should be. Yes, I can add that. James