public inbox for grub-devel@gnu.org
 help / color / mirror / Atom feed
From: Glenn Washburn <development@efficientek.com>
To: grub-devel@gnu.org
Cc: Daniel Kiper <dkiper@net-space.pl>,
	Leo Sandoval <lsandova@redhat.com>,
	Glenn Washburn <development@efficientek.com>
Subject: [PATCH 1/2] tests/grub_cmd_cryptomount: Expect test success, now that GRUB supports Argon2
Date: Mon, 17 Nov 2025 00:40:25 -0600	[thread overview]
Message-ID: <bb8267c5e880cec218fc2a535ba3fbbe23f5dcb9.1763360459.git.development@efficientek.com> (raw)
In-Reply-To: <cover.1763360459.git.development@efficientek.com>

This test was included to verify that, while GRUB did not have Argon2
support, trying to open a LUKS2 volume with an Argon2 keyslot would fail
Now that Argon2 support is included, the test is failing because it
expected a failure, but is now getting success. Change the test to expect
success.

Signed-off-by: Glenn Washburn <development@efficientek.com>
---
 tests/grub_cmd_cryptomount.in | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/grub_cmd_cryptomount.in b/tests/grub_cmd_cryptomount.in
index eaa187efad0a..a4fababa0a80 100644
--- a/tests/grub_cmd_cryptomount.in
+++ b/tests/grub_cmd_cryptomount.in
@@ -178,8 +178,7 @@ eval testcase "'LUKS2 test with different metadata size:'" \
     @builddir@/grub-shell-luks-tester $LUKS2_COMMON_OPTS $COMMON_OPTS \
         "--cs-opts='--luks2-metadata-size 512k'"
 
-# TODO: Expect a failure with LUKS2 volumes with argon2 key derivation
-eval testcase_fail "'LUKS2 test with argon2 pbkdf:'" \
+eval testcase "'LUKS2 test with argon2 pbkdf:'" \
     @builddir@/grub-shell-luks-tester --luks=2 $COMMON_OPTS \
         "--cs-opts='--pbkdf-memory 32'" "--cs-opts='--pbkdf-parallel 1'"
 
-- 
2.34.1


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

  reply	other threads:[~2025-11-17  6:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-17  6:40 [PATCH 0/2] Expect success for argon2 cryptomount test Glenn Washburn
2025-11-17  6:40 ` Glenn Washburn [this message]
2025-11-18  6:35   ` [PATCH 1/2] tests/grub_cmd_cryptomount: Expect test success, now that GRUB supports Argon2 Sudhakar Kuppusamy
2025-11-17  6:40 ` [PATCH 2/2] tests/grub_cmd_cryptomount: Use builddir shell variable and quote Glenn Washburn
2025-11-18  6:35   ` Sudhakar Kuppusamy
2025-11-17 17:46 ` [PATCH 0/2] Expect success for argon2 cryptomount test Daniel Kiper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb8267c5e880cec218fc2a535ba3fbbe23f5dcb9.1763360459.git.development@efficientek.com \
    --to=development@efficientek.com \
    --cc=dkiper@net-space.pl \
    --cc=grub-devel@gnu.org \
    --cc=lsandova@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox