From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1bwYB2-0004w5-C1 for mharc-grub-devel@gnu.org; Tue, 18 Oct 2016 13:27:48 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40320) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwYAz-0004su-L9 for grub-devel@gnu.org; Tue, 18 Oct 2016 13:27:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwYAw-0003Us-WE for grub-devel@gnu.org; Tue, 18 Oct 2016 13:27:45 -0400 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:32859) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bwYAw-0003Um-O5 for grub-devel@gnu.org; Tue, 18 Oct 2016 13:27:42 -0400 Received: by mail-lf0-x244.google.com with SMTP id l131so27266lfl.0 for ; Tue, 18 Oct 2016 10:27:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=7R4XKdnqt+NdO/wfXgANJu5r7N+4cI7X4y5+YEKX1Hk=; b=eD8z69LlieS+rVcNZMlcme3GScfxUcYSBamsYoTgsz2CjwYL58b9UBQDzxXVkYCSoJ SV1FqWAZ3NT+L2mhap5f7Wy20vuntXiB9F4Uka/Lqys6dkeV5MPzoxRWGwAbZ21xUtqL MG9MDvq2dLNnnyDge8wCePJRWkgz7HtP8+kULdy86DcZr2OjC+5WHvX7LCAScdfEnA9b ugai7HhrYy5QPvxKnR+FxYpsNTxyH8Rf1oY2apse1wW9PKLT+KmHTtIXZYccY5zbBR9M rauyK9JPQKEef9E0he6aYjVPzqlu5UfyKL5xfjViwyVw6AgNSCvjW5rQedtgdVOmvAXi TuJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=7R4XKdnqt+NdO/wfXgANJu5r7N+4cI7X4y5+YEKX1Hk=; b=lP4NNKLhQF67d0vBr35OxW0Zdj/spwJQEXvFVd6EWKtEe/PK/zIERuulTaEDpoySO0 P8j6PQzlmNKF2XGKkASCeqy4bjFLb6ziGFdz2mJhH+EFWM97hrUTTj1zY6eRTO8UduAl ap4dj7E9UBoKhH4PeUJI+unyw2Dsv+I0LtZQj9nDQwfveICMmza4P/IPQqfN0G9SKc0r OvYLfp3g9Cqp5ttDqXMa60jEMmM4qNTCZ3VWlXUZ66ymQqIFz+TiOG5nHeVIPsjrG/EV 5y1dQ52Q+2I3iWgvErCxIrJwh/lJlmK9WVjOuYsnwbvYxJanlSWUFLKYhEGZAs5Dat4g 4/hw== X-Gm-Message-State: AA6/9Rlsyrdry8aWH9ea5lQGg8JjfMbbNzkaW6+jmMtX1nd50KbAATj0BDunVw/Yt0qHuw== X-Received: by 10.25.29.1 with SMTP id d1mr1721737lfd.121.1476811660986; Tue, 18 Oct 2016 10:27:40 -0700 (PDT) Received: from [192.168.1.44] (ppp109-252-90-102.pppoe.spdop.ru. [109.252.90.102]) by smtp.gmail.com with ESMTPSA id 206sm3137786ljj.0.2016.10.18.10.27.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Oct 2016 10:27:40 -0700 (PDT) Subject: Re: [PATCH] net/ip: Fix limit_time calculation in freeing old fragments To: The development of GNU GRUB , Sakar Arora References: <1476474982-7603-1-git-send-email-sakar.arora@nxp.com> Cc: Bhupesh Sharma From: Andrei Borzenkov Message-ID: Date: Tue, 18 Oct 2016 20:27:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::244 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2016 17:27:46 -0000 Committed with trivial formatting change. Thank you! 17.10.2016 08:30, Sakar Arora пишет: > Hi > > Sending the below mentioned patch as an attachment. Please review. > > Thanks, > Sakar > > -----Original Message----- > From: Sakar Arora [mailto:sakar.arora@nxp.com] > Sent: Saturday, October 15, 2016 1:26 AM > To: grub-devel@gnu.org > Cc: Bhupesh Sharma ; Sakar Arora > Subject: [PATCH] net/ip: Fix limit_time calculation in freeing old fragments > > From: Sakar Arora > > limit_time underflows when current time is less than 90000ms. > This causes packet fragments received during this time, i.e., till 90000ms pass since timer init, to be rejected. > > Hence, set it to 0 if its less than 90000. > > Signed-off-by: Sakar Arora > --- > grub-core/net/ip.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/grub-core/net/ip.c b/grub-core/net/ip.c index 8c56baa..4dae207 100644 > --- a/grub-core/net/ip.c > +++ b/grub-core/net/ip.c > @@ -363,7 +363,9 @@ static void > free_old_fragments (void) > { > struct reassemble *rsm, **prev; > - grub_uint64_t limit_time = grub_get_time_ms () - 90000; > + grub_uint64_t limit_time = grub_get_time_ms (); > + > + limit_time = (limit_time > 90000)?limit_time - 90000:0; > > for (prev = &reassembles, rsm = *prev; rsm; rsm = *prev) > if (rsm->last_time < limit_time) > -- > 1.9.1 > > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >