From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1exdVr-0003nx-Fl for mharc-grub-devel@gnu.org; Sun, 18 Mar 2018 14:58:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1exdVq-0003nk-4k for grub-devel@gnu.org; Sun, 18 Mar 2018 14:58:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1exdVp-00047w-D0 for grub-devel@gnu.org; Sun, 18 Mar 2018 14:58:34 -0400 Received: from mail-pl0-x231.google.com ([2607:f8b0:400e:c01::231]:43971) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1exdVp-000472-6z for grub-devel@gnu.org; Sun, 18 Mar 2018 14:58:33 -0400 Received: by mail-pl0-x231.google.com with SMTP id f23-v6so8912569plr.10 for ; Sun, 18 Mar 2018 11:58:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to; bh=9VW0sL1w1wZdu+WOjj0TBel5/Bes8C9ztm68qPo2Pac=; b=PsCI1xKu/KC+dSrp5iuTxWkHNgsatSLqPYBfF5jZkS+kOXH/vPYITULte5UKzCIwbG kBIorV274yLcaqxB+4XICGP9mtckTl6m8Yt1bvBKRCBHmqZ2BD8/6e4XKxiunz3lbBLc j+8CZ0xqVrQMhHMDU9NTEo5FNzO6J7gdquPpALPYxQYfeQfV1K6YNCLfdnoT1I/L0c6w gOes4ZhRhrjMk+0YP2/M3XczS3IRAYlO1LOMmK0PjSXcygH5oIRIRaFQWok8AwfQrrOA bksi6idFnlvF5lwcazHXLfeXZfWXEvhiEdwGNp8uzqDLJfKY0J9uNe0z1DDfXGKuLz2g CfDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to; bh=9VW0sL1w1wZdu+WOjj0TBel5/Bes8C9ztm68qPo2Pac=; b=FnyLKqOLV6NAkGEBFFMZ4HPZaMhz0rzeVTHwXaLoVzF5s5htkBWndYK+z5w8IZL7Z1 CNL42wi9N/GYTu5Yv+YfzUZZtmOqf2qw9fcH2/qUY69UGo+R5B67NX8hvLov4/IiyPTI qUy0nk24AkLZstbfdQn2Mzom0Y6zhuHqX5238dPRsPy04fvdDTIdroTalX1yPwrb9Hn9 QTp1WY9mIST/3jEq372JyG5C41FE7BknwAjH/+F1VPfeBVToLfiKPqFMMCaPxqVHvhJy 14b6LycAdQtf7kMp3u/QS3sLNhMGNU+Ht5EkwJImaxDgQKE+kfkzn4IMcMvcRxCgtUjo FsAQ== X-Gm-Message-State: AElRT7Gqf9uEfKDbwQNEoZbR/czupLFMzQkHnXpWKzzuVRqfzjZ5AdHD 6WRifIHRvZFWF/zbHRoWWZ2Rqw== X-Google-Smtp-Source: AG47ELsPBtta0M5EqifhYQ2UXk2Ta7o8otJV2X08vHZ0Yg/SzDQn/hB2Gb/l7RR5vW6oPihpcAcOGA== X-Received: by 2002:a17:902:7291:: with SMTP id d17-v6mr9902840pll.65.1521399511058; Sun, 18 Mar 2018 11:58:31 -0700 (PDT) Received: from ?IPv6:2601:602:9c01:e86a:2ec2:3a19:cd81:76ab? ([2601:602:9c01:e86a:2ec2:3a19:cd81:76ab]) by smtp.googlemail.com with ESMTPSA id e10sm22564546pff.151.2018.03.18.11.58.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Mar 2018 11:58:29 -0700 (PDT) Subject: Re: [GRUB PARTUUID PATCH V5 1/3] Update grub_gpt_partentry; centralize guid prints To: Daniel Kiper Cc: grub-devel@gnu.org References: <20180204194737.22662-1-nvinson234@gmail.com> <20180204194737.22662-2-nvinson234@gmail.com> <20180220173019.GF29532@router-fw-old.local.net-space.pl> From: Nick Vinson Message-ID: Date: Sun, 18 Mar 2018 11:58:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180220173019.GF29532@router-fw-old.local.net-space.pl> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rI0o6kZ8QnwEfCHi7ZY8NukpVrlceB33N" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::231 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Mar 2018 18:58:35 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rI0o6kZ8QnwEfCHi7ZY8NukpVrlceB33N Content-Type: multipart/mixed; boundary="C7jGJxVooByRLNgSngrI1y62osRYi0dSe"; protected-headers="v1" From: Nick Vinson To: Daniel Kiper Cc: grub-devel@gnu.org Message-ID: Subject: Re: [GRUB PARTUUID PATCH V5 1/3] Update grub_gpt_partentry; centralize guid prints References: <20180204194737.22662-1-nvinson234@gmail.com> <20180204194737.22662-2-nvinson234@gmail.com> <20180220173019.GF29532@router-fw-old.local.net-space.pl> In-Reply-To: <20180220173019.GF29532@router-fw-old.local.net-space.pl> --C7jGJxVooByRLNgSngrI1y62osRYi0dSe Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Sorry for the delay in responding. I just now saw these replies. On 02/20/2018 09:30 AM, Daniel Kiper wrote: > On Sun, Feb 04, 2018 at 11:47:35AM -0800, Nicholas Vinson wrote: >> To help clean the code and simplify the code in util/grub-probe.c, thi= s >> patch renames grub_gpt_part_type to grub_gpt_part_guid and updates >> grub_gpt_partentry to use this type for both the partition type GUID >> string and the partition GUID string entries. >> >> This patch also moves the GUID printing logic in util/grub-probe.c to = a >> separate function. This change allows the partuuid logic in the next >> commit to use the same printing logic without having to completely >> duplicate it. >=20 > One logical change per patch please... Done. I've split this patch into two. > And please add your SOB next time. Done. I'll submit a version 6 shortly. Thanks, Nicholas Vinson >=20 > Daniel >=20 --C7jGJxVooByRLNgSngrI1y62osRYi0dSe-- --rI0o6kZ8QnwEfCHi7ZY8NukpVrlceB33N Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE18QFYzlwGKI8bhHQAGpoeGzkaOIFAlquts0ACgkQAGpoeGzk aOLGmBAAsLTbm17lcB27s3STLvfQ1x3gLmd87kMW5HrHsJmd9oCBWSHQFSwadUzH q7jm8XIdrLilzpnq2OrLF3ys5T3kxvLmGW7vWHguDfxUo+Pi8tEllgjUBwIIHCRi LvAZvaq0v29R73LXRag+zeTCqDWcvyUdz2ASztxg2lD8JSZ8LCMwiOXvN4n5EVuI sfAhRT9FdPt5v0c4H+kmxnTd1ibHp4fyCbE2TlZJPRDLvU3B6L/1fVnomlwTOUTI nY4xTYCw7WnIr9CsSfNRx9AwxYfBpJQCnYA7S0Nxm8sAgKtVOi2SXw7ze/XA3gAM xeiu0iqP9mpzW6fsPjFZxuDwbLcy88VToMqjKrwnAcHKOJlkuHf4wtKl9vrr74rX mMxTy43sFlEljJhWt8WqBs78USKqdEG5MlAbAakC+EB0XdB2VFHXw9RVdoJTLeAx HyZCpYmO1XZG66ZOhOI9BqshlAkz+OVdgzBh+zOBAHuuh02DZPvmQuZOFCc8ucn4 AUQQDnamVBKEtLVRIZN8k4unT1XuQl0qYo0Q16wnkFcN+IQWk7jsE/umzvPQXRq/ w0vmhlqUkXcLiN623rjZxOzRl9Jw1v2PkB8yzEJhJlLFNLZZNkB3Wad+pk9DRdc5 tUr8m+pyXJHyboec7B1l7dqYVuiiViZVI/M+ha6HR4hDXdgF4ew= =vu3R -----END PGP SIGNATURE----- --rI0o6kZ8QnwEfCHi7ZY8NukpVrlceB33N--