grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: Andrei Borzenkov <arvidjaar@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>, linux@endlessm.com
Cc: Carlo Caione <carlo@endlessm.com>
Subject: Re: [PATCH] exfat: Read the contiguous flag from the correct extension
Date: Thu, 20 Oct 2016 20:38:51 +0300	[thread overview]
Message-ID: <c78b2f01-57f1-e469-4ff2-2ae521c539b0@gmail.com> (raw)
In-Reply-To: <1476890402-12496-1-git-send-email-carlo@caione.org>

19.10.2016 18:20, Carlo Caione пишет:
> From: Carlo Caione <carlo@endlessm.com>
> 
> dir.is_contiguous flag is being set reading into the wrong struct.
> This is causing a fragmented file not to be readable from an exfat
> partition since the NoFatChain bit is wrong. Fix this.
> 
> Signed-off-by: Carlo Caione <carlo@endlessm.com>
> ---
>  grub-core/fs/fat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/grub-core/fs/fat.c b/grub-core/fs/fat.c
> index d5212c2..dd8850a 100644
> --- a/grub-core/fs/fat.c
> +++ b/grub-core/fs/fat.c
> @@ -684,7 +684,7 @@ grub_fat_iterate_dir_next (grub_disk_t disk, struct grub_fat_data *data,
>  		  ctxt->dir.file_size
>  		    = grub_cpu_to_le64 (sec.type_specific.stream_extension.file_size);
>  		  ctxt->dir.have_stream = 1;
> -		  ctxt->dir.is_contiguous = !!(dir.type_specific.stream_extension.flags
> +		  ctxt->dir.is_contiguous = !!(sec.type_specific.stream_extension.flags

This is fixed almost a year ago. Please always check current git whether
problem still exists. Thank you.

>  					       & grub_cpu_to_le16_compile_time (FLAG_CONTIGUOUS));
>  		  break;
>  		case 0xc1:
> 



      reply	other threads:[~2016-10-20 17:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-19 15:20 [PATCH] exfat: Read the contiguous flag from the correct extension Carlo Caione
2016-10-20 17:38 ` Andrei Borzenkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c78b2f01-57f1-e469-4ff2-2ae521c539b0@gmail.com \
    --to=arvidjaar@gmail.com \
    --cc=carlo@endlessm.com \
    --cc=grub-devel@gnu.org \
    --cc=linux@endlessm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).