From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1bxHJ1-00068f-3o for mharc-grub-devel@gnu.org; Thu, 20 Oct 2016 13:39:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41813) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bxHIx-000673-RQ for grub-devel@gnu.org; Thu, 20 Oct 2016 13:39:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bxHIs-0000D8-T7 for grub-devel@gnu.org; Thu, 20 Oct 2016 13:38:59 -0400 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]:33368) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bxHIs-0000Ce-H6 for grub-devel@gnu.org; Thu, 20 Oct 2016 13:38:54 -0400 Received: by mail-lf0-x244.google.com with SMTP id l131so1209705lfl.0 for ; Thu, 20 Oct 2016 10:38:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=kgElgaj5U+Fa5o5XbJQuX50JPe2pqEU2xPxDFxfXfN4=; b=dxeWeFInN1JautetDS4YroMy123RQBh7I19C/c5vtXr3/3OU8zW6XGIWwQ7cPECWwS Jd6WThENQoSaPOw6sXWqduENs6yqpm+DA0ByDh6Y2O+aYKZqm/3i2+plnAYHm91cmA2O WWQprXfAq20u+BWV968Ky8sW5ux3qzRKKfB7d6bgTDAq68RFWLel/GIlUgH5bcyrkAts eyyvMoFr20Aagwx8K0r3cXRvfGVimTYXuS9Ox/IMtICvkkT9TXU625X69RNQJ55RTsaF 5duZpJgdmitGlukE/Px6JPIY7TKRvm3M1Df+6/Wei/4xk5xJnbZXrlJxbVOy/DT194Wq Hqcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=kgElgaj5U+Fa5o5XbJQuX50JPe2pqEU2xPxDFxfXfN4=; b=BvynmB5KId5SEl+F9W/uDW55TFkp30KjGEzT9/uZ33/bnlD+eL34klsVxsBhMn0ufA fONkC5r2MiKorXXkesyyPSAtEwhmu9pjc9QAFXey8o9g49P7vQaZ7ebo+QlnchpTEG+o GB0+u4j9vjmZKiinuxJxkGq3HLqh1sDBCFh+DUzAkOMNjxhCBjCJgC1V0w37KXTW5bM5 zqfyf9Y476shpzgDI5CWASNpOs1oShU5TWu7F5tgkLrQjJeNbEakmo8h59X1Oxosx+ZX +tfPIKAHF9jiLIf4xa8x7b7O0098PXBu9/dcgEKQL0G3Y53FB44qbXgvPnLfp6uA+Llo rcSw== X-Gm-Message-State: AA6/9Rnowu045BVD1qgKCZPHZfR9/UwTeJo8ZKYmrj0m9lcumqSmoiJreh+nv4/As+JPGA== X-Received: by 10.25.89.139 with SMTP id n133mr3251674lfb.158.1476985132766; Thu, 20 Oct 2016 10:38:52 -0700 (PDT) Received: from [192.168.1.44] (ppp109-252-90-102.pppoe.spdop.ru. [109.252.90.102]) by smtp.gmail.com with ESMTPSA id t84sm8819552lff.27.2016.10.20.10.38.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Oct 2016 10:38:52 -0700 (PDT) Subject: Re: [PATCH] exfat: Read the contiguous flag from the correct extension To: The development of GNU GRUB , linux@endlessm.com References: <1476890402-12496-1-git-send-email-carlo@caione.org> Cc: Carlo Caione From: Andrei Borzenkov Message-ID: Date: Thu, 20 Oct 2016 20:38:51 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1476890402-12496-1-git-send-email-carlo@caione.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::244 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2016 17:39:01 -0000 19.10.2016 18:20, Carlo Caione пишет: > From: Carlo Caione > > dir.is_contiguous flag is being set reading into the wrong struct. > This is causing a fragmented file not to be readable from an exfat > partition since the NoFatChain bit is wrong. Fix this. > > Signed-off-by: Carlo Caione > --- > grub-core/fs/fat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/grub-core/fs/fat.c b/grub-core/fs/fat.c > index d5212c2..dd8850a 100644 > --- a/grub-core/fs/fat.c > +++ b/grub-core/fs/fat.c > @@ -684,7 +684,7 @@ grub_fat_iterate_dir_next (grub_disk_t disk, struct grub_fat_data *data, > ctxt->dir.file_size > = grub_cpu_to_le64 (sec.type_specific.stream_extension.file_size); > ctxt->dir.have_stream = 1; > - ctxt->dir.is_contiguous = !!(dir.type_specific.stream_extension.flags > + ctxt->dir.is_contiguous = !!(sec.type_specific.stream_extension.flags This is fixed almost a year ago. Please always check current git whether problem still exists. Thank you. > & grub_cpu_to_le16_compile_time (FLAG_CONTIGUOUS)); > break; > case 0xc1: >