* [PATCH] exfat: Read the contiguous flag from the correct extension
@ 2016-10-19 15:20 Carlo Caione
2016-10-20 17:38 ` Andrei Borzenkov
0 siblings, 1 reply; 2+ messages in thread
From: Carlo Caione @ 2016-10-19 15:20 UTC (permalink / raw)
To: grub-devel, linux; +Cc: Carlo Caione
From: Carlo Caione <carlo@endlessm.com>
dir.is_contiguous flag is being set reading into the wrong struct.
This is causing a fragmented file not to be readable from an exfat
partition since the NoFatChain bit is wrong. Fix this.
Signed-off-by: Carlo Caione <carlo@endlessm.com>
---
grub-core/fs/fat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/grub-core/fs/fat.c b/grub-core/fs/fat.c
index d5212c2..dd8850a 100644
--- a/grub-core/fs/fat.c
+++ b/grub-core/fs/fat.c
@@ -684,7 +684,7 @@ grub_fat_iterate_dir_next (grub_disk_t disk, struct grub_fat_data *data,
ctxt->dir.file_size
= grub_cpu_to_le64 (sec.type_specific.stream_extension.file_size);
ctxt->dir.have_stream = 1;
- ctxt->dir.is_contiguous = !!(dir.type_specific.stream_extension.flags
+ ctxt->dir.is_contiguous = !!(sec.type_specific.stream_extension.flags
& grub_cpu_to_le16_compile_time (FLAG_CONTIGUOUS));
break;
case 0xc1:
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] exfat: Read the contiguous flag from the correct extension
2016-10-19 15:20 [PATCH] exfat: Read the contiguous flag from the correct extension Carlo Caione
@ 2016-10-20 17:38 ` Andrei Borzenkov
0 siblings, 0 replies; 2+ messages in thread
From: Andrei Borzenkov @ 2016-10-20 17:38 UTC (permalink / raw)
To: The development of GNU GRUB, linux; +Cc: Carlo Caione
19.10.2016 18:20, Carlo Caione пишет:
> From: Carlo Caione <carlo@endlessm.com>
>
> dir.is_contiguous flag is being set reading into the wrong struct.
> This is causing a fragmented file not to be readable from an exfat
> partition since the NoFatChain bit is wrong. Fix this.
>
> Signed-off-by: Carlo Caione <carlo@endlessm.com>
> ---
> grub-core/fs/fat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/grub-core/fs/fat.c b/grub-core/fs/fat.c
> index d5212c2..dd8850a 100644
> --- a/grub-core/fs/fat.c
> +++ b/grub-core/fs/fat.c
> @@ -684,7 +684,7 @@ grub_fat_iterate_dir_next (grub_disk_t disk, struct grub_fat_data *data,
> ctxt->dir.file_size
> = grub_cpu_to_le64 (sec.type_specific.stream_extension.file_size);
> ctxt->dir.have_stream = 1;
> - ctxt->dir.is_contiguous = !!(dir.type_specific.stream_extension.flags
> + ctxt->dir.is_contiguous = !!(sec.type_specific.stream_extension.flags
This is fixed almost a year ago. Please always check current git whether
problem still exists. Thank you.
> & grub_cpu_to_le16_compile_time (FLAG_CONTIGUOUS));
> break;
> case 0xc1:
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-20 17:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-19 15:20 [PATCH] exfat: Read the contiguous flag from the correct extension Carlo Caione
2016-10-20 17:38 ` Andrei Borzenkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).