From: Glenn Washburn <development@efficientek.com>
To: grub-devel@gnu.org
Cc: Daniel Kiper <dkiper@net-space.pl>,
Leo Sandoval <lsandova@redhat.com>,
Andrew Hamilton <adhamilt@gmail.com>,
Glenn Washburn <development@efficientek.com>
Subject: [PATCH v3 0/4] EROFS test fixes and improvements
Date: Wed, 12 Nov 2025 21:10:38 -0600 [thread overview]
Message-ID: <cover.1763003164.git.development@efficientek.com> (raw)
v3:
* Update patch #1 to include Daniel's suggestions
v2:
* The first patch was from the wrong branch and needed to be modified.
Glenn
Glenn Washburn (4):
tests/erofs_test: Fix mkfs.erofs version test to not use process
substitution bashism
tests/erofs_test: Remove root check
tests/erofs_test: Disable filetime check for erofs_compact
tests/erofs_test: Improve accuracy of FSTIME check
tests/erofs_test.in | 8 --------
tests/util/grub-fs-tester.in | 17 ++++++++++++++---
2 files changed, 14 insertions(+), 11 deletions(-)
Range-diff against v2:
1: eb61a73942f5 ! 1: 1126cf87cc17 tests/erofs_test: Fix mkfs.erofs version test to not use process substitution bashism
@@ tests/util/grub-fs-tester.in: for LOGSECSIZE in $(range "$MINLOGSECSIZE" "$MAXLO
NOFSLABEL=y;;
x"erofs_"*)
- MKFS_EROFS_VERSION=$(mkfs.erofs -V 2>/dev/null | tr ' ' '\n' | grep '^[0-9]')
-- # check if the version is at least 1.6
++ MKFS_EROFS_VERSION=$(mkfs.erofs 2>/dev/null | head -n 1 | (read _ V; echo $V))
+ # check if the version is at least 1.6
- if [ $(sort -V <(echo "$MKFS_EROFS_VERSION") <(echo "1.6") | head -n 1) != "1.6" ]; then
-+ VER=$(mkfs.erofs 2>/dev/null | head -n1 | (read _ V; echo $V))
-+ if [ "$(echo -e "${VER}\n1.6" | sort -V | head -n1)" != "1.6" ]; then
++ if [ "$(echo -e "${MKFS_EROFS_VERSION}\n1.6" | sort -V | head -n 1)" != "1.6" ]; then
NOFSLABEL=y
- fi
+ unset FSLABEL
2: a1d8b6d3b6fa = 2: 742e1e6abe49 tests/erofs_test: Remove root check
3: 7883a9f3b23c = 3: afbc5532b661 tests/erofs_test: Disable filetime check for erofs_compact
4: 9b82fc4ed65e = 4: 46dd18499a81 tests/erofs_test: Improve accuracy of FSTIME check
--
2.34.1
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
next reply other threads:[~2025-11-13 3:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 3:10 Glenn Washburn [this message]
2025-11-13 3:10 ` [PATCH v3 1/4] tests/erofs_test: Fix mkfs.erofs version test to not use process substitution bashism Glenn Washburn
2025-11-13 19:23 ` Daniel Kiper
2025-11-13 3:10 ` [PATCH v3 2/4] tests/erofs_test: Remove root check Glenn Washburn
2025-11-13 3:10 ` [PATCH v3 3/4] tests/erofs_test: Disable filetime check for erofs_compact Glenn Washburn
2025-11-13 3:10 ` [PATCH v3 4/4] tests/erofs_test: Improve accuracy of FSTIME check Glenn Washburn
2025-11-13 17:03 ` [PATCH v3 0/4] EROFS test fixes and improvements Sudhakar Kuppusamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1763003164.git.development@efficientek.com \
--to=development@efficientek.com \
--cc=adhamilt@gmail.com \
--cc=dkiper@net-space.pl \
--cc=grub-devel@gnu.org \
--cc=lsandova@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox