Re: [PATCH v3 0/4] EROFS test fixes and improvements

Sudhakar Kuppusamy
2025-11-13T17:05:42Z

> On 13 Nov 2025, at 8:40 AM, Glenn Washburn <development@efficientek.com> wrote:
>
> v3:
> * Update patch #1 to include Daniel's suggestions
> v2:
> * The first patch was from the wrong branch and needed to be modified.
>
> Glenn
>
> Glenn Washburn (4):
> tests/erofs_test: Fix mkfs.erofs version test to not use process
> substitution bashism
> tests/erofs_test: Remove root check
> tests/erofs_test: Disable filetime check for erofs_compact
> tests/erofs_test: Improve accuracy of FSTIME check
>
> tests/erofs_test.in | 8 --------
> tests/util/grub-fs-tester.in | 17 ++++++++++++++---
> 2 files changed, 14 insertions(+), 11 deletions(-)
>
> Range-diff against v2:
> 1: eb61a73942f5 ! 1: 1126cf87cc17 tests/erofs_test: Fix mkfs.erofs version test to not use process substitution bashism
> @@ tests/util/grub-fs-tester.in: for LOGSECSIZE in $(range "$MINLOGSECSIZE" "$MAXLO
> NOFSLABEL=y;;
> x"erofs_"*)
> - MKFS_EROFS_VERSION=$(mkfs.erofs -V 2>/dev/null | tr ' ' '\n' | grep '^[0-9]')
> -- # check if the version is at least 1.6
> ++ MKFS_EROFS_VERSION=$(mkfs.erofs 2>/dev/null | head -n 1 | (read _ V; echo $V))
> + # check if the version is at least 1.6
> - if [ $(sort -V <(echo "$MKFS_EROFS_VERSION") <(echo "1.6") | head -n 1) != "1.6" ]; then
> -+ VER=$(mkfs.erofs 2>/dev/null | head -n1 | (read _ V; echo $V))
> -+ if [ "$(echo -e "${VER}\n1.6" | sort -V | head -n1)" != "1.6" ]; then
> ++ if [ "$(echo -e "${MKFS_EROFS_VERSION}\n1.6" | sort -V | head -n 1)" != "1.6" ]; then
> NOFSLABEL=y
> - fi
> + unset FSLABEL
> 2: a1d8b6d3b6fa = 2: 742e1e6abe49 tests/erofs_test: Remove root check
> 3: 7883a9f3b23c = 3: afbc5532b661 tests/erofs_test: Disable filetime check for erofs_compact
> 4: 9b82fc4ed65e = 4: 46dd18499a81 tests/erofs_test: Improve accuracy of FSTIME check
> --
> 2.34.1

Reviewed-by: Sudhakar Kuppusamy <sudhakar@linux.ibm.com>

Thanks,
Sudhakar

>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel