public inbox for grub-devel@gnu.org
 help / color / mirror / Atom feed
From: Glenn Washburn <development@efficientek.com>
To: grub-devel@gnu.org
Cc: Daniel Kiper <dkiper@net-space.pl>,
	Mike Gilbert <floppym@gentoo.org>,
	Glenn Washburn <development@efficientek.com>
Subject: [PATCH v3 0/4]
Date: Wed, 19 Nov 2025 13:49:17 -0600	[thread overview]
Message-ID: <cover.1763581254.git.development@efficientek.com> (raw)

I've seen several times and believe that quite often people building GRUB
forget to run linguas.sh to download and setup the build for the external
translations. So make setting up LINGUAS happen by default when running
bootstrap. If a user does not want to setup LINGUAS it can be skipped by
running bootstrap with the existing --skip-po argument. In fact, bootstrap
already has functionality that automatically downloads a projects translations,
so switch to using that in patch #2. Also it is needed to run some extra code
because bootstrap will not add GRUB's autogenerated languages. In patch #3
simplify the LINGUAS generation and patch #4 fixes a couple issues in the
INSTALL that is dependent on patch #1.

NOTE: Instead of using the non-POSIX -r option to xargs, use a more POSIX
friendly way of ensuring that basename is not run with no arguments.

v3:
 * Fix an issue where basename could be called by xargs with no arguments

v2:
 * There wasn't intentionally a v1, but I accidentally created a patch
   series, and then I realized that patch #2 depends on patch #1.

Glenn

Glenn Washburn (4):
  bootstrap: Run linguas.sh in bootstrap epilogue
  bootstrap: Migrate linguas.sh into bootstrap.conf
  bootstrap: Condense and simplify LINGUAS generation
  INSTALL: Fix a grammatical error

 INSTALL        | 25 +++++++++++--------------
 bootstrap.conf | 21 +++++++++++++++++++--
 2 files changed, 30 insertions(+), 16 deletions(-)

Range-diff against v2:
1:  62f0c3965921 = 1:  20d27aed572a bootstrap: Run linguas.sh in bootstrap epilogue
2:  7ffeeb595903 = 2:  6b6fed0beba3 bootstrap: Migrate linguas.sh into bootstrap.conf
3:  b9bbe64cd8b8 ! 3:  3678bd68c4b6 bootstrap: Condense and simplify LINGUAS generation
    @@ bootstrap.conf: bootstrap_epilogue () {
     -      ) | sort | uniq | xargs
     -    ) >po/LINGUAS
     +    {
    -+      ls po/*.po | xargs -L 100 basename -s .po -a
    ++      # NOTE: xargs has no POSIX compliant way to avoid running the program
    ++      # given as an argument when there are no input lines. So ensure that
    ++      # basename is always run with at least one argument, the empty string,
    ++      # and ignore the first line of output.
    ++      ls po/*.po | xargs -L 100 basename -s .po -a "" | tail -n +2
     +      for x in $autogenerated; do
     +        rm -f "po/$x.po"
     +        echo "$x"
4:  eb88d70454f4 = 4:  c74c01d6fd85 INSTALL: Fix a grammatical error
-- 
2.34.1


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

             reply	other threads:[~2025-11-19 19:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-19 19:49 Glenn Washburn [this message]
2025-11-19 19:49 ` [PATCH v3 1/4] bootstrap: Run linguas.sh in bootstrap epilogue Glenn Washburn
2025-11-19 19:49 ` [PATCH v3 2/4] bootstrap: Migrate linguas.sh into bootstrap.conf Glenn Washburn
2025-11-19 21:34   ` Daniel Kiper
2025-11-20 18:42     ` Glenn Washburn
2025-11-19 19:49 ` [PATCH v3 3/4] bootstrap: Condense and simplify LINGUAS generation Glenn Washburn
2025-11-19 19:49 ` [PATCH v3 4/4] INSTALL: Fix a grammatical error Glenn Washburn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1763581254.git.development@efficientek.com \
    --to=development@efficientek.com \
    --cc=dkiper@net-space.pl \
    --cc=floppym@gentoo.org \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox