Re: [PATCH v8 6/6] ieee1275: support added for multiple nvme bootpaths

[Avnish Chouhan <avnish@linux.ibm.com>]

On 2026-02-26 20:23, grub-devel-request@gnu.org wrote:
> Message: 1
> Date: Thu, 26 Feb 2026 17:50:58 +0300
> From: "Vladimir 'phcoder' Serbinenko" <phcoder@gmail.com>
> To: The development of GNU GRUB <grub-devel@gnu.org>
> Subject: Re: [PATCH v8 6/6] ieee1275: support added for multiple nvme
> 	bootpaths
> Message-ID:
> 	<CAEaD8JPL6G+96ECrUX01AD_dhmC+kStH6oYMOg-zd6Lckh61DA@mail.gmail.com>
> Content-Type: text/plain; charset="utf-8"
> 
> Regards
> Vladimir 'phcoder' Serbinenko
> 

Hi Vladimir,
Thank you so much a review!

I'll do the changes as suggested in next version!

>>  void
>>  grub_install_register_ieee1275 (int is_prep, const char 
>> *install_device,
>>                                 int partno, const char *relpath)
>> @@ -215,8 +320,19 @@ grub_install_register_ieee1275 (int is_prep, 
>> const
>> char *install_device,
>>         }
>>        *ptr = '\0';
>>      }
>> +  else if (grub_strstr (install_device, "nvme"))
>> +    {
>> +      boot_device = add_multiple_nvme_bootdevices (install_device);
>> 
> What happens if I install via an UUID symlink? What happens if I 
> install on
> a file (disk image) named nvme1?

Regarding the above query. Unless we have a valid NVMe/NVMeOF info in 
"/device" and "/subsystem", the function would not have any impact on 
bootpaths.

Regards,
Avnish Chouhan

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel