From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1cvRJG-0002wf-IZ for mharc-grub-devel@gnu.org; Tue, 04 Apr 2017 12:27:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvRJE-0002wW-QK for grub-devel@gnu.org; Tue, 04 Apr 2017 12:27:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cvRJB-0005PO-Nt for grub-devel@gnu.org; Tue, 04 Apr 2017 12:27:56 -0400 Received: from mail-lf0-x241.google.com ([2a00:1450:4010:c07::241]:32936) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cvRJB-0005Om-GW for grub-devel@gnu.org; Tue, 04 Apr 2017 12:27:53 -0400 Received: by mail-lf0-x241.google.com with SMTP id r36so15984913lfi.0 for ; Tue, 04 Apr 2017 09:27:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=WFbh6FGpY41B1h47JpM2/w8YVc6GXJAByMZTCpwHo7U=; b=eeoP+2oYvog/YLL1NjvGVLGtIVQFMHiaqQYCyzbhjhBbpDfu8ZZLpmYDQ9926N7Gfr 1CmlmfpmAesblsV1El0xFOFMlmfE+X6vLdfO8cV/8CzxLgs+UVn9omyWp3ldtVwA8703 eIn/W+f5GFnK47+x3HQEtp9vg7QO5JU08TShwnhzsEGqUGmHbpATWrqjWloWLCEz0Hvn uAGvwoUP1pclyDu4whYwv1+tVBzRqMqIqQU9yzm77xbZhPS/A9sT4fdqJz7yVuOAfc5t xCV79HJE4LGMG8TXf18oomOM42MN1NHSTB1FAtOnlI4GBz8GzBSa0dM3UNCD0sr+rGcU ZGVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=WFbh6FGpY41B1h47JpM2/w8YVc6GXJAByMZTCpwHo7U=; b=MQ6+B2++ntWWIW52dH5jW7ym3rxoQOm3itKJlj4RMrb9ozj/G7ukhwmVsMIp5g8s9H pRi8BKtxPaB/iVRvIltHkWbIIS8NJVlFC4x9qYy1fScxLc1OS9xUfVchf9u5HDboGbuQ yde4xEqODWGiFk6FNxz9oTY4w2SSMXY/KJhESRo5k1DRmJnel1NW3Y5gfUb+0SBxD55w SmatJmWWiiVE11reJCHbSwFC9Y53x6c1nGxaWc5q5LjOx7vGdaURKVPJQ0fxp7uzSmrM zzDbDYeIyF96lwimC1emDyik3fX/dah58rbEIv1Z7j37QRcfWJqA2ZInlpHQElNsHWBp cSiA== X-Gm-Message-State: AFeK/H2vt5hzxeUVcE9WnRprjRDi70ZDM7Tdi2EYehDL/RrnX/tXlVG0sDA9qo0X+Li+tQ== X-Received: by 10.25.201.74 with SMTP id z71mr7740091lff.108.1491323271514; Tue, 04 Apr 2017 09:27:51 -0700 (PDT) Received: from [192.168.1.6] (ppp109-252-90-38.pppoe.spdop.ru. [109.252.90.38]) by smtp.gmail.com with ESMTPSA id v30sm3192468ljd.65.2017.04.04.09.27.50 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Apr 2017 09:27:50 -0700 (PDT) Subject: Re: [PATCH] btrfs: avoid "used uninitialized" error with GCC7 To: grub-devel@gnu.org References: <1490978526-13303-1-git-send-email-arvidjaar@gmail.com> From: Andrei Borzenkov Message-ID: Date: Tue, 4 Apr 2017 19:27:49 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::241 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2017 16:27:57 -0000 03.04.2017 11:59, Vladimir 'phcoder' Serbinenko пишет: > On Fri, Mar 31, 2017, 06:43 Andrei Borzenkov wrote: > >> sblock was local and so considered new variable on every loop >> iteration. >> >> While on it, dynamically allocate buffer to reduce stack usage. >> > Looks good. Did you check all instances sizeof, so we don't have sizeof of > pointer? > Did you check return paths for free'ing on all of them? > There is one common return path, but I committed light version that just moves variable out of loop; will commit full version after release.