CLD doesn't build on db-4.3

CLD doesn't build on db-4.3

[Samba - BoYang]

hi, *
    CLD doesn't build on db-4.3 on suse 11, since db-4.3 uses deprecated
structure members DBC->c_xxx(c_close(), etc) instead of DBC->xxx. :-)

    It won't build on db-4.4, either. probably won't build on db-4.5, as
db-5.0 says DBC->xxx was introduced in db-4.6. :-) Should we disable
support for 4.3 - 4.5 and add 4.9 - 5.0?
-- 
Samba Team	boyang@samba.org	http://www.samba.org

Re: CLD doesn't build on db-4.3

[Pete Zaitcev]

On Thu, 01 Apr 2010 19:01:59 +0800
Samba - BoYang <boyang@samba.org> wrote:

>     CLD doesn't build on db-4.3 on suse 11, since db-4.3 uses deprecated
> structure members DBC->c_xxx(c_close(), etc) instead of DBC->xxx. :-)

That's unexpected. Jeff is our portability expert, but he's busy
with the baby, so I guess I'll have to look if it's something
easily fixable.

-- Pete

Re: CLD doesn't build on db-4.3

[Jeff Garzik]

On 04/01/2010 07:01 AM, Samba - BoYang wrote:
> hi, *
>      CLD doesn't build on db-4.3 on suse 11, since db-4.3 uses deprecated
> structure members DBC->c_xxx(c_close(), etc) instead of DBC->xxx. :-)
>
>      It won't build on db-4.4, either. probably won't build on db-4.5, as
> db-5.0 says DBC->xxx was introduced in db-4.6. :-) Should we disable
> support for 4.3 - 4.5 and add 4.9 - 5.0?

I'd answer "yes", by a circuitous route:  if I understand things 
correctly, the replicated PAXOS db4 backend that we are heading towards 
(see the 'replica' branch of 
git://git.kernel.org/pub/scm/daemon/cld/cld.git) was buggy in early db4 
releases.

Therefore, it sounds like we could eliminate two issues with a single 
change, by removing support for db 4.3 - 4.5, the DBC issue and the 
PAXOS issue.

I'm fine with adding support for 4.9+ as long as the APIs function in a 
compatible manner.

Want to create the simple patch for this?  :)

Thanks,

	Jeff

Re: CLD doesn't build on db-4.3

[Pete Zaitcev]

On Thu, 01 Apr 2010 11:03:48 -0400
Jeff Garzik <jeff@garzik.org> wrote:

> >      It won't build on db-4.4, either. probably won't build on db-4.5, as
> > db-5.0 says DBC->xxx was introduced in db-4.6. :-) Should we disable
> > support for 4.3 - 4.5 and add 4.9 - 5.0?
> 
> I'd answer "yes", by a circuitous route:  if I understand things 
> correctly, the replicated PAXOS db4 backend that we are heading towards 
> (see the 'replica' branch of 
> git://git.kernel.org/pub/scm/daemon/cld/cld.git) was buggy in early db4 
> releases.

> Therefore, it sounds like we could eliminate two issues with a single 
> change, by removing support for db 4.3 - 4.5, the DBC issue and the 
> PAXOS issue.

RHEL 5 ships with db4-4.3.29-10.el5 (I checked for Bo's problem
this morning), so dropping 4.3 will make RHEL 5 unsupportable.
Just a point to consider.

-- Pete

Re: CLD doesn't build on db-4.3

[Samba - BoYang]

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

On 04/01/2010 11:03 PM, Jeff Garzik wrote:

> I'm fine with adding support for 4.9+ as long as the APIs function in a
> compatible manner.
> 
> Want to create the simple patch for this?  :)

Here is the patch for master, please review it. Thanks!

> 
> Thanks,
> 
>     Jeff
> 
> 
> 
> 
> 
> 


-- 
Samba Team	boyang@samba.org	http://www.samba.org

[-- Attachment #2: disbale-db-4.3-4.5-mbox.diff --]
[-- Type: text/x-patch, Size: 1296 bytes --]

From 94472c2e304a9a94197e8d593ad3987cdbe4e383 Mon Sep 17 00:00:00 2001
From: Bo Yang <boyang@samba.org>
Date: Fri, 2 Apr 2010 08:30:39 +0800
Subject: [PATCH] Disable db4.3 - 4.5 for incompatible APIs.

Signed-off-by: Bo Yang <boyang@samba.org>
---
 configure.ac |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/configure.ac b/configure.ac
index 38688f1..4dcf9e3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -74,13 +74,12 @@ dnl AC_TYPE_PID_T
 dnl -----------------------------
 dnl Checks for required libraries
 dnl -----------------------------
-AC_CHECK_LIB(db-4.8, db_create, DB4_LIBS=-ldb-4.8,
+AC_CHECK_LIB(db-5.0, db_create, DB4_LIBS=-ldb-5.0,
+	AC_CHECK_LIB(db-4.9, db_create, DB4_LIBS=-ldb-4.9,
+	AC_CHECK_LIB(db-4.8, db_create, DB4_LIBS=-ldb-4.8,
 	AC_CHECK_LIB(db-4.7, db_create, DB4_LIBS=-ldb-4.7,
 	AC_CHECK_LIB(db-4.6, db_create, DB4_LIBS=-ldb-4.6,
-	AC_CHECK_LIB(db-4.5, db_create, DB4_LIBS=-ldb-4.5,
-	AC_CHECK_LIB(db-4.4, db_create, DB4_LIBS=-ldb-4.4,
-	AC_CHECK_LIB(db-4.3, db_create, DB4_LIBS=-ldb-4.3,
-  [AC_MSG_ERROR([Missing required libdb 4.x])]))))))
+  [AC_MSG_ERROR([Missing required libdb 4.6+])])))))
 AC_CHECK_LIB(crypto, MD5_Init, CRYPTO_LIBS=-lcrypto)
 AC_SEARCH_LIBS(argp_parse, argp)
 AC_SEARCH_LIBS(recv, socket)
-- 
1.6.0.2

Re: CLD doesn't build on db-4.3

[Samba - BoYang]

On 04/02/2010 04:50 AM, Pete Zaitcev wrote:

> RHEL 5 ships with db4-4.3.29-10.el5 (I checked for Bo's problem
> this morning), so dropping 4.3 will make RHEL 5 unsupportable.
> Just a point to consider.

It might add a lot of #ifdef to the code to support 4.5-. :-)

> 
> -- Pete
> 


-- 
Samba Team	boyang@samba.org	http://www.samba.org

Re: CLD doesn't build on db-4.3

[Jeff Garzik]

On 04/01/2010 08:35 PM, Samba - BoYang wrote:
> On 04/01/2010 11:03 PM, Jeff Garzik wrote:
>
>> I'm fine with adding support for 4.9+ as long as the APIs function in a
>> compatible manner.
>>
>> Want to create the simple patch for this?  :)
>
> Here is the patch for master, please review it. Thanks!

Just to be safe, I want to see precisely how OpenSolaris, FreeBSD and 
RHEL behave before dropping the older support.

I went ahead and committed the addition for 4.9 and 5.0, though, 
crediting you with a "Suggested-by" in the commit text.

	Jeff

Re: CLD doesn't build on db-4.3

[Pete Zaitcev]

On Wed, 14 Apr 2010 00:32:56 -0400
Jeff Garzik <jeff@garzik.org> wrote:

> Just to be safe, I want to see precisely how OpenSolaris, FreeBSD and 
> RHEL behave before dropping the older support.

I resolved to building an RPM with 4.9 for RHEL 5. That would
probably the best if I make it non-conflicting with the stock 4.3.
Same RPM could probably be used on SuSE. But I haven't done it yet.

-- Pete

Here is small patch to enable link against higher-version db for nfs4d and tabled. :-)

[Samba - BoYang]

[-- Attachment #1: Type: text/plain, Size: 91 bytes --]

Please review them, thanks!

Bo Yang

-- 
Samba Team	boyang@samba.org	http://www.samba.org

[-- Attachment #2: nfs4d-enable-build-on-4.9-mbox.diff --]
[-- Type: text/x-patch, Size: 1370 bytes --]

From ac6d3f7cb7caa3dca498096bd0c07e6b02601239 Mon Sep 17 00:00:00 2001
From: Bo Yang <boyang@samba.org>
Date: Fri, 2 Apr 2010 18:35:12 +0800
Subject: [PATCH] Enable build on db-4.9+.

Signed-off-by: Bo Yang <boyang@samba.org>
---
 configure.ac |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index 7e8cbc7..3b63cf1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -43,12 +43,15 @@ dnl -----------------------------
 dnl Checks for required libraries
 dnl -----------------------------
 dnl AC_CHECK_LIB(gssrpc, gssrpc_svc_register, GSSRPC_LIBS=-lgssrpc, exit 1)
-AC_CHECK_LIB(db-4.7, db_create, DB4_LIBS=-ldb-4.7,
+AC_CHECK_LIB(db-5.0, db_create, DB4_LIBS=-ldb-5.0,
+	AC_CHECK_LIB(db-4.9, db_create, DB4_LIBS=-ldb-4.9,
+	AC_CHECK_LIB(db-4.8, db_create, DB4_LIBS=-ldb-4.8,
+	AC_CHECK_LIB(db-4.7, db_create, DB4_LIBS=-ldb-4.7,
 	AC_CHECK_LIB(db-4.6, db_create, DB4_LIBS=-ldb-4.6,
 	AC_CHECK_LIB(db-4.5, db_create, DB4_LIBS=-ldb-4.5,
 	AC_CHECK_LIB(db-4.4, db_create, DB4_LIBS=-ldb-4.4,
 	AC_CHECK_LIB(db-4.3, db_create, DB4_LIBS=-ldb-4.3,
-	[AC_MSG_ERROR([Missing required libdb 4.x])])))))
+	[AC_MSG_ERROR([Missing required libdb 4.x])]))))))))
 AC_CHECK_LIB(event, event_base_new, EVENT_LIBS=-levent,
   [AC_MSG_ERROR([Missing required libevent])])
 AC_CHECK_LIB(argp, argp_parse, ARGP_LIBS=-largp)
-- 
1.6.0.2


[-- Attachment #3: tabled-enable-build-on-4.8-mbox.diff --]
[-- Type: text/x-patch, Size: 1356 bytes --]

From f690daf3648f47a8a7ac317613fff81e24ce6bca Mon Sep 17 00:00:00 2001
From: Bo Yang <boyang@samba.org>
Date: Fri, 2 Apr 2010 18:38:08 +0800
Subject: [PATCH] Enable build on 4.8+.

Signed-off-by: Bo Yang <boyang@samba.org>
---
 configure.ac |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index c6baa15..9095c67 100644
--- a/configure.ac
+++ b/configure.ac
@@ -76,13 +76,15 @@ dnl -----------------------------
 AC_CHECK_LIB(pcre, pcre_compile, PCRE_LIBS=-lpcre)
 AC_CHECK_LIB(crypto, MD5_Init, CRYPTO_LIBS=-lcrypto)
 AC_CHECK_LIB(ssl, SSL_new, SSL_LIBS=-lssl)
-AC_CHECK_LIB(db-4.8, db_create, DB4_LIBS=-ldb-4.8,
+AC_CHECK_LIB(db-5.0, db_create, DB4_LIBS=-ldb-5.0,
+	AC_CHECK_LIB(db-4.9, db_create, DB4_LIBS=-ldb-4.9,
+	AC_CHECK_LIB(db-4.8, db_create, DB4_LIBS=-ldb-4.8,
 	AC_CHECK_LIB(db-4.7, db_create, DB4_LIBS=-ldb-4.7,
 	AC_CHECK_LIB(db-4.6, db_create, DB4_LIBS=-ldb-4.6,
 	AC_CHECK_LIB(db-4.5, db_create, DB4_LIBS=-ldb-4.5,
 	AC_CHECK_LIB(db-4.4, db_create, DB4_LIBS=-ldb-4.4,
 	AC_CHECK_LIB(db-4.3, db_create, DB4_LIBS=-ldb-4.3,
-  [AC_MSG_ERROR([Missing required libdb 4.x])]))))))
+  [AC_MSG_ERROR([Missing required libdb 4.x])]))))))))
 AC_CHECK_LIB(event, event_base_new, EVENT_LIBS=-levent,
   [AC_MSG_ERROR([Missing required libevent])])
 AC_SEARCH_LIBS(argp_parse, argp)
-- 
1.6.0.2

Re: Here is small patch to enable link against higher-version db for nfs4d and tabled. :-)

[Jeff Garzik]

On 04/14/2010 06:44 AM, Samba - BoYang wrote:
> Please review them, thanks!

Applied to nfs4d and tabled, thanks!

In the future, it would be appreciated to see separate emails, one email 
per patch.

Best regards,

	Jeff

Re: Here is small patch to enable link against higher-version db for nfs4d and tabled. :-)

[Samba - BoYang]

On 04/14/2010 09:40 PM, Jeff Garzik wrote:
> would be appreciated to see separate emails, o

Yah, I see. :-)


-- 
Samba Team	boyang@samba.org	http://www.samba.org