public inbox for hail-devel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pete Zaitcev <zaitcev@redhat.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Project Hail List <hail-devel@vger.kernel.org>
Subject: [Patch 6/7] tabled: unsigned < 0
Date: Thu, 1 Apr 2010 19:51:50 -0600	[thread overview]
Message-ID: <20100401195150.58fda28d@redhat.com> (raw)

Enums and sizeofs are unsigned. V. annoying because of int i;.

Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>

---
 server/status.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -urp -X dontdiff tabled-m/server/status.c tabled-tip/server/status.c
--- tabled-m/server/status.c	2010-04-01 19:13:05.000000000 -0600
+++ tabled-tip/server/status.c	2010-04-01 17:55:46.000000000 -0600
@@ -74,7 +74,7 @@ static bool stat_err(struct client *cli,
 	 * We do not use all codes that the main server can return,
 	 * so our array is smaller and it has gaps. Must check, in case.
 	 */
-	if (code < 0 || code >= ARRAY_SIZE(err_info) || !err_info[code].code) {
+	if (code >= ARRAY_SIZE(err_info) || !err_info[code].code) {
 		applog(LOG_INFO, "client %s status error %d",
 		       cli->addr_host, code);
 		code = InternalError;

                 reply	other threads:[~2010-04-02  1:51 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100401195150.58fda28d@redhat.com \
    --to=zaitcev@redhat.com \
    --cc=hail-devel@vger.kernel.org \
    --cc=jeff@garzik.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox