From: Jeff Garzik <jeff@garzik.org>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Project Hail List <hail-devel@vger.kernel.org>,
Jim Meyering <jim@meyering.net>
Subject: Re: [hail patch 1/1] Fix calling convention of huri_field_escape
Date: Mon, 27 Sep 2010 22:47:05 -0400 [thread overview]
Message-ID: <4CA15729.60203@garzik.org> (raw)
In-Reply-To: <20100927184918.7fec30ac@lembas.zaitcev.lan>
On 09/27/2010 08:49 PM, Pete Zaitcev wrote:
> Premature optimization is the root of all evil.
>
> Use a sensible convention of not screwing with the argument, at the expense
> of extra strdup.
>
> Fortunately, all users are confined to Hail itself, even if huri_field_escape
> is exported.
>
> Signed-off-by: Pete Zaitcev<zaitcev@redhat.com>
>
> ---
> include/hstor.h | 2 +-
> lib/hstor.c | 44 +++++++++++++++++++++++++++++---------------
> lib/huri.c | 10 +++++-----
> 3 files changed, 35 insertions(+), 21 deletions(-)
applied
prev parent reply other threads:[~2010-09-28 2:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 0:49 [hail patch 1/1] Fix calling convention of huri_field_escape Pete Zaitcev
2010-09-28 2:47 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA15729.60203@garzik.org \
--to=jeff@garzik.org \
--cc=hail-devel@vger.kernel.org \
--cc=jim@meyering.net \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox