From: Jeff Garzik <jeff@garzik.org>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Project Hail List <hail-devel@vger.kernel.org>
Subject: Re: [patch hail] remove duplicated stc_readport
Date: Tue, 26 Oct 2010 17:33:13 -0400 [thread overview]
Message-ID: <4CC74919.4030307@garzik.org> (raw)
In-Reply-To: <20101026134708.1bb36aca@lembas.zaitcev.lan>
On 10/26/2010 03:47 PM, Pete Zaitcev wrote:
> Now that we have a common library for Hail, an opportunity opens to trim
> some duplication, such as stc_readport. It even had a comment about it.
>
> Note that we leave cld_readport in the API for a few weeks, while I get
> my tabled trees and RPMs in order. Unfortunately we routinely neglect
> to set specific version in RPM headers (e.g. no Requires: cld>= 0.8.2).
>
> Also, get rid of g_file_get_contents. Talk about pointless: it requires
> caller to free memory, and it's not like code is any more compact or
> easier to understand.
>
> Signed-off-by: Pete Zaitcev<zaitcev@redhat.com>
applied
it would be nice if a follow-up patch moved the hail_readport()
definition into a more generic, not-CLD-specific header such as
include/hail.h[1]
Jeff
[1] which doesn't exist yet. maybe we could rename hail_log.h to
hail.h, and make hail.h a dumping ground for hail-generic items.
next prev parent reply other threads:[~2010-10-26 21:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 19:47 [patch hail] remove duplicated stc_readport Pete Zaitcev
2010-10-26 21:33 ` Jeff Garzik [this message]
2010-10-26 22:23 ` Pete Zaitcev
2010-10-26 22:28 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC74919.4030307@garzik.org \
--to=jeff@garzik.org \
--cc=hail-devel@vger.kernel.org \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox