From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [patch hail] remove duplicated stc_readport Date: Tue, 26 Oct 2010 18:28:14 -0400 Message-ID: <4CC755FE.7010604@garzik.org> References: <20101026134708.1bb36aca@lembas.zaitcev.lan> <4CC74919.4030307@garzik.org> <20101026162322.605f5cc7@lembas.zaitcev.lan> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=wYkpiFFhbsciMrJveYJJ7jQg3CYAM4DsbE4E74/4ZEw=; b=RbWz6wNmcS7JoMuSlToNHk1vLemnNExAi8x4JbcN9RUg5pYQOx7tCsudDVcV+BHZi/ BFf+3WB4Pytw0kgdqTjkpGNcuGP6TxlIdlrdQdreqdnDrrW1x/O3IjQtwVX02btv0xGH iRAqbEcaKqs78EwB3xjSs4XI+SA32EvWQM3GA= In-Reply-To: <20101026162322.605f5cc7@lembas.zaitcev.lan> Sender: hail-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Pete Zaitcev Cc: Project Hail List On 10/26/2010 06:23 PM, Pete Zaitcev wrote: > On Tue, 26 Oct 2010 17:33:13 -0400 > Jeff Garzik wrote: > >> it would be nice if a follow-up patch moved the hail_readport() >> definition into a more generic, not-CLD-specific header such as >> include/hail.h[1] > >> [1] which doesn't exist yet. maybe we could rename hail_log.h to >> hail.h, and make hail.h a dumping ground for hail-generic items. > > Maybe. It sounds like a good idea. But it's also a slippery slope. > I would rather have you look at it, when you have a moment. > > Also, how do I post a patch that renames a file? Just ask "git show" > and send whatever comes out? A patch that deletes a file and adds the file under a name is detected by git as a rename. Or you can post a 'git pull' request. Jeff