From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linutronix.de (193.142.43.55:993) by crypto-ml.lab.linutronix.de with IMAP4-SSL for ; 20 Feb 2020 15:06:01 -0000 Received: from mail.kernel.org ([198.145.29.99]) by Galois.linutronix.de with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1j4nOp-0001I4-LR for speck@linutronix.de; Thu, 20 Feb 2020 16:06:00 +0100 Date: Thu, 20 Feb 2020 16:05:49 +0100 From: Greg KH Subject: [MODERATED] Re: [PATCH 0/2] more sampling fun 0 Message-ID: <20200220150549.GA3437955@kroah.com> References: <20200220081420.GA3328448@kroah.com> <20200220145510.GE160988@tassilo.jf.intel.com> MIME-Version: 1.0 In-Reply-To: <20200220145510.GE160988@tassilo.jf.intel.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit To: speck@linutronix.de List-ID: On Thu, Feb 20, 2020 at 06:55:10AM -0800, speck for Andi Kleen wrote: > > Then we need to stop using RDRAND internally for our "give me a random > > number api" which has spread to more and more parts of the kernel. > > Only if that API is called frequently enough. AFAIK it is not. It's called by all sorts of places in the kernel today. > Normally it's used for rare rekeying of hash tables etc., which > doesn't happen very often. "normally" :) > > Here's a patch that does so: > > https://lore.kernel.org/lkml/20200216161836.1976-1-Jason@zx2c4.com/ > > which I'm going to advise get merged now and backported to the stable > > branches. > > Don't see any reason at this point. Only do it if there's an actual > indication of a problem. It's slow, why wouldn't we stop using it as we already have a much faster call. thanks, greg k-h