From: Nicolai Stange <nstange@suse.de>
To: speck@linutronix.de
Subject: [MODERATED] Re: [RFC PATCH 4/6] kvm: handle host mode irqs 4
Date: Tue, 24 Jul 2018 07:58:06 +0200 [thread overview]
Message-ID: <87sh49xjip.fsf_-_@suse.de> (raw)
In-Reply-To: <20180723154021.GE35943@tassilo.jf.intel.com> (speck for Andi Kleen's message of "Mon, 23 Jul 2018 08:40:21 -0700")
speck for Andi Kleen <speck@linutronix.de> writes:
>> +.macro TRACK_KERNEL_MODE_IRQ
>> +#ifdef CONFIG_X86_TRACK_KERNEL_MODE_IRQS
>> + /*
>> + * Increment the kernel mode irq generation count even if
>> + * coming from userspace -- nobody will care.
>> + */
>> + incl PER_CPU_VAR(kernel_mode_irq_gen)
>> +#endif
>> +.endm
>
> You can put it into irq_enter/exit, no need to mess with assembler code.
The reason I put it there was to avoid touching anything outside of
arch/x86.
In addition,
- uv_bau_message_interrupt() doesn't call irq_enter() at all,
- smp_reschedule_interrupt() calls it conditionally
But I'm not sure it matters much and either way is fine by me.
Thanks,
Nicolai
--
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton,
HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2018-07-24 5:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-23 9:54 [MODERATED] [RFC PATCH 0/6] kvm: handle host mode irqs 0 Nicolai Stange
2018-07-21 20:16 ` [MODERATED] [RFC PATCH 1/6] kvm: handle host mode irqs 1 Nicolai Stange
2018-07-21 20:25 ` [MODERATED] [RFC PATCH 2/6] kvm: handle host mode irqs 2 Nicolai Stange
2018-07-21 20:35 ` [MODERATED] [RFC PATCH 3/6] kvm: handle host mode irqs 3 Nicolai Stange
2018-07-22 9:35 ` [MODERATED] [RFC PATCH 4/6] kvm: handle host mode irqs 4 Nicolai Stange
2018-07-23 15:40 ` [MODERATED] " Andi Kleen
2018-07-24 5:58 ` Nicolai Stange [this message]
2018-07-24 14:12 ` Andi Kleen
2018-07-24 14:39 ` Paolo Bonzini
2018-07-24 15:21 ` Peter Zijlstra
2018-07-25 11:45 ` Nicolai Stange
2018-07-27 7:45 ` Peter Zijlstra
2018-07-27 9:17 ` Nicolai Stange
2018-07-27 9:55 ` Paolo Bonzini
2018-07-29 20:00 ` Nicolai Stange
2018-07-22 11:06 ` [MODERATED] [RFC PATCH 5/6] kvm: handle host mode irqs 5 Nicolai Stange
2018-07-22 11:38 ` [MODERATED] [RFC PATCH 6/6] kvm: handle host mode irqs 6 Nicolai Stange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh49xjip.fsf_-_@suse.de \
--to=nstange@suse.de \
--cc=speck@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox