From: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
To: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
<igt-dev@lists.freedesktop.org>,
Alan Previn <alan.previn.teres.alexis@intel.com>
Subject: Re: [PATCH i-g-t 2/3] tests/intel/xe_create: Stop treating the extension field as MBZ
Date: Fri, 31 Jan 2025 09:09:43 -0800 [thread overview]
Message-ID: <008c9383-5022-4f5e-8a85-022100d15242@intel.com> (raw)
In-Reply-To: <20250131125928.ivnojwqamlsvem6s@kamilkon-desk.igk.intel.com>
On 1/31/2025 4:59 AM, Kamil Konieczny wrote:
> Hi Daniele,
> On 2025-01-30 at 14:14:56 -0800, Daniele Ceraolo Spurio wrote:
>> A new extension for the xe_create ioctl will be added to support PXP [1],
>> so in preparation for that to be merged stop expecting the field to always
>> be zero.
>>
>> [1] https://patchwork.freedesktop.org/patch/634550/
> Please add also lore.kernel.org link (could be done at merge)
> here and in next patch, Thanks!
Should I just replace this link instead of adding a new one?
Thanks,
Daniele
>
> Regards,
> Kamil
>
>> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>> Reviewed-by: Alan Previn <alan.previn.teres.alexis@intel.com>
>> ---
>> tests/intel/xe_create.c | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/tests/intel/xe_create.c b/tests/intel/xe_create.c
>> index e3be6b774..e3ebb9fd4 100644
>> --- a/tests/intel/xe_create.c
>> +++ b/tests/intel/xe_create.c
>> @@ -243,11 +243,6 @@ static void create_invalid_mbz(int fd)
>> gem_close(fd, create.handle);
>> create.handle = 0;
>>
>> - /* No supported extensions yet */
>> - create.extensions = -1;
>> - igt_assert_eq(__ioctl_create(fd, &create), -EINVAL);
>> - create.extensions = 0;
>> -
>> /* Make sure KMD rejects non-zero padding/reserved fields */
>> for (i = 0; i < ARRAY_SIZE(create.pad); i++) {
>> create.pad[i] = -1;
>> --
>> 2.43.0
>>
next prev parent reply other threads:[~2025-01-31 17:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-30 22:14 [PATCH i-g-t 0/3] Prepare for new PXP UAPI flags Daniele Ceraolo Spurio
2025-01-30 22:14 ` [PATCH i-g-t 1/3] tests/intel/xe_vm: Update first invalid flag number Daniele Ceraolo Spurio
2025-01-30 22:36 ` Dixit, Ashutosh
2025-01-30 22:14 ` [PATCH i-g-t 2/3] tests/intel/xe_create: Stop treating the extension field as MBZ Daniele Ceraolo Spurio
2025-01-31 12:59 ` Kamil Konieczny
2025-01-31 17:09 ` Daniele Ceraolo Spurio [this message]
2025-01-31 17:28 ` Kamil Konieczny
2025-01-30 22:14 ` [PATCH i-g-t 3/3] tests/intel/xe_exec_queue_property: Update first invalid property value Daniele Ceraolo Spurio
2025-01-30 23:07 ` ✓ Xe.CI.BAT: success for Prepare for new PXP UAPI flags Patchwork
2025-01-30 23:20 ` ✗ i915.CI.BAT: failure " Patchwork
2025-01-31 3:48 ` ✗ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=008c9383-5022-4f5e-8a85-022100d15242@intel.com \
--to=daniele.ceraolospurio@intel.com \
--cc=alan.previn.teres.alexis@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox