Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>,
	igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [i-g-t] i915/gem_exec_fair: Extend icl ctx timestamp w/a to gen11
Date: Fri, 25 Jun 2021 14:03:20 +0100	[thread overview]
Message-ID: <00fe482b-75fc-35da-9e37-254f8c2f5aa3@linux.intel.com> (raw)
In-Reply-To: <20210624122248.903530-1-tejaskumarx.surendrakumar.upadhyay@intel.com>


On 24/06/2021 13:22, Tejas Upadhyay wrote:
> 80ns timestamp interval identified for icl also applies to
> gen11 platforms. igt@gem_exec_fair@basic-deadline is
> passing with the change on ehl and jsl.
> 
> Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
> ---
>   tests/i915/gem_exec_fair.c | 9 ++-------
>   1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/tests/i915/gem_exec_fair.c b/tests/i915/gem_exec_fair.c
> index 628f4df2..45237574 100644
> --- a/tests/i915/gem_exec_fair.c
> +++ b/tests/i915/gem_exec_fair.c
> @@ -98,16 +98,11 @@ static uint64_t div64_u64_round_up(uint64_t x, uint64_t y)
>   	return (x + y - 1) / y;
>   }
>   
> -static bool is_icelake(int i915)
> -{
> -	return intel_get_device_info(intel_get_drm_devid(i915))->is_icelake;
> -}
> -
>   static uint64_t ns_to_ctx_ticks(int i915, uint64_t ns)
>   {
>   	int f = read_timestamp_frequency(i915);
> -	if (is_icelake(i915))
> -		f = 12500000; /* icl!!! are you feeling alright? CTX vs CS */
> +	if (intel_gen(intel_get_drm_devid(i915)) == 11)
> +		f = 12500000; /* gen11!!! are you feeling alright? CTX vs CS */
>   	return div64_u64_round_up(ns * f, NSEC64);
>   }
>   
> 

Same as the kernel patch, okay, I can push this one as well.

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2021-06-25 13:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-24 12:22 [igt-dev] [i-g-t] i915/gem_exec_fair: Extend icl ctx timestamp w/a to gen11 Tejas Upadhyay
2021-06-25 13:03 ` Tvrtko Ursulin [this message]
2021-06-25 14:02   ` Tvrtko Ursulin
2021-06-28 11:01 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-06-28 13:18 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00fe482b-75fc-35da-9e37-254f8c2f5aa3@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=tejaskumarx.surendrakumar.upadhyay@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox