From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id B4E576E0A3 for ; Tue, 15 Jan 2019 20:49:57 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id g125so2432118qke.4 for ; Tue, 15 Jan 2019 12:49:57 -0800 (PST) Message-ID: <0193a4896fea355a658fd3dccc86720e28dd5677.camel@redhat.com> From: Lyude Paul Date: Tue, 15 Jan 2019 15:49:54 -0500 In-Reply-To: <20190111090532.19235-9-paul.kocialkowski@bootlin.com> References: <20190111090532.19235-1-paul.kocialkowski@bootlin.com> <20190111090532.19235-9-paul.kocialkowski@bootlin.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t v3 08/21] lib/igt_fb: Add a helper to fill-in the available DRM formats List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Paul Kocialkowski , igt-dev@lists.freedesktop.org Cc: Petri Latvala , Eben Upton , Thomas Petazzoni List-ID: T24gRnJpLCAyMDE5LTAxLTExIGF0IDEwOjA1ICswMTAwLCBQYXVsIEtvY2lhbGtvd3NraSB3cm90 ZToKPiBJbnRyb2R1Y2UgYSBoZWxwZXIgdG8gYWxsb2NhdGUgYW5kIGZpbGwtaW4gYSBsaXN0IG9m IGF2YWlsYWJsZSBEUk0KPiBmb3JtYXRzLCB3aGljaCBpcyB1c2VmdWwgZm9yIHBpY2tpbmcgb25l IGF0IHJhbmRvbSBpbiB0ZXN0cy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBQYXVsIEtvY2lhbGtvd3Nr aSA8cGF1bC5rb2NpYWxrb3dza2lAYm9vdGxpbi5jb20+Cj4gLS0tCj4gIGxpYi9pZ3RfZmIuYyB8 IDM0ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgbGliL2lndF9mYi5oIHwg IDIgKysKPiAgMiBmaWxlcyBjaGFuZ2VkLCAzNiBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdp dCBhL2xpYi9pZ3RfZmIuYyBiL2xpYi9pZ3RfZmIuYwo+IGluZGV4IDg2Y2ViMDI4YmRhZS4uOGFk ZjMyOTVkZjU2IDEwMDY0NAo+IC0tLSBhL2xpYi9pZ3RfZmIuYwo+ICsrKyBiL2xpYi9pZ3RfZmIu Ywo+IEBAIC0yNDIwLDMgKzI0MjAsMzcgQEAgaW50IGlndF9mb3JtYXRfcGxhbmVfYnBwKHVpbnQz Ml90IGRybV9mb3JtYXQsIGludAo+IHBsYW5lKQo+ICAKPiAgCXJldHVybiBmb3JtYXQtPnBsYW5l X2JwcFtwbGFuZV07Cj4gIH0KPiArCj4gKy8qKgo+ICsgKiBpZ3RfZm9ybWF0X2FycmF5X2ZpbGw6 Cj4gKyAqIEBmb3JtYXRzX2FycmF5OiBhIHBvaW50ZXIgdG8gdGhlIGZvcm1hdHMgYXJyYXkgcG9p bnRlciB0byBiZSBhbGxvY2F0ZWQKPiArICogQGNvdW50OiBhIHBvaW50ZXIgdG8gdGhlIG51bWJl ciBvZiBlbGVtZW50cyBjb250YWluZWQgaW4gdGhlIGFsbG9jYXRlZAo+IGFycmF5Cj4gKyAqIEBh bGxvd195dXY6IGEgYm9vbGVhbiBpbmRpY2F0aW5nIHdoZXRoZXIgWVVWIGZvcm1hdHMgc2hvdWxk IGJlIGluY2x1ZGVkCj4gKyAqCj4gKyAqIFRoaXMgZnVuY3Rpb25zIGFsbG9jYXRlcyBhbmQgZmls bHMgYSBAZm9ybWF0c19hcnJheSB0aGF0IGxpc3RzIHRoZSBEUk0KPiArICogZm9ybWF0cyBjdXJy ZW50IGF2YWlsYWJsZS4KPiArICovCj4gK3ZvaWQgaWd0X2Zvcm1hdF9hcnJheV9maWxsKHVpbnQz Ml90ICoqZm9ybWF0c19hcnJheSwgdW5zaWduZWQgaW50ICpjb3VudCwKPiArCQkJICAgYm9vbCBh bGxvd195dXYpCj4gK3sKPiArCWNvbnN0IHN0cnVjdCBmb3JtYXRfZGVzY19zdHJ1Y3QgKmZvcm1h dDsKPiArCXVuc2lnbmVkIGludCBpbmRleCA9IDA7Cj4gKwo+ICsJKmNvdW50ID0gMDsKPiArCj4g Kwlmb3JfZWFjaF9mb3JtYXQoZm9ybWF0KSB7Cj4gKwkJaWYgKCFhbGxvd195dXYgJiYgaWd0X2Zv cm1hdF9pc195dXYoZm9ybWF0LT5kcm1faWQpKQo+ICsJCQljb250aW51ZTsKPiArCj4gKwkJKCpj b3VudCkrKzsKPiArCX0KPiArCj4gKwkqZm9ybWF0c19hcnJheSA9IGNhbGxvYygqY291bnQsIHNp emVvZih1aW50MzJfdCkpOwpQcm9iYWJseSBhIGdvb2QgaWRlYSB0byBwdXQgYW4gaWd0X2Fzc2Vy dCgpIGFmdGVyIHRoaXMgdG8gbWFrZSBzdXJlIHRoYXQKZm9ybWF0c19hcnJheSBnb3QgYWxsb2Nh dGVkIHByb3Blcmx5LiBXaXRoIHRoYXQgZml4ZWQ6CgpSZXZpZXdlZC1ieTogTHl1ZGUgUGF1bCA8 bHl1ZGVAcmVkaGF0LmNvbT4KPiArCj4gKwlmb3JfZWFjaF9mb3JtYXQoZm9ybWF0KSB7Cj4gKwkJ aWYgKCFhbGxvd195dXYgJiYgaWd0X2Zvcm1hdF9pc195dXYoZm9ybWF0LT5kcm1faWQpKQo+ICsJ CQljb250aW51ZTsKPiArCj4gKwkJKCpmb3JtYXRzX2FycmF5KVtpbmRleCsrXSA9IGZvcm1hdC0+ ZHJtX2lkOwo+ICsJfQo+ICt9Cj4gZGlmZiAtLWdpdCBhL2xpYi9pZ3RfZmIuaCBiL2xpYi9pZ3Rf ZmIuaAo+IGluZGV4IGEzOWM0ZDJmZTMwZS4uYzZlZGRkZWMxZDc2IDEwMDY0NAo+IC0tLSBhL2xp Yi9pZ3RfZmIuaAo+ICsrKyBiL2xpYi9pZ3RfZmIuaAo+IEBAIC0xNzYsNiArMTc2LDggQEAgY29u c3QgY2hhciAqaWd0X2Zvcm1hdF9zdHIodWludDMyX3QgZHJtX2Zvcm1hdCk7Cj4gIGJvb2wgaWd0 X2ZiX3N1cHBvcnRlZF9mb3JtYXQodWludDMyX3QgZHJtX2Zvcm1hdCk7Cj4gIGJvb2wgaWd0X2Zv cm1hdF9pc195dXYodWludDMyX3QgZHJtX2Zvcm1hdCk7Cj4gIGludCBpZ3RfZm9ybWF0X3BsYW5l X2JwcCh1aW50MzJfdCBkcm1fZm9ybWF0LCBpbnQgcGxhbmUpOwo+ICt2b2lkIGlndF9mb3JtYXRf YXJyYXlfZmlsbCh1aW50MzJfdCAqKmZvcm1hdHNfYXJyYXksIHVuc2lnbmVkIGludCAqY291bnQs Cj4gKwkJCSAgIGJvb2wgYWxsb3dfeXV2KTsKPiAgCj4gICNlbmRpZiAvKiBfX0lHVF9GQl9IX18g Ki8KPiAgCi0tIApDaGVlcnMsCglMeXVkZSBQYXVsCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2lndC1kZXYK