Re: [PATCH i-g-t v4 6/6] tests/gem_gpgpu_fill: Add offset-16x16 subtest

["Grzegorzek, Dominik" <dominik.grzegorzek@intel.com>]

On Thu, 2024-11-21 at 13:33 +0100, Zbigniew Kempczyński wrote:
> Add subtest which verifies rectangle filled by pattern starts at
> offset <x,y> == <16,16>.
> 
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
> ---
>  tests/intel/gem_gpgpu_fill.c | 15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/intel/gem_gpgpu_fill.c b/tests/intel/gem_gpgpu_fill.c
> index ec34e95844..cfebc8f665 100644
> --- a/tests/intel/gem_gpgpu_fill.c
> +++ b/tests/intel/gem_gpgpu_fill.c
> @@ -58,6 +58,10 @@
>   * Feature: compute
>   *
>   * SUBTEST: basic
> + * Description: run gpgpu fill
> + *
> + * SUBTEST: offset-16x16
> + * Description: run gpgpu fill with <x,y> start position == <16,16>
>   */
>  
>  #define WIDTH 64
> @@ -239,9 +243,16 @@ igt_main_args("dW:H:X:Y:", NULL, help_str, opt_handler, NULL)
>  		}
>  	}
>  
> +	igt_subtest("offset-16x16") {
> +		gpgpu_fill(&data, fill_fn, 0,
> +			   surfwidth, surfheight,
> +			   16, 16,
> +			   surfwidth / 2,
> +			   surfheight / 2);
> +	}
> +
>  	igt_fixture {
> -		igt_collection_destroy(region_set);
> -		free(region_info);
Why removing this? 

Regards, 
Dominik
>  		buf_ops_destroy(data.bops);
> +		drm_close_driver(data.drm_fd);
>  	}
>  }