Re: [PATCH i-g-t] CONTRIBUTING: Add coding style guidelines

[Arthur Grillo <arthurgrillo@riseup.net>]

On 15/03/24 13:08, Louis Chauvet wrote:
> As explained in [1], the submitted patches should follow the same style as
> the Linux kernel and must be checked against checkpatch.pl, so add this
> recommendation in the CONTRIBUTING.md file.
> 
> [1]: https://lore.kernel.org/all/20240314170643.77vzqqoie2otyu4w@kamilkon-desk.igk.intel.com/
> 
> Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>

I could swear that this was already there.

Reviewed-by: Arthur Grillo <arthurgrillo@riseup.net>

> 
> To: igt-dev@lists.freedesktop.org
> Cc: miquel.raynal@bootlin.com
> Cc: thomas.petazzoni@bootlin.com
> Cc: jeremie.dautheribes@bootlin.com
> Cc: arthurgrillo@riseup.net
> Cc: seanpaul@google.com
> Cc: marcheu@google.com
> Cc: nicolejadeyee@google.com
> Cc: kamil.konieczny@linux.intel.com
> ---
> To: igt-dev@lists.freedesktop.org
> Cc: miquel.raynal@bootlin.com
> Cc: thomas.petazzoni@bootlin.com
> Cc: jeremie.dautheribes@bootlin.com
> Cc: arthurgrillo@riseup.net
> Cc: seanpaul@google.com
> Cc: marcheu@google.com
> Cc: nicolejadeyee@google.com
> Cc: kamil.konieczny@linux.intel.com
> 
> Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
> ---
>  CONTRIBUTING.md | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
> index 2ab8a48f6ae9..ec8debb4091e 100644
> --- a/CONTRIBUTING.md
> +++ b/CONTRIBUTING.md
> @@ -78,6 +78,8 @@ Sending Patches
>  - Changes to the testcases are automatically tested. Take the results into
>    account before merging.
>  
> +- The coding rules are the same as for the Linux kernel. To check for common
> +  style problems, you need to use the kernel's checkpatch.pl script.
>  
>  Commit Rights
>  -------------
> 
> ---
> base-commit: ed47dd9fb6b5be6c88513c2816f0f7cfdd0e02f6
> change-id: 20240315-add_coding_style-b755454de958
> 
> Best regards,