From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6A38D89FCA for ; Thu, 21 Mar 2019 16:46:00 +0000 (UTC) References: <20190321160528.4131-1-andi.shyti@intel.com> <20190321160528.4131-3-andi.shyti@intel.com> From: Tvrtko Ursulin Message-ID: <0246acff-1e57-feb7-ac58-6805264c3542@linux.intel.com> Date: Thu, 21 Mar 2019 16:45:57 +0000 MIME-Version: 1.0 In-Reply-To: <20190321160528.4131-3-andi.shyti@intel.com> Content-Language: en-US Subject: Re: [igt-dev] [PATCH v15 2/5] lib: ioctl_wrappers: reach engines by index as well List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Andi Shyti , IGT dev Cc: Andi Shyti List-ID: Ck9uIDIxLzAzLzIwMTkgMTY6MDUsIEFuZGkgU2h5dGkgd3JvdGU6Cj4gV2l0aCB0aGUgbmV3IGVu Z2luZSBxdWVyeSBtZXRob2QgZW5naW5lcyBhcmUgcmVhY2hhYmxlIHRocm91Z2gKPiBhbiBpbmRl eCBhbmQgY29udGV4dCB0aGV5IGFyZSBjb21iaW5lZCB3aXRoLgo+IAo+IFRoZSAnZ2VtX2hhc19y aW5nKCknIGJlY29tZXMgJ2dlbV9jb250ZXh0X2hhc19lbmdpbmUoKScgdGhhdAo+IHJlcXVpcmVz IHRoZSBpbmRleCB0aGF0IHRoZSBlbmdpbmUgaXMgbWFwcGVkIHdpdGhpbiB0aGUgZHJpdmVyLgo+ IFRoZSBmdW5jdGlvbiBoYXMgYmVlbiBtb3ZlZCBmcm9tIGxpYi9pb2N0bF93YXBwZXJzIHRvCj4g bGliL2k5MTUvZ2VtX2NvbnRleHQgd2hlcmUgaXQgaXMgbW9yZSBhcHByb3ByaWF0ZS4KPiAKPiBU aGUgcHJldmlvdXMgJ2dlbV9oYXNfcmluZygpJyBmdW5jdGlvbiBiZWNvbWVzIGEgd3JhcHBlciB0 byB0aGUKPiBuZXcgJ2dlbV9jb250ZXh0X2hhc19lbmdpbmUoKScuCj4gCj4gU2lnbmVkLW9mZi1i eTogQW5kaSBTaHl0aSA8YW5kaS5zaHl0aUBpbnRlbC5jb20+Cj4gUmV2aWV3ZWQtYnk6IENocmlz IFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IC0tLQo+ICAgbGliL2k5MTUvZ2Vt X2NvbnRleHQuYyB8IDIxICsrKysrKysrKysrKysrKysrKysrKwo+ICAgbGliL2k5MTUvZ2VtX2Nv bnRleHQuaCB8ICAyICsrCj4gICBsaWIvaW9jdGxfd3JhcHBlcnMuYyAgIHwgMTkgLS0tLS0tLS0t LS0tLS0tLS0tLQo+ICAgbGliL2lvY3RsX3dyYXBwZXJzLmggICB8ICAzICsrLQo+ICAgNCBmaWxl cyBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspLCAyMCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0t Z2l0IGEvbGliL2k5MTUvZ2VtX2NvbnRleHQuYyBiL2xpYi9pOTE1L2dlbV9jb250ZXh0LmMKPiBp bmRleCAxNjAwNDY4NWU5MjAuLjk0Y2NiNzRiNmFlYSAxMDA2NDQKPiAtLS0gYS9saWIvaTkxNS9n ZW1fY29udGV4dC5jCj4gKysrIGIvbGliL2k5MTUvZ2VtX2NvbnRleHQuYwo+IEBAIC0yNzUsMyAr Mjc1LDI0IEBAIHZvaWQgZ2VtX2NvbnRleHRfc2V0X3ByaW9yaXR5KGludCBmZCwgdWludDMyX3Qg Y3R4X2lkLCBpbnQgcHJpbykKPiAgIHsKPiAgIAlpZ3RfYXNzZXJ0KF9fZ2VtX2NvbnRleHRfc2V0 X3ByaW9yaXR5KGZkLCBjdHhfaWQsIHByaW8pID09IDApOwo+ICAgfQo+ICsKPiArYm9vbCBnZW1f Y29udGV4dF9oYXNfZW5naW5lKGludCBmZCwgdWludDMyX3QgY3R4LCB1aW50MzJfdCBlbmdpbmUp Cj4gK3sKPiArCXN0cnVjdCBkcm1faTkxNV9nZW1fZXhlY2J1ZmZlcjIgZXhlY2J1ZjsKPiArCXN0 cnVjdCBkcm1faTkxNV9nZW1fZXhlY19vYmplY3QyIGV4ZWM7Cj4gKwo+ICsJLyogc2lsbHkgQUJJ LCB0aGUga2VybmVsIHRoaW5rcyBldmVyeW9uZSB3aG8gaGFzIEJTRCBhbHNvIGhhcyBCU0QyICov CgpDYW4geW91IGFkZCB0aGUgY29tbWVudCBoZXJlIGFzIEkgc3VnZ2VzdGVkIGluIHRoZSBwcmV2 aW91cyByb3VuZD8gClNvbWV0aGluZyBsaWtlOgoKIgpFbmdpbmUgY2FuIGJlIGVpdGhlciBleGVj YnVmIGZsYWdzIGVuZ2luZSBzZWxlY3Rvciwgb3IgY29udGV4dCBtYXAgCmluZGV4LCBidXQgaW4g dGhlIGZvbGxvd2luZyBjYXNlIHdlIGNhbiBzdGlsbCBzYWZlbHkgY2hlY2sgYWdhaW5zdCAKSTkx NV9FWEVDX0JTRCBzaW5jZSB3ZSBkb24ndCBleHBlY3QgMSA8PCAxMyBvciBtb3JlIGVuZ2luZXMg aW4gdGhlIG1hcC4KIgoKUmVnYXJkcywKClR2cnRrbwoKPiArCWlmICgoZW5naW5lICYgfigzPDwx MykpID09IEk5MTVfRVhFQ19CU0QpIHsKPiArCQlpZiAoZW5naW5lICYgKDMgPDwgMTMpICYmICFn ZW1faGFzX2JzZDIoZmQpKQo+ICsJCQlyZXR1cm4gZmFsc2U7Cj4gKwl9Cj4gKwo+ICsJbWVtc2V0 KCZleGVjLCAwLCBzaXplb2YoZXhlYykpOwo+ICsJbWVtc2V0KCZleGVjYnVmLCAwLCBzaXplb2Yo ZXhlY2J1ZikpOwo+ICsJZXhlY2J1Zi5idWZmZXJzX3B0ciA9IHRvX3VzZXJfcG9pbnRlcigmZXhl Yyk7Cj4gKwlleGVjYnVmLmJ1ZmZlcl9jb3VudCA9IDE7Cj4gKwlleGVjYnVmLmZsYWdzID0gZW5n aW5lOwo+ICsJZXhlY2J1Zi5yc3ZkMSA9IGN0eDsKPiArCj4gKwlyZXR1cm4gX19nZW1fZXhlY2J1 ZihmZCwgJmV4ZWNidWYpID09IC1FTk9FTlQ7Cj4gK30KPiBkaWZmIC0tZ2l0IGEvbGliL2k5MTUv Z2VtX2NvbnRleHQuaCBiL2xpYi9pOTE1L2dlbV9jb250ZXh0LmgKPiBpbmRleCBhZWY2OGRkYTZi MjYuLmRkNjRlYmYxN2ZiZCAxMDA2NDQKPiAtLS0gYS9saWIvaTkxNS9nZW1fY29udGV4dC5oCj4g KysrIGIvbGliL2k5MTUvZ2VtX2NvbnRleHQuaAo+IEBAIC00NSw0ICs0NSw2IEBAIGludCBfX2dl bV9jb250ZXh0X2dldF9wYXJhbShpbnQgZmQsIHN0cnVjdCBkcm1faTkxNV9nZW1fY29udGV4dF9w YXJhbSAqcCk7Cj4gICBpbnQgX19nZW1fY29udGV4dF9zZXRfcHJpb3JpdHkoaW50IGZkLCB1aW50 MzJfdCBjdHgsIGludCBwcmlvKTsKPiAgIHZvaWQgZ2VtX2NvbnRleHRfc2V0X3ByaW9yaXR5KGlu dCBmZCwgdWludDMyX3QgY3R4LCBpbnQgcHJpbyk7Cj4gICAKPiArYm9vbCBnZW1fY29udGV4dF9o YXNfZW5naW5lKGludCBmZCwgdW5zaWduZWQgZW5naW5lLCB1bnNpZ25lZCBjdHgpOwo+ICsKPiAg ICNlbmRpZiAvKiBHRU1fQ09OVEVYVF9IICovCj4gZGlmZiAtLWdpdCBhL2xpYi9pb2N0bF93cmFw cGVycy5jIGIvbGliL2lvY3RsX3dyYXBwZXJzLmMKPiBpbmRleCBhNjZlYjRiYzBmNGYuLjNmOGYw ODc0YmM0YiAxMDA2NDQKPiAtLS0gYS9saWIvaW9jdGxfd3JhcHBlcnMuYwo+ICsrKyBiL2xpYi9p b2N0bF93cmFwcGVycy5jCj4gQEAgLTEyNTMsMjUgKzEyNTMsNiBAQCB2b2lkIGlndF9yZXF1aXJl X2dlbShpbnQgZmQpCj4gICAJaWd0X3JlcXVpcmVfZihlcnIgPT0gMCwgIlVucmVzcG9uc2l2ZSBp OTE1L0dFTSBkZXZpY2VcbiIpOwo+ICAgfQo+ICAgCj4gLWJvb2wgZ2VtX2hhc19yaW5nKGludCBm ZCwgdW5zaWduZWQgcmluZykKPiAtewo+IC0Jc3RydWN0IGRybV9pOTE1X2dlbV9leGVjYnVmZmVy MiBleGVjYnVmOwo+IC0Jc3RydWN0IGRybV9pOTE1X2dlbV9leGVjX29iamVjdDIgZXhlYzsKPiAt Cj4gLQkvKiBzaWxseSBBQkksIHRoZSBrZXJuZWwgdGhpbmtzIGV2ZXJ5b25lIHdobyBoYXMgQlNE IGFsc28gaGFzIEJTRDIgKi8KPiAtCWlmICgocmluZyAmIH4oMzw8MTMpKSA9PSBJOTE1X0VYRUNf QlNEKSB7Cj4gLQkJaWYgKHJpbmcgJiAoMyA8PCAxMykgJiYgIWdlbV9oYXNfYnNkMihmZCkpCj4g LQkJCXJldHVybiBmYWxzZTsKPiAtCX0KPiAtCj4gLQltZW1zZXQoJmV4ZWMsIDAsIHNpemVvZihl eGVjKSk7Cj4gLQltZW1zZXQoJmV4ZWNidWYsIDAsIHNpemVvZihleGVjYnVmKSk7Cj4gLQlleGVj YnVmLmJ1ZmZlcnNfcHRyID0gdG9fdXNlcl9wb2ludGVyKCZleGVjKTsKPiAtCWV4ZWNidWYuYnVm ZmVyX2NvdW50ID0gMTsKPiAtCWV4ZWNidWYuZmxhZ3MgPSByaW5nOwo+IC0JcmV0dXJuIF9fZ2Vt X2V4ZWNidWYoZmQsICZleGVjYnVmKSA9PSAtRU5PRU5UOwo+IC19Cj4gLQo+ICAgLyoqCj4gICAg KiBnZW1fcmVxdWlyZV9yaW5nOgo+ICAgICogQGZkOiBvcGVuIGk5MTUgZHJtIGZpbGUgZGVzY3Jp cHRvcgo+IGRpZmYgLS1naXQgYS9saWIvaW9jdGxfd3JhcHBlcnMuaCBiL2xpYi9pb2N0bF93cmFw cGVycy5oCj4gaW5kZXggYWQ5M2RhZmZjZmQ1Li5lNzEyZjE5NzMxNDIgMTAwNjQ0Cj4gLS0tIGEv bGliL2lvY3RsX3dyYXBwZXJzLmgKPiArKysgYi9saWIvaW9jdGxfd3JhcHBlcnMuaAo+IEBAIC0x NDIsMTEgKzE0MiwxMiBAQCBib29sIGdlbV9oYXNfZXhlY19mZW5jZShpbnQgZmQpOwo+ICAgCj4g ICAvKiBjaGVjayBmdW5jdGlvbnMgd2hpY2ggYXV0by1za2lwIHRlc3RzIGJ5IGNhbGxpbmcgaWd0 X3NraXAoKSAqLwo+ICAgdm9pZCBnZW1fcmVxdWlyZV9jYWNoaW5nKGludCBmZCk7Cj4gLWJvb2wg Z2VtX2hhc19yaW5nKGludCBmZCwgdW5zaWduZWQgcmluZyk7Cj4gICB2b2lkIGdlbV9yZXF1aXJl X3JpbmcoaW50IGZkLCB1bnNpZ25lZCByaW5nKTsKPiAgIGJvb2wgZ2VtX2hhc19tb2NzX3JlZ2lz dGVycyhpbnQgZmQpOwo+ICAgdm9pZCBnZW1fcmVxdWlyZV9tb2NzX3JlZ2lzdGVycyhpbnQgZmQp Owo+ICAgCj4gKyNkZWZpbmUgZ2VtX2hhc19yaW5nKGYsIHIpIGdlbV9jb250ZXh0X2hhc19lbmdp bmUoZiwgMCwgcikKPiArCj4gICAvKiBwcmltZSAqLwo+ICAgc3RydWN0IGxvY2FsX2RtYV9idWZf c3luYyB7Cj4gICAJdWludDY0X3QgZmxhZ3M7Cj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmlndC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaWd0LWRldg==