From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: References: <20190924220137.20627-1-chris@chris-wilson.co.uk> <20190925092328.30236-1-chris@chris-wilson.co.uk> From: Tvrtko Ursulin Message-ID: <02f78ea8-8056-a99e-7abe-95dcb977d85a@linux.intel.com> Date: Wed, 25 Sep 2019 10:27:58 +0100 MIME-Version: 1.0 In-Reply-To: <20190925092328.30236-1-chris@chris-wilson.co.uk> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH i-g-t v2] i915/perf_pmu: Compare semaphore and busy measurements List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: igt-dev@lists.freedesktop.org List-ID: Ck9uIDI1LzA5LzIwMTkgMTA6MjMsIENocmlzIFdpbHNvbiB3cm90ZToKPiBPdXIgc2VtYXBob3Jl IHRpbWUgaXMgbWVhc3VyZWQgYnkgc2FtcGxpbmcgYSByaW5nIHJlZ2lzdGVyLCB3aGVyZWFzIG91 cgo+IGJ1c3kgdGltZSBpcyBtZWFzdXJlZCBleGFjdGx5LiBUaGlzIGxlYXZlcyBhIHdpbmRvdyBv ZiBkaXNjcmVwYW5jeSB0aGF0Cj4gd2Ugd2lzaCB0byBrZWVwIHNtYWxsIChhdCBsZWFzdCB3aXRo aW4gc2FtcGxlIHRvbGVyYW5jZSkuCj4gCj4gdjI6IEV4cGxhaW4gdGhlIHNlbWEgPD0gYnVzeSBh c3NlcnQsIGFuZCBsb3RzIG9mIG90aGVyIFR2cnRrbyB0d2Vha3MKPiAKPiBSZWZlcmVuY2VzOiBo dHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD0xMTE3ODgKPiBTaWdu ZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzog VHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiAtLS0KPiAgIHRlc3Rz L3BlcmZfcG11LmMgfCA5MyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKy0KPiAgIDEgZmlsZSBjaGFuZ2VkLCA5MiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9u KC0pCj4gCj4gZGlmZiAtLWdpdCBhL3Rlc3RzL3BlcmZfcG11LmMgYi90ZXN0cy9wZXJmX3BtdS5j Cj4gaW5kZXggOGEwNmU1ZDQ0Li4yYWVkMzM4MWYgMTAwNjQ0Cj4gLS0tIGEvdGVzdHMvcGVyZl9w bXUuYwo+ICsrKyBiL3Rlc3RzL3BlcmZfcG11LmMKPiBAQCAtMTMwLDcgKzEzMCw3IEBAIHN0YXRp YyB1aW50NjRfdCBwbXVfcmVhZF9tdWx0aShpbnQgZmQsIHVuc2lnbmVkIGludCBudW0sIHVpbnQ2 NF90ICp2YWwpCj4gICAjZGVmaW5lIF9fYXNzZXJ0X3dpdGhpbl9lcHNpbG9uKHgsIHJlZiwgdG9s X3VwLCB0b2xfZG93bikgXAo+ICAgCWlndF9hc3NlcnRfZigoZG91YmxlKSh4KSA8PSAoMS4wICsg KHRvbF91cCkpICogKGRvdWJsZSkocmVmKSAmJiBcCj4gICAJCSAgICAgKGRvdWJsZSkoeCkgPj0g KDEuMCAtICh0b2xfZG93bikpICogKGRvdWJsZSkocmVmKSwgXAo+IC0JCSAgICAgIiclcycgIT0g JyVzJyAoJWYgbm90IHdpdGhpbiArJWYlJS8tJWYlJSB0b2xlcmFuY2Ugb2YgJWYpXG4iLFwKPiAr CQkgICAgICInJXMnICE9ICclcycgKCVmIG5vdCB3aXRoaW4gKyUuMWYlJS8tJS4xZiUlIHRvbGVy YW5jZSBvZiAlZilcbiIsXAo+ICAgCQkgICAgICN4LCAjcmVmLCAoZG91YmxlKSh4KSwgXAo+ICAg CQkgICAgICh0b2xfdXApICogMTAwLjAsICh0b2xfZG93bikgKiAxMDAuMCwgXAo+ICAgCQkgICAg IChkb3VibGUpKHJlZikpCj4gQEAgLTc0NCw2ICs3NDQsOTQgQEAgc2VtYV93YWl0KGludCBnZW1f ZmQsIGNvbnN0IHN0cnVjdCBpbnRlbF9leGVjdXRpb25fZW5naW5lMiAqZSwKPiAgIAlhc3NlcnRf d2l0aGluX2Vwc2lsb24odmFsWzFdIC0gdmFsWzBdLCBzbGVwdCwgdG9sZXJhbmNlKTsKPiAgIH0K PiAgIAo+ICtzdGF0aWMgdm9pZAo+ICtfX3NlbWFfYnVzeShpbnQgZ2VtX2ZkLCBpbnQgcG11LAo+ ICsJICAgIGNvbnN0IHN0cnVjdCBpbnRlbF9leGVjdXRpb25fZW5naW5lMiAqZSwKPiArCSAgICBj b25zdCBzdHJ1Y3QgaW50ZWxfZXhlY3V0aW9uX2VuZ2luZTIgKnNpZ25hbCwKPiArCSAgICBpbnQg c2VtYV9wY3QsCj4gKwkgICAgaW50IGJ1c3lfcGN0KQo+ICt7Cj4gKwllbnVtIHsKPiArCQlTRU1B ID0gMCwKPiArCQlCVVNZLAo+ICsJfTsKPiArCXVpbnQ2NF90IHRvdGFsLCBzZW1hLCBidXN5Owo+ ICsJdWludDY0X3Qgc3RhcnRbMl0sIHZhbFsyXTsKPiArCWlndF9zcGluX3QgKnNwaW5bMl07Cj4g Kwo+ICsJLyogVGltZSBzcGVudCBiZWluZyBidXN5IGluY2x1ZGVzIHRpbWUgd2FpdGluZyBvbiBz ZW1hcGhvcmVzICovCj4gKwlpZ3RfYXNzZXJ0KGJ1c3lfcGN0ID49IHNlbWFfcGN0KTsKPiArCj4g KwlnZW1fcXVpZXNjZW50X2dwdShnZW1fZmQpOwo+ICsKPiArCXNwaW5bMF0gPSBpZ3Rfc3Bpbl9u ZXcoZ2VtX2ZkLAo+ICsJCQkgICAgICAgLmVuZ2luZSA9IHNpZ25hbC0+ZmxhZ3MsCj4gKwkJCSAg ICAgICAuZmxhZ3MgPSBJR1RfU1BJTl9GRU5DRV9PVVQgfCBJR1RfU1BJTl9QT0xMX1JVTik7Cj4g KwlzcGluWzFdID0gaWd0X3NwaW5fbmV3KGdlbV9mZCwKPiArCQkJICAgICAgIC5lbmdpbmUgPSBl LT5mbGFncywKPiArCQkJICAgICAgIC5mZW5jZSA9IHNwaW5bMF0tPm91dF9mZW5jZSwKPiArCQkJ ICAgICAgIC5mbGFncyA9IElHVF9TUElOX0ZFTkNFX0lOKTsKPiArCj4gKwlpZ3Rfc3Bpbl9idXN5 d2FpdF91bnRpbF9zdGFydGVkKHNwaW5bMF0pOwo+ICsKPiArCXRvdGFsID0gcG11X3JlYWRfbXVs dGkocG11LCAyLCBzdGFydCk7Cj4gKwo+ICsJc2VtYSA9IG1lYXN1cmVkX3VzbGVlcChiYXRjaF9k dXJhdGlvbl9ucyAqIHNlbWFfcGN0IC8gMTAwIC8gMTAwMCk7Cj4gKwlpZ3Rfc3Bpbl9lbmQoc3Bp blswXSk7Cj4gKwlidXN5ID0gbWVhc3VyZWRfdXNsZWVwKGJhdGNoX2R1cmF0aW9uX25zICogKGJ1 c3lfcGN0IC0gc2VtYV9wY3QpIC8gMTAwIC8gMTAwMCk7Cj4gKwlpZ3Rfc3Bpbl9lbmQoc3Bpblsx XSk7Cj4gKwltZWFzdXJlZF91c2xlZXAoYmF0Y2hfZHVyYXRpb25fbnMgKiAoMTAwIC0gYnVzeV9w Y3QpIC8gMTAwIC8gMTAwMCk7Cj4gKwo+ICsJdG90YWwgPSBwbXVfcmVhZF9tdWx0aShwbXUsIDIs IHZhbCkgLSB0b3RhbDsKPiArCj4gKwlidXN5ICs9IHNlbWE7Cj4gKwl2YWxbU0VNQV0gLT0gc3Rh cnRbU0VNQV07Cj4gKwl2YWxbQlVTWV0gLT0gc3RhcnRbQlVTWV07Cj4gKwo+ICsJaWd0X2luZm8o IiVzPC0lcywgdGFyZ2V0OiB7JS4xZiUlIFslZF0sICUuMWYlJSBbJWRdfSwgbWVhc3VyZWQ6IHsl LjFmJSUsICUuMWYlJX1cbiIsCj4gKwkJIGUtPm5hbWUsIHNpZ25hbC0+bmFtZSwKPiArCQkgc2Vt YSAqIDEwMC4gLyB0b3RhbCwgc2VtYV9wY3QsCj4gKwkJIGJ1c3kgKiAxMDAuIC8gdG90YWwsIGJ1 c3lfcGN0LAo+ICsJCSB2YWxbU0VNQV0gKiAxMDAuIC8gdG90YWwsCj4gKwkJIHZhbFtCVVNZXSAq IDEwMC4gLyB0b3RhbCk7Cj4gKwo+ICsJYXNzZXJ0X3dpdGhpbl9lcHNpbG9uKHZhbFtTRU1BXSwg c2VtYSwgdG9sZXJhbmNlKTsKPiArCWFzc2VydF93aXRoaW5fZXBzaWxvbih2YWxbQlVTWV0sIGJ1 c3ksIHRvbGVyYW5jZSk7Cj4gKwlpZ3RfYXNzZXJ0X2YodmFsW1NFTUFdIDwgdmFsW0JVU1ldICog KDEgKyB0b2xlcmFuY2UpLAo+ICsJCSAgICAgIlNlbWFwaG9yZSB0aW1lICglLjNmdXMsICUxLmYl JSkgZ3JlYXRlciB0aGFuIHRvdGFsIHRpbWUgYnVzeSAoJS4zZnVzLCAlMS5mJSUpIVxuIiwKPiAr CQkgICAgIHZhbFtTRU1BXSAqIDFlLTMsIHZhbFtTRU1BXSAqIDEwMC4gLyB0b3RhbCwKPiArCQkg ICAgIHZhbFtCVVNZXSAqIDFlLTMsIHZhbFtCVVNZXSAqIDEwMC4gLyB0b3RhbCk7Cj4gKwo+ICsJ aWd0X3NwaW5fZnJlZShnZW1fZmQsIHNwaW5bMV0pOwo+ICsJaWd0X3NwaW5fZnJlZShnZW1fZmQs IHNwaW5bMF0pOwo+ICt9Cj4gKwo+ICtzdGF0aWMgdm9pZAo+ICtzZW1hX2J1c3koaW50IGdlbV9m ZCwKPiArCSAgY29uc3Qgc3RydWN0IGludGVsX2V4ZWN1dGlvbl9lbmdpbmUyICplLAo+ICsJICB1 bnNpZ25lZCBpbnQgZmxhZ3MpCj4gK3sKPiArCWNvbnN0IHN0cnVjdCBpbnRlbF9leGVjdXRpb25f ZW5naW5lMiAqc2lnbmFsOwo+ICsJaW50IGZkOwo+ICsKPiArCWlndF9yZXF1aXJlKGdlbV9zY2hl ZHVsZXJfaGFzX3NlbWFwaG9yZXMoZ2VtX2ZkKSk7Cj4gKwo+ICsJZmQgPSBvcGVuX2dyb3VwKEk5 MTVfUE1VX0VOR0lORV9TRU1BKGUtPmNsYXNzLCBlLT5pbnN0YW5jZSksIC0xKTsKPiArCW9wZW5f Z3JvdXAoSTkxNV9QTVVfRU5HSU5FX0JVU1koZS0+Y2xhc3MsIGUtPmluc3RhbmNlKSwgZmQpOwo+ ICsKPiArCV9fZm9yX2VhY2hfcGh5c2ljYWxfZW5naW5lKGdlbV9mZCwgc2lnbmFsKSB7Cj4gKwkJ aWYgKGUtPmNsYXNzID09IHNpZ25hbC0+Y2xhc3MgJiYKPiArCQkgICAgZS0+aW5zdGFuY2UgPT0g c2lnbmFsLT5pbnN0YW5jZSkKPiArCQkJY29udGludWU7Cj4gKwo+ICsJCV9fc2VtYV9idXN5KGdl bV9mZCwgZmQsIGUsIHNpZ25hbCwgNTAsIDEwMCk7Cj4gKwkJX19zZW1hX2J1c3koZ2VtX2ZkLCBm ZCwgZSwgc2lnbmFsLCAyNSwgNTApOwo+ICsJCV9fc2VtYV9idXN5KGdlbV9mZCwgZmQsIGUsIHNp Z25hbCwgNzUsIDc1KTsKPiArCX0KPiArCj4gKwljbG9zZShmZCk7Cj4gK30KPiArCj4gICAjZGVm aW5lICAgTUlfV0FJVF9GT1JfUElQRV9DX1ZCTEFOSyAoMTw8MjEpCj4gICAjZGVmaW5lICAgTUlf V0FJVF9GT1JfUElQRV9CX1ZCTEFOSyAoMTw8MTEpCj4gICAjZGVmaW5lICAgTUlfV0FJVF9GT1Jf UElQRV9BX1ZCTEFOSyAoMTw8MykKPiBAQCAtMTc3NCw2ICsxODYyLDkgQEAgaWd0X21haW4KPiAg IAkJCXNlbWFfd2FpdChmZCwgZSwKPiAgIAkJCQkgIFRFU1RfQlVTWSB8IFRFU1RfVFJBSUxJTkdf SURMRSk7Cj4gICAKPiArCQlpZ3Rfc3VidGVzdF9mKCJzZW1hcGhvcmUtYnVzeS0lcyIsIGUtPm5h bWUpCj4gKwkJCXNlbWFfYnVzeShmZCwgZSwgMCk7Cj4gKwo+ICAgCQkvKioKPiAgIAkJICogQ2hl Y2sgdGhhdCB0d28gcGVyZiBjbGllbnRzIGRvIG5vdCBpbmZsdWVuY2UgZWFjaAo+ICAgCQkgKiBv dGhlcnMgb2JzZXJ2YXRpb25zLgo+IAoKUmV2aWV3ZWQtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0 a28udXJzdWxpbkBpbnRlbC5jb20+CgpSZWdhcmRzLAoKVHZydGtvCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50 ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==