Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: "Nerlige Ramappa, Umesh" <umesh.nerlige.ramappa@intel.com>,
	igt-dev@lists.freedesktop.org, John.C.Harrison@Intel.com
Subject: Re: [igt-dev] [PATCH i-g-t] tests/i915/drm_fdinfo: Parse compute as well
Date: Tue, 14 Jun 2022 08:08:29 +0100	[thread overview]
Message-ID: <03a4dce4-e4c7-a790-4475-89da70fe9a7d@linux.intel.com> (raw)
In-Reply-To: <20220614004720.45666-1-umesh.nerlige.ramappa@intel.com>


On 14/06/2022 01:47, Nerlige Ramappa, Umesh wrote:
> Parse compute engines as well if available.
> 
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> ---
>   lib/igt_drm_fdinfo.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/lib/igt_drm_fdinfo.c b/lib/igt_drm_fdinfo.c
> index 250d9e89..5beb30b0 100644
> --- a/lib/igt_drm_fdinfo.c
> +++ b/lib/igt_drm_fdinfo.c
> @@ -60,6 +60,7 @@ static int parse_engine(char *line, struct drm_client_fdinfo *info,
>   		"copy",
>   		"video",
>   		"video-enhance",
> +		"compute",
>   	};
>   	ssize_t name_len;
>   	char *name, *p;

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Although note that I have removed this driver specific data from this 
common library in the "driver agnostic gputop" series. So it would be 
good to review that one as well. ;)

Regards,

Tvrtko

  parent reply	other threads:[~2022-06-14  7:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14  0:47 [igt-dev] [PATCH i-g-t] tests/i915/drm_fdinfo: Parse compute as well Nerlige Ramappa, Umesh
2022-06-14  1:12 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
2022-06-14  1:39 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2022-06-14  7:08 ` Tvrtko Ursulin [this message]
2022-06-15  0:08 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=03a4dce4-e4c7-a790-4475-89da70fe9a7d@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=John.C.Harrison@Intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=umesh.nerlige.ramappa@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox