From: "Ser, Simon" <simon.ser@intel.com>
To: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
"chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk>
Subject: Re: [igt-dev] ✗ Fi.CI.IGT: failure for tests/i915/gen_mmap: fix no-op loops
Date: Fri, 31 May 2019 11:52:45 +0000 [thread overview]
Message-ID: <03de815207bbd43d5ee787a277cd034b22f97714.camel@intel.com> (raw)
In-Reply-To: <155930291486.27302.17578743293521523400@skylake-alporthouse-com>
On Fri, 2019-05-31 at 12:41 +0100, Chris Wilson wrote:
> Quoting Ser, Simon (2019-05-31 12:36:26)
> > Hi Martin,
> >
> > On Wed, 2019-05-08 at 09:54 +0000, Ser, Simon wrote:
> > > These failures happen because of:
> > >
> > > (gem_mmap:5289) CRITICAL: Failed assertion: mmap_ioctl(fd, &arg) == -22
> > > (gem_mmap:5289) CRITICAL: error: -2 != -22
> > >
> > > Is this a genuine driver bug? Is the driver supposed to fail with
> > > ENOENT or EINVAL?
> >
> > The authors haven't replied, so could we file a bug for this? Discussed
> > with Arek, the correct sequence of actions would be:
>
> Don't knowingly push a broken test purporting to fix one breakage. The
> test is wrong.
A test that fails is better than a test that silently does nothing. At
least we know it's broken.
> You have git and could have checked that ENOENT was the ABI we settled
> on in
>
> commit bf79cb914dbfe848add8bb76cbb8ff89110d29ff
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date: Wed Aug 4 14:19:46 2010 +0100
>
> drm: Use ENOENT consistently for the error return for an unmatched handle.
>
> This is consistent with trying to access a filename that not exist
> within a directory which is a good analogy here. The main reason for the
> change is that it is easy to confuse the error code of EBADF as an
> performing an ioctl on an invalid file descriptor (rather than an
> unknown object).
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Dave Airlie <airlied@redhat.com>
>
> after being told not to EBADF.
I have absolutely no idea how I could've find this 2010 commit. But,
thanks to your reply, at least I can write a fix now. Thanks!
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-05-31 11:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 12:44 [igt-dev] [PATCH i-g-t] tests/i915/gen_mmap: fix no-op loops Simon Ser
2019-05-07 13:54 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-05-07 14:31 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
2019-05-07 15:10 ` Ser, Simon
2019-05-08 11:27 ` Jani Nikula
2019-05-07 18:42 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
2019-05-08 9:54 ` Ser, Simon
2019-05-20 6:26 ` Ser, Simon
2019-05-27 15:25 ` Ser, Simon
2019-05-31 11:36 ` Ser, Simon
2019-05-31 11:41 ` Chris Wilson
2019-05-31 11:52 ` Ser, Simon [this message]
2019-06-03 15:18 ` Daniel Vetter
2019-05-10 15:39 ` [igt-dev] [PATCH i-g-t] " Antonio Argenziano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03de815207bbd43d5ee787a277cd034b22f97714.camel@intel.com \
--to=simon.ser@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox