Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Bernatowicz, Marcin" <marcin.bernatowicz@linux.intel.com>
To: "Piórkowski, Piotr" <piotr.piorkowski@intel.com>,
	igt-dev@lists.freedesktop.org
Cc: Peter Senna Tschudin <peter.senna@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH v1 1/5] lib/igt_dir: Allow scanning only the current directory
Date: Wed, 19 Nov 2025 15:32:07 +0100	[thread overview]
Message-ID: <03df45fa-df3f-44c7-a79e-2873b42db834@linux.intel.com> (raw)
In-Reply-To: <20251113114615.3736269-2-piotr.piorkowski@intel.com>


On 11/13/2025 12:46 PM, Piórkowski, Piotr wrote:
> From: Piotr Piórkowski <piotr.piorkowski@intel.com>
>
> The check rejecting scan_maxdepth == 0 prevented callers from
> scanning only the current directory without descending into subdirectories.
> Let's remov this restriction to enable using scan_maxdepth = 0 as a valid
> mode to list entries in the top-level directory only.
>
> Signed-off-by: Piotr Piórkowski <piotr.piorkowski@intel.com>
> Cc: Peter Senna Tschudin <peter.senna@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>   lib/igt_dir.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/lib/igt_dir.c b/lib/igt_dir.c
> index e232dbda9c..6ef8e859a4 100644
> --- a/lib/igt_dir.c
> +++ b/lib/igt_dir.c
> @@ -241,7 +241,6 @@ int igt_dir_scan_dirfd(igt_dir_t *config, int scan_maxdepth)
>   	igt_require(config->root_path);
>   	igt_require(config->dirfd >= 0);
>   	igt_require(scan_maxdepth >= -1);
> -	igt_require(scan_maxdepth != 0);

LGTM,

Reviewed-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>

>   
>   	/* If the linked list is not empty, clean it first */
>   	if (!igt_list_empty(&config->file_list_head)) {

  reply	other threads:[~2025-11-19 14:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-13 11:46 [PATCH v1 0/5] Redesign of the xe_debugfs test Piórkowski, Piotr
2025-11-13 11:46 ` [PATCH v1 1/5] lib/igt_dir: Allow scanning only the current directory Piórkowski, Piotr
2025-11-19 14:32   ` Bernatowicz, Marcin [this message]
2025-11-13 11:46 ` [PATCH v1 2/5] lib/debugfs: Add debugfs helpers to open tile directory Piórkowski, Piotr
2025-11-20  9:10   ` Bernatowicz, Marcin
2025-11-13 11:46 ` [PATCH v1 3/5] tests/intel/debugfs: Rewrite tests to use array-based required debugfs file lists Piórkowski, Piotr
2025-11-20  8:58   ` Bernatowicz, Marcin
2025-11-13 11:46 ` [PATCH v1 4/5] tests/intel/debugfs: Add tile-dir subtest for per-tile debugfs validation Piórkowski, Piotr
2025-11-20  9:21   ` Bernatowicz, Marcin
2025-11-13 11:46 ` [PATCH v1 5/5] tests/intel/debugfs: Move VRAM MM checks from root to tile-dir validation Piórkowski, Piotr
2025-11-13 21:14 ` ✗ Xe.CI.BAT: failure for Redesign of the xe_debugfs test Patchwork
2025-11-13 23:45 ` ✓ i915.CI.BAT: success " Patchwork
2025-11-14  4:46 ` ✗ Xe.CI.Full: failure " Patchwork
2025-11-14 17:59 ` ✗ i915.CI.Full: " Patchwork
2025-11-18 16:56 ` [PATCH v1 0/5] " Peter Senna Tschudin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=03df45fa-df3f-44c7-a79e-2873b42db834@linux.intel.com \
    --to=marcin.bernatowicz@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=peter.senna@linux.intel.com \
    --cc=piotr.piorkowski@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox