From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: References: <20190322092155.1656-1-chris@chris-wilson.co.uk> <20190322092155.1656-14-chris@chris-wilson.co.uk> From: Tvrtko Ursulin Message-ID: <04567631-3334-b3b9-7325-88db96058216@linux.intel.com> Date: Tue, 26 Mar 2019 10:46:30 +0000 MIME-Version: 1.0 In-Reply-To: <20190322092155.1656-14-chris@chris-wilson.co.uk> Content-Language: en-US Subject: Re: [igt-dev] [PATCH i-g-t 14/24] i915/gem_ctx_create: Basic checks for constructor properties List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: igt-dev@lists.freedesktop.org List-ID: Ck9uIDIyLzAzLzIwMTkgMDk6MjEsIENocmlzIFdpbHNvbiB3cm90ZToKPiBDaGVjayB0aGF0IHRo ZSBleHRlbmRlZCBjcmVhdGUgaW50ZXJmYWNlIGFjY2VwdHMgc2V0cGFyYW0uCj4gCj4gU2lnbmVk LW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gLS0tCj4g ICB0ZXN0cy9pOTE1L2dlbV9jdHhfY3JlYXRlLmMgfCA1NyArKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrCj4gICAxIGZpbGUgY2hhbmdlZCwgNTcgaW5zZXJ0aW9ucygrKQo+IAo+ IGRpZmYgLS1naXQgYS90ZXN0cy9pOTE1L2dlbV9jdHhfY3JlYXRlLmMgYi90ZXN0cy9pOTE1L2dl bV9jdHhfY3JlYXRlLmMKPiBpbmRleCBhNjY0MDcwZGIuLmUxMmY0MTY5MSAxMDA2NDQKPiAtLS0g YS90ZXN0cy9pOTE1L2dlbV9jdHhfY3JlYXRlLmMKPiArKysgYi90ZXN0cy9pOTE1L2dlbV9jdHhf Y3JlYXRlLmMKPiBAQCAtMzA4LDYgKzMwOCw2MCBAQCBzdGF0aWMgdm9pZCBtYXhpbXVtKGludCBm ZCwgaW50IG5jcHVzLCB1bnNpZ25lZCBtb2RlKQo+ICAgCWZyZWUoY29udGV4dHMpOwo+ICAgfQo+ ICAgCj4gK3N0YXRpYyBpbnQgX19jcmVhdGVfZXh0KGludCBpOTE1LCBzdHJ1Y3QgZHJtX2k5MTVf Z2VtX2NvbnRleHRfY3JlYXRlX2V4dCAqYXJnKQo+ICt7Cj4gKwlpbnQgZXJyOwo+ICsKPiArCWVy ciA9IDA7Cj4gKwlpZiAoaWd0X2lvY3RsKGk5MTUsIERSTV9JT0NUTF9JOTE1X0dFTV9DT05URVhU X0NSRUFURV9FWFQsIGFyZykpCj4gKwkJZXJyID0gLWVycm5vOwo+ICsKPiArCWVycm5vID0gMDsK PiArCXJldHVybiBlcnI7Cj4gK30KPiArCj4gK3N0YXRpYyB2b2lkIGJhc2ljX2V4dF9wYXJhbShp bnQgaTkxNSkKPiArewo+ICsJc3RydWN0IGRybV9pOTE1X2dlbV9jb250ZXh0X2NyZWF0ZV9leHRf c2V0cGFyYW0gZXh0ID0gewo+ICsJCXsgLm5hbWUgPSBJOTE1X0NPTlRFWFRfQ1JFQVRFX0VYVF9T RVRQQVJBTSB9LAo+ICsJfTsKPiArCXN0cnVjdCBkcm1faTkxNV9nZW1fY29udGV4dF9jcmVhdGVf ZXh0IGNyZWF0ZSA9IHsKPiArCQkuZmxhZ3MgPSBJOTE1X0NPTlRFWFRfQ1JFQVRFX0ZMQUdTX1VT RV9FWFRFTlNJT05TCj4gKwl9Owo+ICsJc3RydWN0IGRybV9pOTE1X2dlbV9jb250ZXh0X3BhcmFt IGdldDsKPiArCj4gKwlpZ3RfcmVxdWlyZShfX2NyZWF0ZV9leHQoaTkxNSwgJmNyZWF0ZSkgPT0g MCk7Cj4gKwlnZW1fY29udGV4dF9kZXN0cm95KGk5MTUsIGNyZWF0ZS5jdHhfaWQpOwo+ICsKPiAr CWNyZWF0ZS5leHRlbnNpb25zID0gLTF1bGw7Cj4gKwlpZ3RfYXNzZXJ0X2VxKF9fY3JlYXRlX2V4 dChpOTE1LCAmY3JlYXRlKSwgLUVGQVVMVCk7Cj4gKwo+ICsJY3JlYXRlLmV4dGVuc2lvbnMgPSB0 b191c2VyX3BvaW50ZXIoJmV4dCk7Cj4gKwlpZ3RfYXNzZXJ0X2VxKF9fY3JlYXRlX2V4dChpOTE1 LCAmY3JlYXRlKSwgLUVJTlZBTCk7Cj4gKwo+ICsJZXh0LnBhcmFtLnBhcmFtID0gSTkxNV9DT05U RVhUX1BBUkFNX1BSSU9SSVRZOwo+ICsJaWYgKF9fY3JlYXRlX2V4dChpOTE1LCAmY3JlYXRlKSAh PSAtRU5PREVWKSB7CgpBbHRlcm5hdGl2ZWx5IHNwbGl0IGludG8gdHdvIHN1YnRlc3RzLCBvbmUg dG8gdGVzdCBpbnZhbGlkIGFuZCB1cCB0byAKaGVyZSwgYW5kIHNlY29uZCBvbmUgdG8gdGVzdCB0 aGUgcmVzdCBhbmQgdXNlIGlndF9yZXF1aXJlKC4uLiAhPSBFTk9ERVYpIApzbyBjYW4gc2tpcCB3 aGVyZSBwcmlvcml0eSBpcyBub3Qgc3VwcG9ydGVkLgoKQWN0dWFsbHkgY291bGQgYWxzbyB1c2Ug d2l0aCBzb21lIG1vcmUgYmFzaWMgcGFyYW0gd2hpY2ggaGFzIG5vIEVOT0RFViBwYXRoLgoKPiAr CQlnZW1fY29udGV4dF9kZXN0cm95KGk5MTUsIGNyZWF0ZS5jdHhfaWQpOwo+ICsKPiArCQlleHQu YmFzZS5uZXh0X2V4dGVuc2lvbiA9IC0xdWxsOwo+ICsJCWlndF9hc3NlcnRfZXEoX19jcmVhdGVf ZXh0KGk5MTUsICZjcmVhdGUpLCAtRUZBVUxUKTsKPiArCQlleHQuYmFzZS5uZXh0X2V4dGVuc2lv biA9IHRvX3VzZXJfcG9pbnRlcigmZXh0KTsKPiArCQlpZ3RfYXNzZXJ0X2VxKF9fY3JlYXRlX2V4 dChpOTE1LCAmY3JlYXRlKSwgLUUyQklHKTsKPiArCQlleHQuYmFzZS5uZXh0X2V4dGVuc2lvbiA9 IDA7CgpUaGVzZSB0d28gY2FuIHRoZW4gYWxzbyBiZSBjb3VwbGVkIGZyb20gQ0FQX1NDSEVEVUxF UiBpbnRvIHRoZSBmaXJzdCAKc3VidGVzdC4KCj4gKwo+ICsJCWV4dC5wYXJhbS52YWx1ZSA9IDMy OwoKV2h5IDMyPyBBZGQgY29tbWVudCBsaWtlIC8qIHJhbmRvbSBub24tZGVmYXVsdCBwcmlvcml0 eSBsZXZlbCAqLwoKRm9yIGNvbXBsZXRlIGZ1dHVyZSBwcm9vZmluZyBzaG91bGQgcHJvYmFibHkg cXVlcnkgaXQgZmlyc3QgdG8gYXNzZXJ0IGl0IAppcyB1bnVzZWQuCgpBbHRob3VnaCBhZ2FpbiBp ZiB5b3UgdXNlZCBzb21ldGhpbmcgbGlrZSBiYW5uYWJsZSBpdCBjb3VsZCBydW4gb24gYWxsIApw bGF0Zm9ybXMgQUZBSUNTLgoKPiArCQlpZ3RfYXNzZXJ0X2VxKF9fY3JlYXRlX2V4dChpOTE1LCAm Y3JlYXRlKSwgMCk7Cj4gKwo+ICsJCW1lbXNldCgmZ2V0LCAwLCBzaXplb2YoZ2V0KSk7Cj4gKwkJ Z2V0LmN0eF9pZCA9IGNyZWF0ZS5jdHhfaWQ7Cj4gKwkJZ2V0LnBhcmFtID0gSTkxNV9DT05URVhU X1BBUkFNX1BSSU9SSVRZOwo+ICsJCWdlbV9jb250ZXh0X2dldF9wYXJhbShpOTE1LCAmZ2V0KTsK PiArCQlpZ3RfYXNzZXJ0X2VxKGdldC52YWx1ZSwgZXh0LnBhcmFtLnZhbHVlKTsKPiArCj4gKwkJ Z2VtX2NvbnRleHRfZGVzdHJveShpOTE1LCBjcmVhdGUuY3R4X2lkKTsKPiArCX0KPiArfQo+ICsK PiAgIGlndF9tYWluCj4gICB7Cj4gICAJY29uc3QgaW50IG5jcHVzID0gc3lzY29uZihfU0NfTlBS T0NFU1NPUlNfT05MTik7Cj4gQEAgLTM1Miw2ICs0MDYsOSBAQCBpZ3RfbWFpbgo+ICAgCQlpZ3Rf YXNzZXJ0X2VxKF9fZ2VtX2NvbnRleHRfY3JlYXRlX2xvY2FsKGZkLCAmY3JlYXRlKSwgLUVJTlZB TCk7Cj4gICAJfQo+ICAgCj4gKwlpZ3Rfc3VidGVzdCgiZXh0LXBhcmFtIikKPiArCQliYXNpY19l eHRfcGFyYW0oZmQpOwo+ICsKPiAgIAlpZ3Rfc3VidGVzdCgibWF4aW11bS1tZW0iKQo+ICAgCQlt YXhpbXVtKGZkLCBuY3B1cywgQ0hFQ0tfUkFNKTsKPiAgIAlpZ3Rfc3VidGVzdCgibWF4aW11bS1z d2FwIikKPiAKClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pZ3QtZGV2