Re: [PATCH i-g-t] tests/intel/xe_huc_copy: Enhance HuC status check for VF mode

[Adam Miszczak <adam.miszczak@linux.intel.com>]

On 12.08.2024 20:08, Marcin Bernatowicz wrote:
> Extend the is_huc_running function to check for both 'RUNNING' and
> 'PRELOADED' statuses. This adjustment ensures that firmware loading
> by the PF driver is accurately recognized when operating in Virtual
> Function (VF) mode.
>
> Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2466
>
> Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
> Cc: Michal Wajdeczko <Michal.Wajdeczko@intel.com>
> Cc: Michał Winiarski <michal.winiarski@intel.com>
> Cc: Lukasz Laguna <lukasz.laguna@intel.com>
> Cc: Jakub Kolakowski <jakub1.kolakowski@intel.com>
> ---
>   tests/intel/xe_huc_copy.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/tests/intel/xe_huc_copy.c b/tests/intel/xe_huc_copy.c
> index 6d8ca0776..c8b5efc7b 100644
> --- a/tests/intel/xe_huc_copy.c
> +++ b/tests/intel/xe_huc_copy.c
> @@ -177,7 +177,6 @@ static bool
>   is_huc_running(int fd)
>   {
>   	char buf[4096];
> -	char *s;
>   	int gt;
>   
>   	xe_for_each_gt(fd, gt) {
> @@ -185,9 +184,8 @@ is_huc_running(int fd)
>   
>   		sprintf(name, "gt%d/uc/huc_info", gt);
>   		igt_debugfs_read(fd, name, buf);
> -		s = strstr(buf, "RUNNING");
>   
> -		if (s)
> +		if (strstr(buf, "RUNNING") || strstr(buf, "PRELOADED"))
>   			return true;

LGTM,
Acked-by: Adam Miszczak <adam.miszczak@linux.intel.com>

>   	}
>   	return false;