Re: [PATCH i-g-t 1/1] tests/intel/kms_psr: Add condition to check for eDP output before asserting PSR update

["Hogander, Jouni" <jouni.hogander@intel.com>]

On Wed, 2024-09-04 at 01:29 +0530, Naladala Ramanaidu wrote:
> We do not have ALPM on the DP2.1 Panel Replay. Due to this, the
> SRD_STATUS [SRD State] doesn't change from SRDENT_ON after Panel
> Replay is enabled until it gets disabled. As a result, the igt
> tests fail. To resolve this issue, add a condition to skip the
> check in the 'psr_wait_update_if_enabled' function for DP2.1 PR.
> 
> Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
> ---
>  tests/intel/kms_psr.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/intel/kms_psr.c b/tests/intel/kms_psr.c
> index cf0ce4bb8..8671f33ea 100644
> --- a/tests/intel/kms_psr.c
> +++ b/tests/intel/kms_psr.c
> @@ -642,7 +642,8 @@ static void run_test(data_t *data)
>                 expected = "screen GREEN";
>                 break;
>         }
> -       igt_assert(psr_wait_update_if_enabled(data));
> +       if (strstr(data->output->name, "eDP-") != NULL)
> +               igt_assert(psr_wait_update_if_enabled(data));

I think better solution would be to solve this for all users of
psr_wait_update/psr_long_wait_update. I.e. in igt_psr.c. Please also
add TODO disclaimer there.

Another thing: I think better to use  output->config.connector-
>connector_type rather than output->name.

BR,

Jouni Högander

>         manual(expected);
>  }
>