Re: [igt-dev] [PATCH i-g-t 10/10] tools/intel_watermark: Decode SAGV WM usage correctly on ADL+

Govindapillai, Vinod
2023-02-06T11:41:07Z

On Wed, 2023-01-25 at 06:55 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The LP6 bit in WM_DBG has become the SAGV bit on ADL+. Decode
> it correctly.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---

Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com>

>  tools/intel_watermark.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tools/intel_watermark.c b/tools/intel_watermark.c
> index e598cf122159..115ae8b2ad19 100644
> --- a/tools/intel_watermark.c
> +++ b/tools/intel_watermark.c
> @@ -625,6 +625,8 @@ static void skl_wm_dump(void)
>                 if (wm_dbg & (1 << (23 + level)))
>                         printf(" LP%d", level);
>         }
> +       if (skl_has_sagv_wm(devid) && wm_dbg & (1 << 29))
> +               printf(" SAGV");
>         printf("\n");
>         /* clear the sticky bits */
>         write_reg(0x45280, wm_dbg);