Re: [igt-dev] [PATCH i-g-t 01/10] tools/intel_watermark: Add missing intel_register_access_fini() for skl+

Govindapillai, Vinod
2023-02-06T08:13:04Z

On Wed, 2023-01-25 at 06:55 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The skl+ code forgot to call intel_register_access_fini(). Make
> it do so.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com>

> ---
>  tools/intel_watermark.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tools/intel_watermark.c b/tools/intel_watermark.c
> index 1e235ed30a63..1818d79d0bee 100644
> --- a/tools/intel_watermark.c
> +++ b/tools/intel_watermark.c
> @@ -590,6 +590,8 @@ static void skl_wm_dump(void)
>         printf("\n");
>         /* clear the sticky bits */
>         write_reg(0x45280, wm_dbg);
> +
> +       intel_register_access_fini(&mmio_data);
>  }
>
>  static void ilk_wm_dump(void)