public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH i-g-t] tests/kms_plane: Optimize modifier check for unsupported platforms
@ 2026-02-17  5:56 Pranay Samala
  2026-02-17 12:29 ` ✓ Xe.CI.BAT: success for " Patchwork
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Pranay Samala @ 2026-02-17  5:56 UTC (permalink / raw)
  To: igt-dev; +Cc: karthik.b.s, sameer.lattannavar, pranay.samala

Optimize the modifier check by moving it outside the CRTC/Output loop.
This avoids redundancy and ensures the test is cleanly skipped.

Fixes: a4805b36cf23 ("tests/kms_plane: Skip unsupported modifiers")
Signed-off-by: Pranay Samala <pranay.samala@intel.com>
---
 tests/kms_plane.c | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/tests/kms_plane.c b/tests/kms_plane.c
index 362748cdb..f37b019d1 100644
--- a/tests/kms_plane.c
+++ b/tests/kms_plane.c
@@ -1489,18 +1489,14 @@ static void run_test(data_t *data, void (*test)(data_t *, enum pipe))
 	igt_crtc_t *crtc;
 	int count = 0;
 
+	igt_skip_on_f(((data->flags & TEST_PIXEL_FORMAT) &&
+		       !igt_display_has_format_mod(&data->display,
+		       DRM_FORMAT_XBGR8888, data->mod)),
+		       "Skipping: Modifier " IGT_MODIFIER_FMT
+		       " is not supported on this platform\n",
+		       IGT_MODIFIER_ARGS(data->mod));
+
 	for_each_crtc_with_single_output(&data->display, crtc, data->output) {
-		if ((data->flags & TEST_PIXEL_FORMAT) &&
-		    !igt_display_has_format_mod(&data->display,
-						DRM_FORMAT_XBGR8888,
-						data->mod)) {
-			igt_info("Skipping: Modifier " IGT_MODIFIER_FMT
-				 " is not supported on pipe %s, output %s\n",
-				 IGT_MODIFIER_ARGS(data->mod),
-				 kmstest_pipe_name(crtc->pipe),
-				 igt_output_name(data->output));
-			continue;
-		}
 
 		igt_display_reset(&data->display);
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-02-18  3:57 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-17  5:56 [PATCH i-g-t] tests/kms_plane: Optimize modifier check for unsupported platforms Pranay Samala
2026-02-17 12:29 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-02-17 12:37 ` ✓ i915.CI.BAT: " Patchwork
2026-02-17 13:47 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-02-17 15:23 ` ✗ i915.CI.Full: " Patchwork
2026-02-18  3:57 ` [PATCH i-g-t] " Karthik B S

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox