Re: [PATCH i-g-t v4] tests/kms_3d: Add more logs to skips/failure

["Modem, Bhanuprakash" <bhanuprakash.modem@intel.com>]

On 29-08-2024 12:22 pm, Pranay Samala wrote:
> Having some logs for test failures and skips would
> make debugging much easier.
> 
> Signed-off-by: Pranay Samala <pranay.samala@intel.com>

Reviewed-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>

> ---
>   tests/kms_3d.c | 13 +++++++++----
>   1 file changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/kms_3d.c b/tests/kms_3d.c
> index ad6c45e9b..f1726b71e 100644
> --- a/tests/kms_3d.c
> +++ b/tests/kms_3d.c
> @@ -55,7 +55,8 @@ igt_simple_main
>   	res = drmModeGetResources(drm_fd);
>   	igt_require(res);
>   
> -	igt_assert(drmSetClientCap(drm_fd, DRM_CLIENT_CAP_STEREO_3D, 1) >= 0);
> +	igt_assert_f(drmSetClientCap(drm_fd, DRM_CLIENT_CAP_STEREO_3D, 1) >= 0,
> +		     "Failed to enable STEREO_3D capability.\n");
>   
>   	/* find an hdmi connector */
>   	for (int i = 0; i < res->count_connectors; i++) {
> @@ -65,7 +66,7 @@ igt_simple_main
>   		drmModeFreeConnector(connector);
>   		connector = NULL;
>   	}
> -	igt_require(connector);
> +	igt_require_f(connector, "No HDMI connector found.\n");
>   
>   	kmstest_unset_all_crtcs(drm_fd, res);
>   
> @@ -85,7 +86,7 @@ igt_simple_main
>   			mode_count++;
>   	}
>   
> -	igt_assert(mode_count);
> +	igt_assert_f(mode_count, "3D modes not detected.\n");
>   
>   	/* set 3D modes */
>   	igt_info("Testing:\n");
> @@ -95,8 +96,12 @@ igt_simple_main
>   		int crtc_mask = -1;
>   		int ret;
>   
> -		if (!(connector->modes[i].flags & DRM_MODE_FLAG_3D_MASK))
> +		if (!(connector->modes[i].flags & DRM_MODE_FLAG_3D_MASK)) {
> +			igt_info("%s-%d: Doesn't support 3D MASK.\n",
> +				 kmstest_connector_type_str(connector->connector_type),
> +				 connector->connector_type_id);
>   			continue;
> +		}
>   
>   		/* create a configuration */
>   		ret = kmstest_get_connector_config(drm_fd, connector_id,