From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mslow2.mail.gandi.net (mslow2.mail.gandi.net [217.70.178.242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2C3016E11B for ; Tue, 5 Feb 2019 13:04:46 +0000 (UTC) Received: from relay11.mail.gandi.net (unknown [217.70.178.231]) by mslow2.mail.gandi.net (Postfix) with ESMTP id E2B743A24C9 for ; Tue, 5 Feb 2019 13:52:54 +0100 (CET) Message-ID: <074bc34df3c51f1ba18f0be5ef1df3a0e4e9f652.camel@bootlin.com> From: Paul Kocialkowski Date: Tue, 05 Feb 2019 13:52:29 +0100 In-Reply-To: <20190125145842.15738-2-maxime.ripard@bootlin.com> References: <20190125145842.15738-1-maxime.ripard@bootlin.com> <20190125145842.15738-2-maxime.ripard@bootlin.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t v5 01/13] igt: fb: Add subsampling parameters to the formats List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Maxime Ripard , igt-dev@lists.freedesktop.org Cc: Petri Latvala , eben@raspberrypi.org, Thomas Petazzoni List-ID: SGksCgpPbiBGcmksIDIwMTktMDEtMjUgYXQgMTU6NTggKzAxMDAsIE1heGltZSBSaXBhcmQgd3Jv dGU6Cj4gSW4gb3JkZXIgdG8gaW1wcm92ZSB0aGUgWVVWIHN1cHBvcnQsIGxldCdzIGFkZCB0aGUg aG9yaXpvbnRhbCBhbmQgdmVydGljYWwKPiBzdWJzYW1wbGluZyBwYXJhbWV0ZXJzIHRvIHRoZSBJ R1QgZm9ybWF0cy4KClB1c2hlZCwgdGhhbmtzIQoKQ2hlZXJzLAoKUGF1bAoKPiBSZXZpZXdlZC1i eTogUGF1bCBLb2NpYWxrb3dza2kgPHBhdWwua29jaWFsa293c2tpQGJvb3RsaW4uY29tPgo+IFNp Z25lZC1vZmYtYnk6IE1heGltZSBSaXBhcmQgPG1heGltZS5yaXBhcmRAYm9vdGxpbi5jb20+Cj4g LS0tCj4gIGxpYi9pZ3RfZmIuYyB8IDM1ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0t LS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyOSBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+ IAo+IGRpZmYgLS1naXQgYS9saWIvaWd0X2ZiLmMgYi9saWIvaWd0X2ZiLmMKPiBpbmRleCA1Y2Qx ODI5YTNjZTQuLmUyMzkwOGUyOGMwNyAxMDA2NDQKPiAtLS0gYS9saWIvaWd0X2ZiLmMKPiArKysg Yi9saWIvaWd0X2ZiLmMKPiBAQCAtNzEsODUgKzcxLDEwNCBAQCBzdGF0aWMgY29uc3Qgc3RydWN0 IGZvcm1hdF9kZXNjX3N0cnVjdCB7Cj4gIAlpbnQgZGVwdGg7Cj4gIAlpbnQgbnVtX3BsYW5lczsK PiAgCWludCBwbGFuZV9icHBbNF07Cj4gKwl1aW50OF90IGhzdWI7Cj4gKwl1aW50OF90IHZzdWI7 Cj4gIH0gZm9ybWF0X2Rlc2NbXSA9IHsKPiAgCXsgLm5hbWUgPSAiQVJHQjE1NTUiLCAuZGVwdGgg PSAtMSwgLmRybV9pZCA9IERSTV9GT1JNQVRfQVJHQjE1NTUsCj4gIAkgIC5jYWlyb19pZCA9IENB SVJPX0ZPUk1BVF9JTlZBTElELAo+ICAJICAucGl4bWFuX2lkID0gUElYTUFOX2ExcjVnNWI1LAo+ ICAJICAubnVtX3BsYW5lcyA9IDEsIC5wbGFuZV9icHAgPSB7IDE2LCB9LAo+ICsJICAuaHN1YiA9 IDEsIC52c3ViID0gMSwKPiAgCX0sCj4gIAl7IC5uYW1lID0gIlhSR0IxNTU1IiwgLmRlcHRoID0g LTEsIC5kcm1faWQgPSBEUk1fRk9STUFUX1hSR0IxNTU1LAo+ICAJICAuY2Fpcm9faWQgPSBDQUlS T19GT1JNQVRfSU5WQUxJRCwKPiAgCSAgLnBpeG1hbl9pZCA9IFBJWE1BTl94MXI1ZzViNSwKPiAg CSAgLm51bV9wbGFuZXMgPSAxLCAucGxhbmVfYnBwID0geyAxNiwgfSwKPiArCSAgLmhzdWIgPSAx LCAudnN1YiA9IDEsCj4gIAl9LAo+ICAJeyAubmFtZSA9ICJSR0I1NjUiLCAuZGVwdGggPSAxNiwg LmRybV9pZCA9IERSTV9GT1JNQVRfUkdCNTY1LAo+ICAJICAuY2Fpcm9faWQgPSBDQUlST19GT1JN QVRfUkdCMTZfNTY1LAo+ICAJICAucGl4bWFuX2lkID0gUElYTUFOX3I1ZzZiNSwKPiAgCSAgLm51 bV9wbGFuZXMgPSAxLCAucGxhbmVfYnBwID0geyAxNiwgfSwKPiArCSAgLmhzdWIgPSAxLCAudnN1 YiA9IDEsCj4gIAl9LAo+ICAJeyAubmFtZSA9ICJCR1I1NjUiLCAuZGVwdGggPSAtMSwgLmRybV9p ZCA9IERSTV9GT1JNQVRfQkdSNTY1LAo+ICAJICAuY2Fpcm9faWQgPSBDQUlST19GT1JNQVRfSU5W QUxJRCwKPiAgCSAgLnBpeG1hbl9pZCA9IFBJWE1BTl9iNWc2cjUsCj4gIAkgIC5udW1fcGxhbmVz ID0gMSwgLnBsYW5lX2JwcCA9IHsgMTYsIH0sCj4gKwkgIC5oc3ViID0gMSwgLnZzdWIgPSAxLAo+ ICAJfSwKPiAgCXsgLm5hbWUgPSAiQkdSODg4IiwgLmRlcHRoID0gLTEsIC5kcm1faWQgPSBEUk1f Rk9STUFUX0JHUjg4OCwKPiAgCSAgLmNhaXJvX2lkID0gQ0FJUk9fRk9STUFUX0lOVkFMSUQsCj4g IAkgIC5waXhtYW5faWQgPSBQSVhNQU5fYjhnOHI4LAo+ICAJICAubnVtX3BsYW5lcyA9IDEsIC5w bGFuZV9icHAgPSB7IDI0LCB9LAo+ICsJICAuaHN1YiA9IDEsIC52c3ViID0gMSwKPiAgCX0sCj4g IAl7IC5uYW1lID0gIlJHQjg4OCIsIC5kZXB0aCA9IC0xLCAuZHJtX2lkID0gRFJNX0ZPUk1BVF9S R0I4ODgsCj4gIAkgIC5jYWlyb19pZCA9IENBSVJPX0ZPUk1BVF9JTlZBTElELAo+ICAJICAucGl4 bWFuX2lkID0gUElYTUFOX3I4ZzhiOCwKPiAgCSAgLm51bV9wbGFuZXMgPSAxLCAucGxhbmVfYnBw ID0geyAyNCwgfSwKPiArCSAgLmhzdWIgPSAxLCAudnN1YiA9IDEsCj4gIAl9LAo+ICAJeyAubmFt ZSA9ICJYWVVWODg4OCIsIC5kZXB0aCA9IC0xLCAuZHJtX2lkID0gRFJNX0ZPUk1BVF9YWVVWODg4 OCwKPiAgCSAgLmNhaXJvX2lkID0gQ0FJUk9fRk9STUFUX1JHQjI0LAo+ICAJICAubnVtX3BsYW5l cyA9IDEsIC5wbGFuZV9icHAgPSB7IDMyLCB9LAo+ICsJICAuaHN1YiA9IDEsIC52c3ViID0gMSwK PiAgCX0sCj4gIAl7IC5uYW1lID0gIlhSR0I4ODg4IiwgLmRlcHRoID0gMjQsIC5kcm1faWQgPSBE Uk1fRk9STUFUX1hSR0I4ODg4LAo+ICAJICAuY2Fpcm9faWQgPSBDQUlST19GT1JNQVRfUkdCMjQs Cj4gIAkgIC5waXhtYW5faWQgPSBQSVhNQU5feDhyOGc4YjgsCj4gIAkgIC5udW1fcGxhbmVzID0g MSwgLnBsYW5lX2JwcCA9IHsgMzIsIH0sCj4gKwkgIC5oc3ViID0gMSwgLnZzdWIgPSAxLAo+ICAJ fSwKPiAgCXsgLm5hbWUgPSAiWEJHUjg4ODgiLCAuZGVwdGggPSAtMSwgLmRybV9pZCA9IERSTV9G T1JNQVRfWEJHUjg4ODgsCj4gIAkgIC5jYWlyb19pZCA9IENBSVJPX0ZPUk1BVF9JTlZBTElELAo+ ICAJICAucGl4bWFuX2lkID0gUElYTUFOX3g4YjhnOHI4LAo+ICAJICAubnVtX3BsYW5lcyA9IDEs IC5wbGFuZV9icHAgPSB7IDMyLCB9LAo+ICsJICAuaHN1YiA9IDEsIC52c3ViID0gMSwKPiAgCX0s Cj4gIAl7IC5uYW1lID0gIlhSR0IyMTAxMDEwIiwgLmRlcHRoID0gMzAsIC5kcm1faWQgPSBEUk1f Rk9STUFUX1hSR0IyMTAxMDEwLAo+ICAJICAuY2Fpcm9faWQgPSBDQUlST19GT1JNQVRfUkdCMzAs Cj4gIAkgIC5waXhtYW5faWQgPSBQSVhNQU5feDJyMTBnMTBiMTAsCj4gIAkgIC5udW1fcGxhbmVz ID0gMSwgLnBsYW5lX2JwcCA9IHsgMzIsIH0sCj4gKwkgIC5oc3ViID0gMSwgLnZzdWIgPSAxLAo+ ICAJfSwKPiAgCXsgLm5hbWUgPSAiQVJHQjg4ODgiLCAuZGVwdGggPSAzMiwgLmRybV9pZCA9IERS TV9GT1JNQVRfQVJHQjg4ODgsCj4gIAkgIC5jYWlyb19pZCA9IENBSVJPX0ZPUk1BVF9BUkdCMzIs Cj4gIAkgIC5waXhtYW5faWQgPSBQSVhNQU5fYThyOGc4YjgsCj4gIAkgIC5udW1fcGxhbmVzID0g MSwgLnBsYW5lX2JwcCA9IHsgMzIsIH0sCj4gKwkgIC5oc3ViID0gMSwgLnZzdWIgPSAxLAo+ICAJ fSwKPiAgCXsgLm5hbWUgPSAiQUJHUjg4ODgiLCAuZGVwdGggPSAtMSwgLmRybV9pZCA9IERSTV9G T1JNQVRfQUJHUjg4ODgsCj4gIAkgIC5jYWlyb19pZCA9IENBSVJPX0ZPUk1BVF9JTlZBTElELAo+ ICAJICAucGl4bWFuX2lkID0gUElYTUFOX2E4YjhnOHI4LAo+ICAJICAubnVtX3BsYW5lcyA9IDEs IC5wbGFuZV9icHAgPSB7IDMyLCB9LAo+ICsJICAuaHN1YiA9IDEsIC52c3ViID0gMSwKPiAgCX0s Cj4gIAl7IC5uYW1lID0gIk5WMTIiLCAuZGVwdGggPSAtMSwgLmRybV9pZCA9IERSTV9GT1JNQVRf TlYxMiwKPiAgCSAgLmNhaXJvX2lkID0gQ0FJUk9fRk9STUFUX1JHQjI0LAo+ICAJICAubnVtX3Bs YW5lcyA9IDIsIC5wbGFuZV9icHAgPSB7IDgsIDE2LCB9LAo+ICsJICAuaHN1YiA9IDIsIC52c3Vi ID0gMiwKPiAgCX0sCj4gIAl7IC5uYW1lID0gIllVWVYiLCAuZGVwdGggPSAtMSwgLmRybV9pZCA9 IERSTV9GT1JNQVRfWVVZViwKPiAgCSAgLmNhaXJvX2lkID0gQ0FJUk9fRk9STUFUX1JHQjI0LAo+ ICAJICAubnVtX3BsYW5lcyA9IDEsIC5wbGFuZV9icHAgPSB7IDE2LCB9LAo+ICsJICAuaHN1YiA9 IDIsIC52c3ViID0gMSwKPiAgCX0sCj4gIAl7IC5uYW1lID0gIllWWVUiLCAuZGVwdGggPSAtMSwg LmRybV9pZCA9IERSTV9GT1JNQVRfWVZZVSwKPiAgCSAgLmNhaXJvX2lkID0gQ0FJUk9fRk9STUFU X1JHQjI0LAo+ICAJICAubnVtX3BsYW5lcyA9IDEsIC5wbGFuZV9icHAgPSB7IDE2LCB9LAo+ICsJ ICAuaHN1YiA9IDIsIC52c3ViID0gMSwKPiAgCX0sCj4gIAl7IC5uYW1lID0gIlVZVlkiLCAuZGVw dGggPSAtMSwgLmRybV9pZCA9IERSTV9GT1JNQVRfVVlWWSwKPiAgCSAgLmNhaXJvX2lkID0gQ0FJ Uk9fRk9STUFUX1JHQjI0LAo+ICAJICAubnVtX3BsYW5lcyA9IDEsIC5wbGFuZV9icHAgPSB7IDE2 LCB9LAo+ICsJICAuaHN1YiA9IDIsIC52c3ViID0gMSwKPiAgCX0sCj4gIAl7IC5uYW1lID0gIlZZ VVkiLCAuZGVwdGggPSAtMSwgLmRybV9pZCA9IERSTV9GT1JNQVRfVllVWSwKPiAgCSAgLmNhaXJv X2lkID0gQ0FJUk9fRk9STUFUX1JHQjI0LAo+ICAJICAubnVtX3BsYW5lcyA9IDEsIC5wbGFuZV9i cHAgPSB7IDE2LCB9LAo+ICsJICAuaHN1YiA9IDIsIC52c3ViID0gMSwKPiAgCX0sCj4gIH07Cj4g ICNkZWZpbmUgZm9yX2VhY2hfZm9ybWF0KGYpCVwKPiBAQCAtMjM5LDEwICsyNTgsMTIgQEAgdm9p ZCBpZ3RfZ2V0X2ZiX3RpbGVfc2l6ZShpbnQgZmQsIHVpbnQ2NF90IHRpbGluZywgaW50IGZiX2Jw cCwKPiAgCj4gIHN0YXRpYyB1bnNpZ25lZCBmYl9wbGFuZV93aWR0aChjb25zdCBzdHJ1Y3QgaWd0 X2ZiICpmYiwgaW50IHBsYW5lKQo+ICB7Cj4gLQlpZiAoZmItPmRybV9mb3JtYXQgPT0gRFJNX0ZP Uk1BVF9OVjEyICYmIHBsYW5lID09IDEpCj4gLQkJcmV0dXJuIERJVl9ST1VORF9VUChmYi0+d2lk dGgsIDIpOwo+ICsJY29uc3Qgc3RydWN0IGZvcm1hdF9kZXNjX3N0cnVjdCAqZm9ybWF0ID0gbG9v a3VwX2RybV9mb3JtYXQoZmItPmRybV9mb3JtYXQpOwo+ICAKPiAtCXJldHVybiBmYi0+d2lkdGg7 Cj4gKwlpZiAocGxhbmUgPT0gMCkKPiArCQlyZXR1cm4gZmItPndpZHRoOwo+ICsKPiArCXJldHVy biBESVZfUk9VTkRfVVAoZmItPndpZHRoLCBmb3JtYXQtPmhzdWIpOwo+ICB9Cj4gIAo+ICBzdGF0 aWMgdW5zaWduZWQgZmJfcGxhbmVfYnBwKGNvbnN0IHN0cnVjdCBpZ3RfZmIgKmZiLCBpbnQgcGxh bmUpCj4gQEAgLTI1NCwxMCArMjc1LDEyIEBAIHN0YXRpYyB1bnNpZ25lZCBmYl9wbGFuZV9icHAo Y29uc3Qgc3RydWN0IGlndF9mYiAqZmIsIGludCBwbGFuZSkKPiAgCj4gIHN0YXRpYyB1bnNpZ25l ZCBmYl9wbGFuZV9oZWlnaHQoY29uc3Qgc3RydWN0IGlndF9mYiAqZmIsIGludCBwbGFuZSkKPiAg ewo+IC0JaWYgKGZiLT5kcm1fZm9ybWF0ID09IERSTV9GT1JNQVRfTlYxMiAmJiBwbGFuZSA9PSAx KQo+IC0JCXJldHVybiBESVZfUk9VTkRfVVAoZmItPmhlaWdodCwgMik7Cj4gKwljb25zdCBzdHJ1 Y3QgZm9ybWF0X2Rlc2Nfc3RydWN0ICpmb3JtYXQgPSBsb29rdXBfZHJtX2Zvcm1hdChmYi0+ZHJt X2Zvcm1hdCk7Cj4gIAo+IC0JcmV0dXJuIGZiLT5oZWlnaHQ7Cj4gKwlpZiAocGxhbmUgPT0gMCkK PiArCQlyZXR1cm4gZmItPmhlaWdodDsKPiArCj4gKwlyZXR1cm4gRElWX1JPVU5EX1VQKGZiLT5o ZWlnaHQsIGZvcm1hdC0+dnN1Yik7Cj4gIH0KPiAgCj4gIHN0YXRpYyBpbnQgZmJfbnVtX3BsYW5l cyhjb25zdCBzdHJ1Y3QgaWd0X2ZiICpmYikKLS0gClBhdWwgS29jaWFsa293c2tpLCBCb290bGlu CkVtYmVkZGVkIExpbnV4IGFuZCBrZXJuZWwgZW5naW5lZXJpbmcKaHR0cHM6Ly9ib290bGluLmNv bQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRl diBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2Cg==