Re: [igt-dev] [i-g-t v5 45/52] tests/i915/kms_flip_tiling: Add support for Bigjoiner

["Modem, Bhanuprakash" <bhanuprakash.modem@intel.com>]

On Fri-23-12-2022 01:41 pm, B, Jeevan wrote:
> 
> 
>> -----Original Message-----
>> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of
>> Bhanuprakash Modem
>> Sent: Tuesday, November 15, 2022 10:39 PM
>> To: igt-dev@lists.freedesktop.org
>> Subject: [igt-dev] [i-g-t v5 45/52] tests/i915/kms_flip_tiling: Add support for
>> Bigjoiner
>>
>> This patch will add a check to Skip the subtest if a selected pipe/output
>> combo won't support Bigjoiner or 8K mode.
>>
>> Example:
>> * Pipe-D wont support a mode > 5K
>> * To use 8K mode on a pipe then consecutive pipe must be available & free.
>>
>> V2: - Use updated helper name
>>
>> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
>> ---
>>   tests/i915/kms_flip_tiling.c | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/tests/i915/kms_flip_tiling.c b/tests/i915/kms_flip_tiling.c index
>> 1183feb6..2e2b9511 100644
>> --- a/tests/i915/kms_flip_tiling.c
>> +++ b/tests/i915/kms_flip_tiling.c
>> @@ -79,6 +79,9 @@ test_flip_tiling(data_t *data, enum pipe pipe,
>> igt_output_t *output, uint64_t mo
>>   	igt_crc_t reference_crc, crc;
>>   	int fb_id, ret;
>>
>> +	igt_info("Using (pipe %s + %s) to run the subtest.\n",
>> +		 kmstest_pipe_name(pipe), igt_output_name(output));
>> +
> 
> Is igt_info required here ??
> igt_dynamic_f has the info already.

Will float a new rev by removing this print.

- Bhanu

>   
>>   	memcpy(&data->old_fb, &data->fb, sizeof(data->fb));
>>
>>   	mode = igt_output_get_mode(output);
>> @@ -195,8 +198,12 @@ igt_main
>>   		for_each_pipe_with_valid_output(&data.display, pipe,
>> output) {
>>   			igt_plane_t *plane;
>>
>> +			igt_display_reset(&data.display);
>>   			pipe_crc_free(&data);
>> +
>>   			igt_output_set_pipe(output, pipe);
>> +			if (!i915_pipe_output_combo_valid(&data.display))
>> +				continue;
>>
>>   			plane = igt_output_get_plane_type(output,
>> DRM_PLANE_TYPE_PRIMARY);
>>
>> --
>> 2.38.0
>