From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5D7A38907C for ; Tue, 29 Jan 2019 20:14:10 +0000 (UTC) Received: by mail-qt1-f195.google.com with SMTP id t33so23745964qtt.4 for ; Tue, 29 Jan 2019 12:14:10 -0800 (PST) Message-ID: <084b022e6b52b5bb2fc1eb94e125e72c3bb9147b.camel@redhat.com> From: Lyude Paul Date: Tue, 29 Jan 2019 15:14:08 -0500 In-Reply-To: <20190125145842.15738-13-maxime.ripard@bootlin.com> References: <20190125145842.15738-1-maxime.ripard@bootlin.com> <20190125145842.15738-13-maxime.ripard@bootlin.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t v5 12/13] igt: tests: chamelium: Convert VGA tests to do_test_display List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Maxime Ripard , igt-dev@lists.freedesktop.org Cc: Petri Latvala , Thomas Petazzoni , eben@raspberrypi.org List-ID: R29vZCB0aGlua2luZyEKClJldmlld2VkLWJ5OiBMeXVkZSBQYXVsIDxseXVkZUByZWRoYXQuY29t PgoKT24gRnJpLCAyMDE5LTAxLTI1IGF0IDE1OjU4ICswMTAwLCBNYXhpbWUgUmlwYXJkIHdyb3Rl Ogo+IFRoZSBWR0EgdGVzdHMgd2VyZSBydW4gc28gZmFyIGFzIHBhcnQgb2YgYSBzZXBhcmF0ZSBm dW5jdGlvbi4gSG93ZXZlciwKPiB0aGUgb25seSBkaWZmZXJlbmNlIGJldHdlZW4gdGhhdCBmdW5j dGlvbiBhbmQgdGhlIGRvX3Rlc3RfZGlzcGxheQo+IGZ1bmN0aW9uIHdhcyB0aGUga2luZCBvZiBj b21wYXJpc29uIHdlIHdhbnRlZCB0byB1c2UuIEluZGVlZCwgVkdBCj4gYmVpbmcgYW4gYW5hbG9n IG91dHB1dCwgd2UgY2FuJ3QgcmVseSBvbiBhIHBpeGVsIHBlcmZlY3QgaW1hZ2UsIGFuZAo+IHRo dXMgb25seSBjb21wYXJlIHRoZSBDUkNzLCBidXQgd2UgbmVlZCB0byBtYWtlIHNvbWUgbW9yZSBh ZHZhbmNlZAo+IGNvbXBhcmlzb24uCj4gCj4gTGV0J3MgYWRkIGEgbmV3IGNoZWNrIG1ldGhvZCwg YWRkIHN1cHBvcnQgZm9yIHRoZSBhbmFsb2cgY2hlY2sgdG8KPiBkb190ZXN0X2Rpc3BsYXkgYW5k IHJlbW92ZSB0aGUgb2xkIHZlcnNpb24uCj4gCj4gUmV2aWV3ZWQtYnk6IFBhdWwgS29jaWFsa293 c2tpIDxwYXVsLmtvY2lhbGtvd3NraUBib290bGluLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBNYXhp bWUgUmlwYXJkIDxtYXhpbWUucmlwYXJkQGJvb3RsaW4uY29tPgo+IC0tLQo+ICB0ZXN0cy9rbXNf Y2hhbWVsaXVtLmMgfCA5MiArKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAzMyBpbnNlcnRpb25zKCspLCA1OSBkZWxldGlvbnMoLSkK PiAKPiBkaWZmIC0tZ2l0IGEvdGVzdHMva21zX2NoYW1lbGl1bS5jIGIvdGVzdHMva21zX2NoYW1l bGl1bS5jCj4gaW5kZXggODIzMGNiODUyY2ZiLi5lYWVhOWMxODgzMmEgMTAwNjQ0Cj4gLS0tIGEv dGVzdHMva21zX2NoYW1lbGl1bS5jCj4gKysrIGIvdGVzdHMva21zX2NoYW1lbGl1bS5jCj4gQEAg LTUyOCw2ICs1MjgsNyBAQCBzdGF0aWMgaW50IGNoYW1lbGl1bV9nZXRfcGF0dGVybl9mYihkYXRh X3QgKmRhdGEsIHNpemVfdAo+IHdpZHRoLCBzaXplX3QgaGVpZ2h0LAo+ICB9Cj4gIAo+ICBlbnVt IGNoYW1lbGl1bV9jaGVjayB7Cj4gKwlDSEFNRUxJVU1fQ0hFQ0tfQU5BTE9HLAo+ICAJQ0hBTUVM SVVNX0NIRUNLX0NSQywKPiAgfTsKPiAgCj4gQEAgLTU3OSw2ICs1ODAsMTggQEAgc3RhdGljIHZv aWQgZG9fdGVzdF9kaXNwbGF5KGRhdGFfdCAqZGF0YSwgc3RydWN0Cj4gY2hhbWVsaXVtX3BvcnQg KnBvcnQsCj4gIAo+ICAJCWZyZWUoZXhwZWN0ZWRfY3JjKTsKPiAgCQlmcmVlKGNyYyk7Cj4gKwl9 IGVsc2UgaWYgKGNoZWNrID09IENIQU1FTElVTV9DSEVDS19BTkFMT0cpIHsKPiArCQlzdHJ1Y3Qg Y2hhbWVsaXVtX2ZyYW1lX2R1bXAgKmR1bXA7Cj4gKwo+ICsJCWlndF9hc3NlcnQoY291bnQgPT0g MSk7Cj4gKwo+ICsJCWR1bXAgPSBjaGFtZWxpdW1fcG9ydF9kdW1wX3BpeGVscyhkYXRhLT5jaGFt ZWxpdW0sIHBvcnQsIDAsIDAsCj4gKwkJCQkJCSAgMCwgMCk7Cj4gKwkJY2hhbWVsaXVtX2Nyb3Bf YW5hbG9nX2ZyYW1lKGR1bXAsIG1vZGUtPmhkaXNwbGF5LAo+ICsJCQkJCSAgICBtb2RlLT52ZGlz cGxheSk7Cj4gKwkJY2hhbWVsaXVtX2Fzc2VydF9hbmFsb2dfZnJhbWVfbWF0Y2hfb3JfZHVtcChk YXRhLT5jaGFtZWxpdW0sCj4gKwkJCQkJCQkgICAgcG9ydCwgZHVtcCwgJmZiKTsKPiArCQljaGFt ZWxpdW1fZGVzdHJveV9mcmFtZV9kdW1wKGR1bXApOwo+ICAJfQo+ICAKPiAgCWlndF9yZW1vdmVf ZmIoZGF0YS0+ZHJtX2ZkLCAmZnJhbWVfZmIpOwo+IEBAIC01ODksOCArNjAyLDkgQEAgc3RhdGlj IHZvaWQgdGVzdF9kaXNwbGF5X29uZV9tb2RlKGRhdGFfdCAqZGF0YSwgc3RydWN0Cj4gY2hhbWVs aXVtX3BvcnQgKnBvcnQsCj4gIAkJCQkgIHVpbnQzMl90IGZvdXJjYywgZW51bSBjaGFtZWxpdW1f Y2hlY2sgY2hlY2ssCj4gIAkJCQkgIGludCBjb3VudCkKPiAgewo+IC0JaWd0X291dHB1dF90ICpv dXRwdXQ7Cj4gIAlkcm1Nb2RlQ29ubmVjdG9yICpjb25uZWN0b3I7Cj4gKwlkcm1Nb2RlTW9kZUlu Zm8gKm1vZGU7Cj4gKwlpZ3Rfb3V0cHV0X3QgKm91dHB1dDsKPiAgCWlndF9wbGFuZV90ICpwcmlt YXJ5Owo+ICAKPiAgCXJlc2V0X3N0YXRlKGRhdGEsIHBvcnQpOwo+IEBAIC02MDAsOCArNjE0LDE0 IEBAIHN0YXRpYyB2b2lkIHRlc3RfZGlzcGxheV9vbmVfbW9kZShkYXRhX3QgKmRhdGEsIHN0cnVj dAo+IGNoYW1lbGl1bV9wb3J0ICpwb3J0LAo+ICAJcHJpbWFyeSA9IGlndF9vdXRwdXRfZ2V0X3Bs YW5lX3R5cGUob3V0cHV0LCBEUk1fUExBTkVfVFlQRV9QUklNQVJZKTsKPiAgCWlndF9hc3NlcnQo cHJpbWFyeSk7Cj4gIAo+IC0JZG9fdGVzdF9kaXNwbGF5KGRhdGEsIHBvcnQsIG91dHB1dCwgJmNv bm5lY3Rvci0+bW9kZXNbMF0sIGZvdXJjYywKPiAtCQkJY2hlY2ssIGNvdW50KTsKPiArCW1vZGUg PSAmY29ubmVjdG9yLT5tb2Rlc1swXTsKPiArCWlmIChjaGVjayA9PSBDSEFNRUxJVU1fQ0hFQ0tf QU5BTE9HKSB7Cj4gKwkJYm9vbCBicmlkZ2UgPSBjaGVja19hbmFsb2dfYnJpZGdlKGRhdGEsIHBv cnQpOwo+ICsKPiArCQlpZ3RfYXNzZXJ0KCEoYnJpZGdlICYmIHBydW5lX3ZnYV9tb2RlKGRhdGEs IG1vZGUpKSk7Cj4gKwl9Cj4gKwo+ICsJZG9fdGVzdF9kaXNwbGF5KGRhdGEsIHBvcnQsIG91dHB1 dCwgbW9kZSwgZm91cmNjLCBjaGVjaywgY291bnQpOwo+ICAKPiAgCWRybU1vZGVGcmVlQ29ubmVj dG9yKGNvbm5lY3Rvcik7Cj4gIH0KPiBAQCAtNjEzLDYgKzYzMyw3IEBAIHN0YXRpYyB2b2lkIHRl c3RfZGlzcGxheV9hbGxfbW9kZXMoZGF0YV90ICpkYXRhLCBzdHJ1Y3QKPiBjaGFtZWxpdW1fcG9y dCAqcG9ydCwKPiAgCWlndF9vdXRwdXRfdCAqb3V0cHV0Owo+ICAJaWd0X3BsYW5lX3QgKnByaW1h cnk7Cj4gIAlkcm1Nb2RlQ29ubmVjdG9yICpjb25uZWN0b3I7Cj4gKwlib29sIGJyaWRnZTsKPiAg CWludCBpOwo+ICAKPiAgCXJlc2V0X3N0YXRlKGRhdGEsIHBvcnQpOwo+IEBAIC02MjIsOSArNjQz LDE2IEBAIHN0YXRpYyB2b2lkIHRlc3RfZGlzcGxheV9hbGxfbW9kZXMoZGF0YV90ICpkYXRhLCBz dHJ1Y3QKPiBjaGFtZWxpdW1fcG9ydCAqcG9ydCwKPiAgCXByaW1hcnkgPSBpZ3Rfb3V0cHV0X2dl dF9wbGFuZV90eXBlKG91dHB1dCwgRFJNX1BMQU5FX1RZUEVfUFJJTUFSWSk7Cj4gIAlpZ3RfYXNz ZXJ0KHByaW1hcnkpOwo+ICAKPiArCWlmIChjaGVjayA9PSBDSEFNRUxJVU1fQ0hFQ0tfQU5BTE9H KQo+ICsJCWJyaWRnZSA9IGNoZWNrX2FuYWxvZ19icmlkZ2UoZGF0YSwgcG9ydCk7Cj4gKwo+ICAJ Zm9yIChpID0gMDsgaSA8IGNvbm5lY3Rvci0+Y291bnRfbW9kZXM7IGkrKykgewo+ICAJCWRybU1v ZGVNb2RlSW5mbyAqbW9kZSA9ICZjb25uZWN0b3ItPm1vZGVzW2ldOwo+ICAKPiArCQlpZiAoY2hl Y2sgPT0gQ0hBTUVMSVVNX0NIRUNLX0FOQUxPRyAmJiBicmlkZ2UgJiYKPiArCQkgICAgcHJ1bmVf dmdhX21vZGUoZGF0YSwgbW9kZSkpCj4gKwkJCWNvbnRpbnVlOwo+ICsKPiAgCQlkb190ZXN0X2Rp c3BsYXkoZGF0YSwgcG9ydCwgb3V0cHV0LCBtb2RlLCBmb3VyY2MsIGNoZWNrLAo+IGNvdW50KTsK PiAgCX0KPiAgCj4gQEAgLTY3NSw2MSArNzAzLDYgQEAgdGVzdF9kaXNwbGF5X2ZyYW1lX2R1bXAo ZGF0YV90ICpkYXRhLCBzdHJ1Y3QKPiBjaGFtZWxpdW1fcG9ydCAqcG9ydCkKPiAgCWRybU1vZGVG cmVlQ29ubmVjdG9yKGNvbm5lY3Rvcik7Cj4gIH0KPiAgCj4gLXN0YXRpYyB2b2lkCj4gLXRlc3Rf YW5hbG9nX2ZyYW1lX2R1bXAoZGF0YV90ICpkYXRhLCBzdHJ1Y3QgY2hhbWVsaXVtX3BvcnQgKnBv cnQpCj4gLXsKPiAtCWlndF9vdXRwdXRfdCAqb3V0cHV0Owo+IC0JaWd0X3BsYW5lX3QgKnByaW1h cnk7Cj4gLQlzdHJ1Y3QgaWd0X2ZiIGZiOwo+IC0Jc3RydWN0IGNoYW1lbGl1bV9mcmFtZV9kdW1w ICpmcmFtZTsKPiAtCWRybU1vZGVNb2RlSW5mbyAqbW9kZTsKPiAtCWRybU1vZGVDb25uZWN0b3Ig KmNvbm5lY3RvcjsKPiAtCWludCBmYl9pZCwgaTsKPiAtCWJvb2wgYnJpZGdlOwo+IC0KPiAtCXJl c2V0X3N0YXRlKGRhdGEsIHBvcnQpOwo+IC0KPiAtCW91dHB1dCA9IHByZXBhcmVfb3V0cHV0KGRh dGEsIHBvcnQpOwo+IC0JY29ubmVjdG9yID0gY2hhbWVsaXVtX3BvcnRfZ2V0X2Nvbm5lY3Rvcihk YXRhLT5jaGFtZWxpdW0sIHBvcnQsCj4gZmFsc2UpOwo+IC0JcHJpbWFyeSA9IGlndF9vdXRwdXRf Z2V0X3BsYW5lX3R5cGUob3V0cHV0LCBEUk1fUExBTkVfVFlQRV9QUklNQVJZKTsKPiAtCWlndF9h c3NlcnQocHJpbWFyeSk7Cj4gLQo+IC0JYnJpZGdlID0gY2hlY2tfYW5hbG9nX2JyaWRnZShkYXRh LCBwb3J0KTsKPiAtCj4gLQlmb3IgKGkgPSAwOyBpIDwgY29ubmVjdG9yLT5jb3VudF9tb2Rlczsg aSsrKSB7Cj4gLQkJbW9kZSA9ICZjb25uZWN0b3ItPm1vZGVzW2ldOwo+IC0KPiAtCQlpZiAoYnJp ZGdlICYmIHBydW5lX3ZnYV9tb2RlKGRhdGEsIG1vZGUpKQo+IC0JCQljb250aW51ZTsKPiAtCj4g LQkJZmJfaWQgPSBpZ3RfY3JlYXRlX2NvbG9yX3BhdHRlcm5fZmIoZGF0YS0+ZHJtX2ZkLAo+IC0J CQkJCQkgICAgbW9kZS0+aGRpc3BsYXksIG1vZGUtCj4gPnZkaXNwbGF5LAo+IC0JCQkJCQkgICAg RFJNX0ZPUk1BVF9YUkdCODg4OCwKPiAtCQkJCQkJICAgIExPQ0FMX0RSTV9GT1JNQVRfTU9EX05P TkUsCj4gLQkJCQkJCSAgICAwLCAwLCAwLCAmZmIpOwo+IC0JCWlndF9hc3NlcnQoZmJfaWQgPiAw KTsKPiAtCj4gLQkJZW5hYmxlX291dHB1dChkYXRhLCBwb3J0LCBvdXRwdXQsIG1vZGUsICZmYik7 Cj4gLQo+IC0JCWlndF9kZWJ1ZygiUmVhZGluZyBmcmFtZSBkdW1wcyBmcm9tIENoYW1lbGl1bS4u LlxuIik7Cj4gLQo+IC0JCWZyYW1lID0gY2hhbWVsaXVtX3BvcnRfZHVtcF9waXhlbHMoZGF0YS0+ Y2hhbWVsaXVtLCBwb3J0LCAwLAo+IDAsCj4gLQkJCQkJCSAgIDAsIDApOwo+IC0KPiAtCQljaGFt ZWxpdW1fY3JvcF9hbmFsb2dfZnJhbWUoZnJhbWUsIG1vZGUtPmhkaXNwbGF5LAo+IC0JCQkJCSAg ICBtb2RlLT52ZGlzcGxheSk7Cj4gLQo+IC0JCWNoYW1lbGl1bV9hc3NlcnRfYW5hbG9nX2ZyYW1l X21hdGNoX29yX2R1bXAoZGF0YS0+Y2hhbWVsaXVtLAo+IC0JCQkJCQkJICAgIHBvcnQsIGZyYW1l LCAmZmIpOwo+IC0KPiAtCQljaGFtZWxpdW1fZGVzdHJveV9mcmFtZV9kdW1wKGZyYW1lKTsKPiAt Cj4gLQkJaWd0X3JlbW92ZV9mYihkYXRhLT5kcm1fZmQsICZmYik7Cj4gLQl9Cj4gLQo+IC0JZHJt TW9kZUZyZWVDb25uZWN0b3IoY29ubmVjdG9yKTsKPiAtfQo+IC0KPiAgc3RhdGljIHZvaWQKPiAg dGVzdF9ocGRfd2l0aG91dF9kZGMoZGF0YV90ICpkYXRhLCBzdHJ1Y3QgY2hhbWVsaXVtX3BvcnQg KnBvcnQpCj4gIHsKPiBAQCAtMTA0MSw3ICsxMDE0LDggQEAgaWd0X21haW4KPiAgCQkJdGVzdF9o cGRfd2l0aG91dF9kZGMoJmRhdGEsIHBvcnQpOwo+ICAKPiAgCQljb25uZWN0b3Jfc3VidGVzdCgi dmdhLWZyYW1lLWR1bXAiLCBWR0EpCj4gLQkJCXRlc3RfYW5hbG9nX2ZyYW1lX2R1bXAoJmRhdGEs IHBvcnQpOwo+ICsJCQl0ZXN0X2Rpc3BsYXlfYWxsX21vZGVzKCZkYXRhLCBwb3J0LAo+IERSTV9G T1JNQVRfWFJHQjg4ODgsCj4gKwkJCQkJICAgICAgIENIQU1FTElVTV9DSEVDS19BTkFMT0csIDEp Owo+ICAJfQo+ICAKPiAgCWlndF9zdWJ0ZXN0X2dyb3VwIHsKLS0gCkNoZWVycywKCUx5dWRlIFBh dWwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlndC1k ZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgo=